Changeset 53113 in webkit


Ignore:
Timestamp:
Jan 11, 2010 5:22:46 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-01-11 Victor Wang <victorw@chromium.org>

Reviewed by Dimitri Glazkov.

Clear m_acceptedIndexOnAbandon flag when user accepts the selected index.

https://bugs.webkit.org/show_bug.cgi?id=33499

TEST: manual-tests/chromium/onchange-reload-popup.html
It should be covered by the above test. The current
test shell does not support sending keyboard events to popup
list so use manual test for it.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::acceptIndex):
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r53111 r53113  
     12010-01-11  Victor Wang  <victorw@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        Clear m_acceptedIndexOnAbandon flag when user accepts the selected index.
     6
     7        https://bugs.webkit.org/show_bug.cgi?id=33499
     8
     9        TEST: manual-tests/chromium/onchange-reload-popup.html
     10        It should be covered by the above test. The current
     11        test shell does not support sending keyboard events to popup
     12        list so use manual test for it.
     13
     14        * platform/chromium/PopupMenuChromium.cpp:
     15        (WebCore::PopupListBox::acceptIndex):
     16
    1172010-01-11  Gustavo Noronha Silva  <gns@gnome.org>
    218
  • trunk/WebCore/platform/chromium/PopupMenuChromium.cpp

    r52791 r53113  
    912912void PopupListBox::acceptIndex(int index)
    913913{
     914    // Clear m_acceptedIndexOnAbandon once user accepts the selected index.
     915    if (m_acceptedIndexOnAbandon >= 0)
     916        m_acceptedIndexOnAbandon = -1;
     917
    914918    if (index >= numItems())
    915919        return;
Note: See TracChangeset for help on using the changeset viewer.