Changeset 53121 in webkit

Timestamp:

Jan 12, 2010 1:41:36 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-01-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch shouldn't waste my time for with a component prompt
​https://bugs.webkit.org/show_bug.cgi?id=33521

The component field isn't very useful for bugs created with
webkit-patch because they're likely to be resolved quickly. Instead of
always prompting for a component, we should just default to the "New
Bugs" component. If the bug stays around for more than five minutes,
we can assign it a proper component.

• Scripts/webkitpy/bugzilla.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/bugzilla.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-01-12  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        webkit-patch shouldn't waste my time for with a component prompt
+        https://bugs.webkit.org/show_bug.cgi?id=33521
+
+        The component field isn't very useful for bugs created with
+        webkit-patch because they're likely to be resolved quickly.  Instead of
+        always prompting for a component, we should just default to the "New
+        Bugs" component.  If the bug stays around for more than five minutes,
+        we can assign it a proper component.
+
+        * Scripts/webkitpy/bugzilla.py:
+
 2010-01-12  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/bugzilla.py

@@ -400 +400 @@
         component_items = self.browser.find_control('component').items
         component_names = map(lambda item: item.name, component_items)
-        if not component or component not in component_names:
+        if not component:
+            component = "New Bugs"
+        if component not in component_names:
             component = self.prompt_for_component(component_names)
         self.browser['component'] = [component]