Changeset 53138 in webkit


Ignore:
Timestamp:
Jan 12, 2010 5:48:08 AM (14 years ago)
Author:
kov@webkit.org
Message:

Reviewed by Xan Lopez.

[GTK] couple fixes for signal emissions, and property notifications
https://bugs.webkit.org/show_bug.cgi?id=33428

Fix commitedLoad being called where it should not, causing it to
be called one time too many in some cases. We now match Qt's and
Mac's behavior here.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::finishedLoading):
  • tests/testloading.c: (load_error_status_changed_cb):
Location:
trunk/WebKit/gtk
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit/gtk/ChangeLog

    r53084 r53138  
     12010-01-12  Gustavo Noronha Silva  <gns@gnome.org>
     2
     3        Reviewed by Xan Lopez.
     4
     5        [GTK] couple fixes for signal emissions, and property notifications
     6        https://bugs.webkit.org/show_bug.cgi?id=33428
     7
     8        Fix commitedLoad being called where it should not, causing it to
     9        be called one time too many in some cases. We now match Qt's and
     10        Mac's behavior here.
     11
     12        * WebCoreSupport/FrameLoaderClientGtk.cpp:
     13        (WebKit::FrameLoaderClient::finishedLoading):
     14        * tests/testloading.c:
     15        (load_error_status_changed_cb):
     16
    1172010-01-08  Gustavo Noronha Silva  <gns@gnome.org>
    218
  • trunk/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp

    r53084 r53138  
    841841void FrameLoaderClient::finishedLoading(WebCore::DocumentLoader* documentLoader)
    842842{
    843     if (!m_pluginView)
    844         committedLoad(documentLoader, 0, 0);
    845     else {
     843    if (!m_pluginView) {
     844        FrameLoader* loader = documentLoader->frameLoader();
     845        loader->setEncoding(m_response.textEncodingName(), false);
     846    } else {
    846847        m_pluginView->didFinishLoading();
    847848        m_pluginView = 0;
  • trunk/WebKit/gtk/tests/testloading.c

    r53084 r53138  
    175175         * anything */
    176176        fixture->has_been_provisional = TRUE;
     177        break;
     178    case WEBKIT_LOAD_COMMITTED:
     179        g_assert(!fixture->has_been_committed);
     180        fixture->has_been_committed = TRUE;
    177181        break;
    178182    case WEBKIT_LOAD_FINISHED:
Note: See TracChangeset for help on using the changeset viewer.