Changeset 53163 in webkit

Timestamp:

Jan 12, 2010 2:07:21 PM (14 years ago)

Author:

jhoneycutt@apple.com

Message:

MSAA: Accessibility role of <select multiple> elements is wrong

​https://bugs.webkit.org/show_bug.cgi?id=33522

Reviewed by Darin Adler.

WebKit/win:

• AccessibleBase.cpp:

(MSAARole):
Map the WebCore::ListBox and WebCore::ListBoxOption roles to the MSAA
"list" and "list item" roles.

LayoutTests:

• platform/win/accessibility/multiple-select-element-role-expected.txt: Added.
• platform/win/accessibility/multiple-select-element-role.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/win/accessibility/multiple-select-element-role-expected.txt (added)
• LayoutTests/platform/win/accessibility/multiple-select-element-role.html (added)
• WebKit/win/AccessibleBase.cpp (modified) (2 diffs)
• WebKit/win/ChangeLog (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-01-11  Jon Honeycutt  <jhoneycutt@apple.com>
+
+        MSAA: Accessibility role of <select multiple> elements is wrong
+
+        https://bugs.webkit.org/show_bug.cgi?id=33522
+
+        Reviewed by Darin Adler.
+
+        * platform/win/accessibility/multiple-select-element-role-expected.txt: Added.
+        * platform/win/accessibility/multiple-select-element-role.html: Added.
+
 2010-01-12  Beth Dakin  <bdakin@apple.com>
 

trunk/WebKit/win/AccessibleBase.cpp

@@ -557 +557 @@
             return ROLE_SYSTEM_GROUPING;
         case WebCore::ListRole:
+        case WebCore::ListBoxRole:
             return ROLE_SYSTEM_LIST;
         case WebCore::TableRole:
@@ -567 +568 @@
             return ROLE_SYSTEM_GRAPHIC;
         case WebCore::ListItemRole:
+        case WebCore::ListBoxOptionRole:
             return ROLE_SYSTEM_LISTITEM;
         case WebCore::PopUpButtonRole:

trunk/WebKit/win/ChangeLog

@@ +1 @@
+2010-01-11  Jon Honeycutt  <jhoneycutt@apple.com>
+
+        MSAA: Accessibility role of <select multiple> elements is wrong
+
+        https://bugs.webkit.org/show_bug.cgi?id=33522
+
+        Reviewed by Darin Adler.
+
+        * AccessibleBase.cpp:
+        (MSAARole):
+        Map the WebCore::ListBox and WebCore::ListBoxOption roles to the MSAA
+        "list" and "list item" roles.
+
 2010-01-08  Brent Fulgham  <bfulgham@webkit.org>