Changeset 53258 in webkit

Timestamp:

Jan 14, 2010 4:11:44 AM (14 years ago)

Author:

Philippe Normand

Message:

2010-01-13 Philippe Normand <​pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] Failing media/video-seek-past-end-playing.html
​https://bugs.webkit.org/show_bug.cgi?id=33015

• media/video-seek-past-end-playing.html: Removed the last timer of this test.
• platform/gtk/Skipped: Unskip test above.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• media/video-seek-past-end-playing.html (modified) (1 diff)
• platform/gtk/Skipped (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-01-13  Philippe Normand  <pnormand@igalia.com>
+
+        Reviewed by Xan Lopez.
+
+        [GTK] Failing media/video-seek-past-end-playing.html
+        https://bugs.webkit.org/show_bug.cgi?id=33015
+
+        * media/video-seek-past-end-playing.html: Removed the last timer of this test.
+        * platform/gtk/Skipped: Unskip test above.
+
 2010-01-14  Eric Seidel  <eric@webkit.org>
 

trunk/LayoutTests/media/video-seek-past-end-playing.html

@@ -27 +27 @@
            testExpected("mediaElement.currentTime", 0, '>');
            run("video.currentTime = 500");
-           setTimeout(seekCheck, 200);
+        } else if (timeupdateEventCount == 10) {
+           // Wait some more timeupdate events so we can check the
+           // media engine performed the seek.
+           consoleWrite("");
+           testExpected("video.paused", false);
+           testExpected("mediaElement.currentTime", 0, '>');
+           consoleWrite("");
+           // reset the counter to prevent infinite loop if the
+           // test is re-executed manually.
+           timeupdateEventCount = 0;
+           endTest();
         }
-    }
-
-    function seekCheck()
-    {
-        consoleWrite("");
-        testExpected("video.paused", false);
-        testExpected("mediaElement.currentTime", 0, '>');
-        consoleWrite("");
-        // reset the counter to prevent infinite loop if the
-        // test is re-executed manually.
-        timeupdateEventCount = 0;
-        endTest();
     }
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -5746 +5746 @@
 # Fails on and off (more often fails) on the release bot
 media/event-attributes.html
-
-# Fails on release bot, see https://bugs.webkit.org/show_bug.cgi?id=33015
-media/video-seek-past-end-playing.html