Changeset 53302 in webkit


Ignore:
Timestamp:
Jan 14, 2010 5:22:54 PM (14 years ago)
Author:
ojan@chromium.org
Message:

2010-01-13 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

A few more flaky transitions/animations tests
​https://bugs.webkit.org/show_bug.cgi?id=33642

Attempt to deflake a few more tests. Some of these are second
attempts. The first attempt made it less flaky, but not 100%.
Also, for a couple tests, make them shorter. They seemed
unnecessarily long.

  • animations/change-one-anim-expected.txt:
  • animations/change-one-anim.html:
  • transitions/cancel-transition.html:
  • transitions/mask-transitions.html:
  • transitions/shorthand-border-transitions-expected.txt:
  • transitions/shorthand-border-transitions.html:
Location:
trunk/LayoutTests
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r53300 r53302  
     12010-01-13  Ojan Vafai  <ojan@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        A few more flaky transitions/animations tests
     6        https://bugs.webkit.org/show_bug.cgi?id=33642
     7
     8        Attempt to deflake a few more tests. Some of these are second
     9        attempts. The first attempt made it less flaky, but not 100%.
     10        Also, for a couple tests, make them shorter. They seemed
     11        unnecessarily long.
     12
     13        * animations/change-one-anim-expected.txt:
     14        * animations/change-one-anim.html:
     15        * transitions/cancel-transition.html:
     16        * transitions/mask-transitions.html:
     17        * transitions/shorthand-border-transitions-expected.txt:
     18        * transitions/shorthand-border-transitions.html:
     19
    1202010-01-14  Beth Dakin  <bdakin@apple.com>
    221

  • trunk/LayoutTests/animations/change-one-anim-expected.txt

    r39187 r53302  
    1 This test performs two animations, left and top. It animates over 1 second. At 0.5 second it removes the left animation and the top animation should continue from where it left off.
    2 PASS - "left" property for "box" element at 0.75s saw something close to: 150
    3 PASS - "top" property for "box" element at 0.75s saw something close to: 225
     1This test performs two animations, left and top. It animates over 0.4 second. At 0.2 second it removes the left animation and the top animation should continue from where it left off.
     2PASS - "left" property for "box" element at 0.3s saw something close to: 200
     3PASS - "top" property for "box" element at 0.3s saw something close to: 300
    44

  • trunk/LayoutTests/animations/change-one-anim.html

    r52844 r53302  
    99        #box {
    1010            position: relative;
    11             height: 200px;
    12             width: 200px;
     11            height: 20px;
     12            width: 20px;
    1313            background-color: #9bb;
    1414            -webkit-animation-name: horiz, vert;
    15             -webkit-animation-duration: 1s;
     15            -webkit-animation-duration: 0.4s;
    1616            -webkit-animation-iteration-count: infinite;
    1717            -webkit-animation-direction: alternate;
    … …  
    2121         @-webkit-keyframes horiz {
    2222            from { left: 0px; }
    23             to { left: 300px; }
     23            to { left: 400px; }
    2424         }
    2525         @-webkit-keyframes vert {
    2626            from { top: 0px; }
    27             to { top: 300px; }
     27            to { top: 400px; }
    2828         }
    2929    </style>
    … …  
    3333        const expectedValues = [
    3434          // [animation-name, time, element-id, property, expected-value, tolerance]
    35           [null, 0.75, "box", "left", 150, 30],
    36           [null, 0.75, "box", "top", 225, 30],
     35          [null, 0.3, "box", "left", 200, 40],
     36          [null, 0.3, "box", "top", 300, 40],
    3737        ];
    3838
    … …  
    4747        function setup()
    4848        {
    49             setTimeout("removeAnim()", 500);
     49            setTimeout("removeAnim()", 200);
    5050        }
    5151
    … …  
    5454</head>
    5555<body>
    56 This test performs two animations, left and top. It animates over 1 second.
    57 At 0.5 second it removes the left animation and the top animation should continue
     56This test performs two animations, left and top. It animates over 0.4 second.
     57At 0.2 second it removes the left animation and the top animation should continue
    5858from where it left off.
    5959<div id="box">

  • trunk/LayoutTests/transitions/cancel-transition.html

    r53006 r53302  
    5151        function isEqual(actual, desired, tolerance)
    5252        {
    53             if (tolerance == undefined || tolerance == 0)
    54                 tolerance = defaultTolerance;
    5553            var diff = Math.abs(actual - desired);
    5654            return diff < tolerance;
    … …  
    6563        {
    6664            document.getElementById("container").className = "run";
    67             setTimeout("check()", 250);
    6865        }
    6966
    … …  
    9794            setTimeout("cancelTransition()", 100);
    9895            setTimeout("restartTransition()", 200);
     96            setTimeout("check()", 500);
    9997        }
    10098    </script>

  • trunk/LayoutTests/transitions/mask-transitions.html

    r42823 r53302  
    3838    const expectedValues = [
    3939      // [time, element-id, property, expected-value, tolerance]
    40       [0.5, 'box', '-webkit-mask-position', [10, 10], 2],
    41       [0.5, 'box2', '-webkit-mask-size', [150, 150], 10],
     40      [0.5, 'box', '-webkit-mask-position', [10, 10], 4],
     41      [0.5, 'box2', '-webkit-mask-size', [150, 150], 20],
    4242    ];
    4343 

  • trunk/LayoutTests/transitions/shorthand-border-transitions-expected.txt

    r40051 r53302  
    11Tests transitions of the border shorthand properties.
    22
    3 PASS - "border-top-color" property for "box" element at 0.5s saw something close to: 128,0,128
    4 PASS - "border-right-color" property for "box" element at 0.5s saw something close to: 128,0,128
    5 PASS - "border-bottom-color" property for "box" element at 0.5s saw something close to: 128,0,128
    6 PASS - "border-left-color" property for "box" element at 0.5s saw something close to: 128,0,128
    7 PASS - "border-top-width" property for "box" element at 0.5s saw something close to: 10
    8 PASS - "border-right-width" property for "box" element at 0.5s saw something close to: 10
    9 PASS - "border-bottom-width" property for "box" element at 0.5s saw something close to: 10
    10 PASS - "border-left-width" property for "box" element at 0.5s saw something close to: 10
    11 PASS - "border-top-width" property for "box1" element at 0.5s saw something close to: 10
    12 PASS - "border-top-color" property for "box1" element at 0.5s saw something close to: 255,0,255
    13 PASS - "border-top-width" property for "box2" element at 0.5s saw something close to: 10
    14 PASS - "border-bottom-width" property for "box2" element at 0.5s saw something close to: 20
     3PASS - "border-top-color" property for "box" element at 0.25s saw something close to: 128,0,128
     4PASS - "border-right-color" property for "box" element at 0.25s saw something close to: 128,0,128
     5PASS - "border-bottom-color" property for "box" element at 0.25s saw something close to: 128,0,128
     6PASS - "border-left-color" property for "box" element at 0.25s saw something close to: 128,0,128
     7PASS - "border-top-width" property for "box" element at 0.25s saw something close to: 10
     8PASS - "border-right-width" property for "box" element at 0.25s saw something close to: 10
     9PASS - "border-bottom-width" property for "box" element at 0.25s saw something close to: 10
     10PASS - "border-left-width" property for "box" element at 0.25s saw something close to: 10
     11PASS - "border-top-width" property for "box1" element at 0.25s saw something close to: 10
     12PASS - "border-top-color" property for "box1" element at 0.25s saw something close to: 255,0,255
     13PASS - "border-top-width" property for "box2" element at 0.25s saw something close to: 10
     14PASS - "border-bottom-width" property for "box2" element at 0.25s saw something close to: 20
    1515

  • trunk/LayoutTests/transitions/shorthand-border-transitions.html

    r52999 r53302  
    1313      background-color: gray;
    1414      border: 0px solid rgb(0, 0, 0);
    15       -webkit-transition: border 1s linear;
     15      -webkit-transition: border 0.5s linear;
    1616    }
    1717   
    … …  
    2626      background-color: gray;
    2727      border: 0px solid rgb(0, 0, 0);
    28       -webkit-transition: border-width 1s linear;
     28      -webkit-transition: border-width 0.5s linear;
    2929    }
    3030   
    … …  
    3939      background-color: gray;
    4040      border: 0px solid rgb(0, 0, 0);
    41       -webkit-transition: border 1s linear;
     41      -webkit-transition: border 0.5s linear;
    4242    }
    4343   
    … …  
    5353      // [time, element-id, property, expected-value, tolerance]
    5454      // color and width of each side should be animating
    55       [0.5, 'box', 'border-top-color', [128, 0, 128], 15],
    56       [0.5, 'box', 'border-right-color', [128, 0, 128], 15],
    57       [0.5, 'box', 'border-bottom-color', [128, 0, 128], 15],
    58       [0.5, 'box', 'border-left-color', [128, 0, 128], 15],
    59       [0.5, 'box', 'border-top-width', 10, 1],
    60       [0.5, 'box', 'border-right-width', 10, 1],
    61       [0.5, 'box', 'border-bottom-width', 10, 1],
    62       [0.5, 'box', 'border-left-width', 10, 1],
     55      [0.25, 'box', 'border-top-color', [128, 0, 128], 20],
     56      [0.25, 'box', 'border-right-color', [128, 0, 128], 20],
     57      [0.25, 'box', 'border-bottom-color', [128, 0, 128], 20],
     58      [0.25, 'box', 'border-left-color', [128, 0, 128], 20],
     59      [0.25, 'box', 'border-top-width', 10, 2],
     60      [0.25, 'box', 'border-right-width', 10, 2],
     61      [0.25, 'box', 'border-bottom-width', 10, 2],
     62      [0.25, 'box', 'border-left-width', 10, 2],
    6363
    6464      // only border-width should be animating
    65       [0.5, 'box1', 'border-top-width', 10, 1],
    66       [0.5, 'box1', 'border-top-color', [255, 0, 255], 0],  // initial value
     65      [0.25, 'box1', 'border-top-width', 10, 2],
     66      [0.25, 'box1', 'border-top-color', [255, 0, 255], 0],  // initial value
    6767
    6868      // border-width should be animating
    69       [0.5, 'box2', 'border-top-width', 10, 1],
    70       [0.5, 'box2', 'border-bottom-width', 20, 2],
     69      [0.25, 'box2', 'border-top-width', 10, 2],
     70      [0.25, 'box2', 'border-bottom-width', 20, 4],
    7171    ];
    7272   
Note: See TracChangeset for help on using the changeset viewer.