Changeset 53321 in webkit

Timestamp:

Jan 14, 2010 10:55:52 PM (14 years ago)

Author:

jorlow@chromium.org

Message:

2010-01-14 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Oliver Hunt.

[Chromium] Forgot to adopt a ref counted object in StorageNamespaceProxy
​https://bugs.webkit.org/show_bug.cgi?id=33704

• src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::localStorageNamespace): (WebCore::StorageNamespace::sessionStorageNamespace):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/StorageNamespaceProxy.cpp (modified) (2 diffs)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-01-14  Jeremy Orlow  <jorlow@chromium.org>
+
+        Reviewed by Oliver Hunt.
+
+        [Chromium] Forgot to adopt a ref counted object in StorageNamespaceProxy
+        https://bugs.webkit.org/show_bug.cgi?id=33704
+
+        * src/StorageNamespaceProxy.cpp:
+        (WebCore::StorageNamespace::localStorageNamespace):
+        (WebCore::StorageNamespace::sessionStorageNamespace):
+
 2010-01-14  Marcus Bulach  <bulach@chromium.org>
 

trunk/WebKit/chromium/src/StorageNamespaceProxy.cpp

@@ -45 +45 @@
 PassRefPtr<StorageNamespace> StorageNamespace::localStorageNamespace(const String& path, unsigned quota)
 {
-    return new StorageNamespaceProxy(WebKit::webKitClient()->createLocalStorageNamespace(path, quota));
+    return adoptRef(new StorageNamespaceProxy(WebKit::webKitClient()->createLocalStorageNamespace(path, quota)));
 }
 
@@ -52 +52 @@
     WebKit::ChromeClientImpl* chromeClientImpl = static_cast<WebKit::ChromeClientImpl*>(page->chrome()->client());
     WebKit::WebViewClient* webViewClient = chromeClientImpl->webView()->client();
-    return new StorageNamespaceProxy(webViewClient->createSessionStorageNamespace());
+    return adoptRef(new StorageNamespaceProxy(webViewClient->createSessionStorageNamespace()));
 }