Changeset 53379 in webkit

Timestamp:

Jan 17, 2010 5:33:13 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

EWS (Early Warning Systems) should build both debug and release
​https://bugs.webkit.org/show_bug.cgi?id=33681

Build both debug and release for chromium-ews.

• Scripts/webkitpy/commands/early_warning_system.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/commands/early_warning_system.py (modified) (4 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-01-17  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        EWS (Early Warning Systems) should build both debug and release
+        https://bugs.webkit.org/show_bug.cgi?id=33681
+
+        Build both debug and release for chromium-ews.
+
+        * Scripts/webkitpy/commands/early_warning_system.py:
+
 2010-01-17  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/commands/early_warning_system.py

@@ -38 +38 @@
 
 class AbstractEarlyWarningSystem(AbstractReviewQueue):
+    _build_style = "release"
+
     def __init__(self):
         AbstractReviewQueue.__init__(self)
@@ -44 +46 @@
     def should_proceed_with_work_item(self, patch):
         try:
-            self.run_webkit_patch(["build", self.port.flag(), "--force-clean", "--quiet"])
+            self.run_webkit_patch([
+                "build",
+                self.port.flag(),
+                "--build-style=%s" % self._build_style,
+                "--force-clean",
+                "--quiet"])
             self._update_status("Building", patch)
         except ScriptError, e:
@@ -55 +62 @@
             "build-attachment",
             self.port.flag(),
+            "--build-style=%s" % self._build_style,
             "--force-clean",
             "--quiet",
@@ -91 +99 @@
     name = "chromium-ews"
     port_name = "chromium"
+    _build_style = "both"
     watchers = AbstractEarlyWarningSystem.watchers + [
         "dglazkov@chromium.org",