Changeset 53386 in webkit

Timestamp:

Jan 17, 2010 7:11:47 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-17 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

[check-webkit-style] qt unit testing false positives
​https://bugs.webkit.org/show_bug.cgi?id=32833

Exempt the Qt API and unit tests from the style checker.

• Scripts/webkitpy/style/cpp_style.py:
• Scripts/webkitpy/style/cpp_style_unittest.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/style/cpp_style.py (modified) (1 diff)
• Scripts/webkitpy/style/cpp_style_unittest.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-01-17  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        [check-webkit-style] qt unit testing false positives
+        https://bugs.webkit.org/show_bug.cgi?id=32833
+
+        Exempt the Qt API and unit tests from the style checker.
+
+        * Scripts/webkitpy/style/cpp_style.py:
+        * Scripts/webkitpy/style/cpp_style_unittest.py:
+
 2010-01-17  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/style/cpp_style.py

@@ -2927 +2927 @@
       filename: A filename. It may contain directory names.
      """
+    if (filename.find('WebKit/qt/Api/') >= 0
+        or filename.find('WebKit/qt/tests/') >= 0):
+        # The Qt API and tests do not follow WebKit style.
+        # They follow Qt style. :)
+        return True
+
     return os.path.basename(filename) in (
         'gtk2drawing.c',

trunk/WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py

@@ -3612 +3612 @@
         self.assert_(cpp_style.is_exempt('gtk2drawing.c'))
         self.assert_(cpp_style.is_exempt('WebCore/platform/gtk/gtk2drawing.c'))
+        self.assert_(cpp_style.is_exempt('WebKit/qt/Api/qwebpage.h'))
+        self.assert_(cpp_style.is_exempt('WebKit/qt/tests/qwebsecurityorigin/tst_qwebsecurityorigin.cpp'))
 
 def tearDown():