Changeset 53399 in webkit


Ignore:
Timestamp:
Jan 18, 2010 2:13:39 AM (14 years ago)
Author:
abarth@webkit.org
Message:

2010-01-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

style checker needs to know about GObject-specific requirements
inside WebCore/bindings/gobject/
https://bugs.webkit.org/show_bug.cgi?id=33606

Add an exception to the underscore rule for certain
GObject-specific names.

  • Scripts/webkitpy/style/cpp_style.py:
  • Scripts/webkitpy/style/cpp_style_unittest.py:
Location:
trunk/WebKitTools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r53398 r53399  
     12010-01-18  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        style checker needs to know about GObject-specific requirements
     6        inside WebCore/bindings/gobject/
     7        https://bugs.webkit.org/show_bug.cgi?id=33606
     8
     9        Add an exception to the underscore rule for certain
     10        GObject-specific names.
     11
     12        * Scripts/webkitpy/style/cpp_style.py:
     13        * Scripts/webkitpy/style/cpp_style_unittest.py:
     14
    1152010-01-18  Adam Barth  <abarth@webkit.org>
    216
  • trunk/WebKitTools/Scripts/webkitpy/style/cpp_style.py

    r53398 r53399  
    24702470            if (not (filename.find('JavaScriptCore') >= 0 and modified_identifier.find('_op_') >= 0)
    24712471                and not modified_identifier.startswith('tst_')
     2472                and not modified_identifier.startswith('webkit_dom_object_')
    24722473                and not modified_identifier.startswith('qt_')
    24732474                and not modified_identifier.find('::qt_') >= 0
  • trunk/WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py

    r53398 r53399  
    35703570        self.assert_lint('void this_op_code(int var1, int var2)', 'this_op_code' + name_error_message)
    35713571
     3572        # GObject requires certain magical names in class declarations.
     3573        self.assert_lint('void webkit_dom_object_init();', '')
     3574        self.assert_lint('void webkit_dom_object_class_init();', '')
     3575
    35723576        # There is an exception for some unit tests that begin with "tst_".
    35733577        self.assert_lint('void tst_QWebFrame::arrayObjectEnumerable(int var1, int var2)', '')
Note: See TracChangeset for help on using the changeset viewer.