Changeset 53414 in webkit

Timestamp:

Jan 18, 2010 10:36:26 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-01-18 Adam Barth <​abarth@webkit.org>

Reviewed by Adam Roben.

Rename patches-to-commit to patches-in-commit-queue
​https://bugs.webkit.org/show_bug.cgi?id=33789

The command really lists the patches in the commit-queue not all the
patches that are pending-commit (as the FIXME commands).

• Scripts/webkitpy/commands/queries.py:
• Scripts/webkitpy/commands/queries_unittest.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/commands/queries.py (modified) (1 diff)
• Scripts/webkitpy/commands/queries_unittest.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-01-18  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Adam Roben.
+
+        Rename patches-to-commit to patches-in-commit-queue
+        https://bugs.webkit.org/show_bug.cgi?id=33789
+
+        The command really lists the patches in the commit-queue not all the
+        patches that are pending-commit (as the FIXME commands).
+
+        * Scripts/webkitpy/commands/queries.py:
+        * Scripts/webkitpy/commands/queries_unittest.py:
+
 2010-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 

trunk/WebKitTools/Scripts/webkitpy/commands/queries.py

@@ -49 +49 @@
 
 
-class PatchesToCommit(AbstractDeclarativeCommand):
-    name = "patches-to-commit"
+class PatchesInCommitQueue(AbstractDeclarativeCommand):
+    name = "patches-in-commit-queue"
     help_text = "List patches in the commit-queue"
 
     def execute(self, options, args, tool):
-        # FIXME: This command is poorly named.  It's fetching the commit-queue list here.  The name implies it's fetching pending-commit (all r+'d patches).
         patches = tool.bugs.queries.fetch_patches_from_commit_queue()
         log("Patches in commit queue:")

trunk/WebKitTools/Scripts/webkitpy/commands/queries_unittest.py

@@ -40 +40 @@
         self.assert_execute_outputs(BugsToCommit(), None, "42\n77\n", expected_stderr)
 
-    def test_patches_to_commit(self):
+    def test_patches_in_commit_queue(self):
         expected_stdout = "http://example.com/197\nhttp://example.com/103\n"
         expected_stderr = "Warning, attachment 128 on bug 42 has invalid committer (non-committer@example.com)\nPatches in commit queue:\n"
-        self.assert_execute_outputs(PatchesToCommit(), None, expected_stdout, expected_stderr)
+        self.assert_execute_outputs(PatchesInCommitQueue(), None, expected_stdout, expected_stderr)
 
     def test_patches_to_commit_queue(self):