Changeset 53492 in webkit


Ignore:
Timestamp:
Jan 19, 2010 2:14:03 PM (14 years ago)
Author:
ojan@chromium.org
Message:

2010-01-15 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

LayoutTests/animations/play-state.html and LayoutTests/transitions/cancel-transition.html are still flaky
https://bugs.webkit.org/show_bug.cgi?id=33748

  • animations/play-state-expected.txt:
  • animations/play-state.html: Undo my previous change of decreasing the length of the test. I think that made it more flaky. Also increase the tolerance.
  • transitions/cancel-transition.html: Undo my previous change of moving the setTimeout. It was correct where it was. Added a comment to make it more clear. The tolerances were increased since then though, so this test should no longer be flaky after this.
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r53488 r53492  
     12010-01-15  Ojan Vafai  <ojan@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        LayoutTests/animations/play-state.html and LayoutTests/transitions/cancel-transition.html are still flaky
     6        https://bugs.webkit.org/show_bug.cgi?id=33748
     7
     8        * animations/play-state-expected.txt:
     9        * animations/play-state.html:
     10        Undo my previous change of decreasing the length of the test. I think that made it more flaky.
     11        Also increase the tolerance.
     12
     13        * transitions/cancel-transition.html:
     14        Undo my previous change of moving the setTimeout. It was correct where it was.
     15        Added a comment to make it more clear. The tolerances were increased since then though,
     16        so this test should no longer be flaky after this.
     17
    1182010-01-19  Jaime Yap  <jaimeyap@google.com>
    219
  • trunk/LayoutTests/animations/play-state-expected.txt

    r53303 r53492  
    1 This tests the operation of -webkit-animation-play-state. After half a second the box should stop and after one more half-second it should start again. We test it both while in motion and when stopped.
     1This tests the operation of -webkit-animation-play-state. After 2 second the box should stop and after one more second it should start again. We test it both while in motion and when stopped.
    22
    3 PASS - "webkitTransform" property for "box1" element at 0.25s saw something close to: 1,0,0,1,25,0
    4 PASS - "left" property for "box2" element at 0.25s saw something close to: 25
    5 PASS - "webkitTransform" property for "box1" element at 0.75s saw something close to: 1,0,0,1,50,0
    6 PASS - "left" property for "box2" element at 0.75s saw something close to: 50
    7 PASS - "webkitTransform" property for "box1" element at 1.25s saw something close to: 1,0,0,1,75,0
    8 PASS - "left" property for "box2" element at 1.25s saw something close to: 75
     3PASS - "webkitTransform" property for "box1" element at 0.5s saw something close to: 1,0,0,1,25,0
     4PASS - "left" property for "box2" element at 0.5s saw something close to: 25
     5PASS - "webkitTransform" property for "box1" element at 1.5s saw something close to: 1,0,0,1,50,0
     6PASS - "left" property for "box2" element at 1.5s saw something close to: 50
     7PASS - "webkitTransform" property for "box1" element at 2.5s saw something close to: 1,0,0,1,75,0
     8PASS - "left" property for "box2" element at 2.5s saw something close to: 75
    99
  • trunk/LayoutTests/animations/play-state.html

    r53303 r53492  
    1010      background-color: blue;
    1111      margin: 0;
    12       -webkit-animation-duration: 1s;
     12      -webkit-animation-duration: 2s;
    1313      -webkit-animation-timing-function: linear;
    1414      -webkit-animation-name: "move1";
     
    2525      width: 100px;
    2626      background-color: red;
    27       -webkit-animation-duration: 1s;
     27      -webkit-animation-duration: 2s;
    2828      -webkit-animation-timing-function: linear;
    2929      -webkit-animation-name: "move2";
     
    3939    const expectedValues = [
    4040      // [animation-name, time, element-id, property, expected-value, tolerance]
    41       ["move1", 0.25, "box1", "webkitTransform", [1,0,0,1,25,0], 10],
    42       ["move1", 0.75, "box1", "webkitTransform", [1,0,0,1,50,0], 10],
    43       ["move1", 1.25, "box1", "webkitTransform", [1,0,0,1,75,0], 10],
    44       ["move2", 0.25, "box2", "left", 25, 10],
    45       ["move3", 0.75, "box2", "left", 50, 10],
    46       ["move4", 1.25, "box2", "left", 75, 10],
     41      ["move1", 0.5, "box1", "webkitTransform", [1,0,0,1,25,0], 15],
     42      ["move1", 1.5, "box1", "webkitTransform", [1,0,0,1,50,0], 15],
     43      ["move1", 2.5, "box1", "webkitTransform", [1,0,0,1,75,0], 15],
     44      ["move2", 0.5, "box2", "left", 25, 15],
     45      ["move3", 1.5, "box2", "left", 50, 15],
     46      ["move4", 2.5, "box2", "left", 75, 15],
    4747    ];
    4848   
     
    6161    function setTimers()
    6262    {
    63         setTimeout(stop, 500);
    64         setTimeout(start, 1000);
     63        setTimeout(stop, 1000);
     64        setTimeout(start, 2000);
    6565    }
    6666   
     
    7171<body>
    7272<p>
    73 This tests the operation of -webkit-animation-play-state. After half a second the box should stop and after one
    74 more half-second it should start again. We test it both while in motion and when stopped.
     73This tests the operation of -webkit-animation-play-state. After 2 second the box should stop and after one
     74more second it should start again. We test it both while in motion and when stopped.
    7575<div id="box1">
    7676</div>
  • trunk/LayoutTests/transitions/cancel-transition.html

    r53310 r53492  
    6363        {
    6464            document.getElementById("container").className = "run";
     65            // The transition should restart at the beginning here. After 250 it should be halfway done.
     66            setTimeout("check()", 250);
    6567        }
    6668
     
    9496            setTimeout("cancelTransition()", 100);
    9597            setTimeout("restartTransition()", 200);
    96             setTimeout("check()", 500);
    9798        }
    9899    </script>
Note: See TracChangeset for help on using the changeset viewer.