Changeset 53588 in webkit
- Timestamp:
- Jan 20, 2010 6:08:21 PM (14 years ago)
- Location:
- trunk/WebCore
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebCore/ChangeLog
r53587 r53588 1 2010-01-20 Ilya Tikhonovsky <loislo@chromium.org> 2 3 Reviewed by Pavel Feldman. 4 5 Timeline reset button doesn't clean timeline if the panel is scrolled down. 6 The overview pane also stay dirty after reset. 7 https://bugs.webkit.org/show_bug.cgi?id=33829 8 9 * inspector/front-end/TimelineGrid.js: 10 (WebInspector.TimelineGrid.prototype.updateDividers): 11 * inspector/front-end/TimelineOverviewPane.js: 12 (WebInspector.TimelineOverviewPane.prototype.reset): 13 * inspector/front-end/TimelinePanel.js: 14 (WebInspector.TimelinePanel.prototype.reset): 15 (WebInspector.TimelinePanel.prototype._refreshRecords): 16 1 17 2010-01-20 Alexey Proskuryakov <ap@apple.com> 2 18 -
trunk/WebCore/inspector/front-end/TimelineGrid.js
r53167 r53588 101 101 if (!isNaN(slice)) 102 102 dividerLabelBar._labelElement.textContent = calculator.formatValue(slice * i); 103 else 104 dividerLabelBar._labelElement.textContent = ""; 103 105 104 106 divider = divider.nextSibling; -
trunk/WebCore/inspector/front-end/TimelineOverviewPane.js
r51339 r53588 174 174 reset: function() 175 175 { 176 this.windowLeft = 0.0; 177 this.windowRight = 1.0; 178 this._setWindowPosition(0, this._overviewGrid.element.clientWidth); 176 179 this._overviewCalculator.reset(); 177 180 this._overviewGrid.updateDividers(true, this._overviewCalculator); 178 this.windowLeft = 0.0;179 this.windowRight = 1.0;180 181 }, 181 182 -
trunk/WebCore/inspector/front-end/TimelinePanel.js
r53413 r53588 272 272 this._lastRecord = null; 273 273 this._sendRequestRecords = {}; 274 this._records = []; 275 this._boundariesAreValid = false; 274 276 this._overviewPane.reset(); 275 this._ records = [];277 this._adjustScrollPosition(0); 276 278 this._refresh(); 277 279 }, … … 297 299 this._scheduleRefresh(); 298 300 }, 299 301 300 302 _scheduleRefresh: function(preserveBoundaries) 301 303 { … … 357 359 358 360 // Convert visible area to visible indexes. Always include top-level record for a visible nested record. 359 var startIndex = Math.max(0, Math. floor(visibleTop / rowHeight) - 1);361 var startIndex = Math.max(0, Math.min(Math.floor(visibleTop / rowHeight) - 1, recordsInWindow.length - 1)); 360 362 while (startIndex > 0 && recordsInWindow[startIndex].parent) 361 363 startIndex--; 362 364 var endIndex = Math.min(recordsInWindow.length, Math.ceil(visibleBottom / rowHeight)); 363 while (endIndex < recordsInWindow.length - 1 && recordsInWindow[ startIndex].parent)365 while (endIndex < recordsInWindow.length - 1 && recordsInWindow[endIndex].parent) 364 366 endIndex++; 365 367
Note: See TracChangeset
for help on using the changeset viewer.