Changeset 53678 in webkit

Timestamp:

Jan 21, 2010 10:21:55 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-21 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Fisher.

Bumps the refcount when WebNode::toElement/toConstElement are called.
​https://bugs.webkit.org/show_bug.cgi?id=33977

Ensures that when a wrapper around a WebNode is create via the
toElement() or toConstElement() calls that the refcount on the WebNode
is increased, by forcing a call to WebNode::assign(). This is needed
so that the following code:
{

WebNode n = someNode();
WebElement e = n.toElement<WebElement>();

}
does not decrease the overall refcount on the Node that someNode()
returns.

This caused crashes in the 'Save page as..' feature.

• public/WebNode.h: (WebKit::WebNode::toElement): (WebKit::WebNode::toConstElement):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/WebNode.h (modified) (2 diffs)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-01-21  James Robinson  <jamesr@chromium.org>
+
+        Reviewed by Darin Fisher.
+
+        Bumps the refcount when WebNode::toElement/toConstElement are called.
+        https://bugs.webkit.org/show_bug.cgi?id=33977
+        
+        Ensures that when a wrapper around a WebNode is create via the
+        toElement() or toConstElement() calls that the refcount on the WebNode
+        is increased, by forcing a call to WebNode::assign().  This is needed
+        so that the following code:
+        {
+          WebNode n = someNode();
+          WebElement e = n.toElement<WebElement>();
+        }
+        does not decrease the overall refcount on the Node that someNode()
+        returns.
+
+        This caused crashes in the 'Save page as..' feature.
+
+        * public/WebNode.h:
+        (WebKit::WebNode::toElement):
+        (WebKit::WebNode::toConstElement):
+
 2010-01-21  Michael Nordman  <michaeln@google.com>
 

trunk/WebKit/chromium/public/WebNode.h

@@ -105 +105 @@
     {
         T res;
-        res.m_private = m_private;
+        res.WebNode::assign(*this);
         return res;
     }
@@ -112 +112 @@
     {
         T res;
-        res.m_private = m_private;
+        res.WebNode::assign(*this);
         return res;
     }