Changeset 53782 in webkit

Timestamp:

Jan 24, 2010 1:05:10 PM (14 years ago)

Author:

Chris Jerdonek

Message:

Added to contributing code page a pointer to the preferred
license text. Also added information about copyright lines.

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=34017

• coding/contributing.html:
• css/main.css:
  • Added CSS class for books.

Location:

trunk/WebKitSite

Files:

• ChangeLog (modified) (1 diff)
• coding/contributing.html (modified) (4 diffs)
• css/main.css (modified) (1 diff)

trunk/WebKitSite/ChangeLog

@@ +1 @@
+2010-01-24  Chris Jerdonek  <cjerdonek@webkit.org>
+
+        Reviewed by David Kilzer.
+
+        Added to contributing code page a pointer to the preferred
+        license text. Also added information about copyright lines.
+
+        https://bugs.webkit.org/show_bug.cgi?id=34017
+
+        * coding/contributing.html:
+        * css/main.css:
+          - Added CSS class for books.
+
 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
 

trunk/WebKitSite/coding/contributing.html

@@ -28 +28 @@
 <ol>
     <li>Choose or create a <a href="#bugreport">bug report</a> to work on.</li>
-    <li>Complete your changes.</li>
+    <li><a href="#writecode">Develop</a> your changes.</li>
     <li>Make sure your changes meet the <a href="/coding/coding-style.html">code
         style guidelines</a>. The <tt>check-webkit-style</tt> script may be of
@@ -34 +34 @@
     <li>Run the layout tests using the <tt>run-webkit-tests</tt> script and make sure they all pass.
         See the <a href="/quality/testwriting.html">testing page</a> for more information, as well as what you need to do if you've modified JavaScriptCore.</li>
-    <li>Add any new files and layout tests to Subversion using the <tt>svn add</tt> command.</li>
+    <li>Add any <a href="#newfiles">new files</a> to your working directory.</li>
     <li>Prepare a change log entry. You may have to add entries to multiple ChangeLogs. The <tt>prepare-ChangeLog</tt> script will create stub entries for you.  See the <a href="#changelogs">paragraph about ChangeLogs</a> below.</li>
     <li>Create the patch using the <tt>svn-create-patch</tt> script.</li>
@@ -66 +66 @@
 webkit-dev</a> mailing list.</p>
 
+<h3 id="writecode">Develop your changes</h3>
+
+<p>If you make substantive changes to a file, you may wish to add a
+copyright line for yourself or for the company on whose behalf you
+work. Below are sample copyright lines for an individual contributor
+and a company:
+
+<p><tt>Copyright (C) 2010 John Smith (jsmith@example.com)</tt></p>
+<p><tt>Copyright (C) 2010 Company Inc. All rights reserved.</tt></p>
+
+<p>In addition, make sure that any new source code and script files
+you introduce contain license text at the beginning of the file.
+If you are the author of a new file, preferred license text to include
+can be found here:
+<a href="http://trac.webkit.org/browser/trunk/WebKit/LICENSE">WebKit/LICENSE</a>.
+(The "Original Format" link at the bottom of the page contains text
+that can be cut and pasted more easily.) Simply replace the copyright
+line with your own information, for example as suggested above.
+
 <h3>Code Style Guidelines</h3>
 <p>Patches must comply with the <a href="/coding/coding-style.html">code style guidelines</a>.
@@ -86 +105 @@
 can be found on the <a href="/quality/testwriting.html">testing page</a>.</p>
 
-<h3>Adding new files</h3>
-<p>New files and layout tests must be added to Subversion or else they won't be included in your patch. This is done with the <tt>svn add</tt> command.
-More information on Subversion commands can be found via <tt>svn help</tt> or the <a href="http://svnbook.red-bean.com/">Version Control with Subversion</a> online book.</p>
+<h3 id="newfiles">Add new files to your working directory</h3>
+<p>If your changes include adding new files (like new layout tests),
+use the <tt>svn add</tt> command to mark these files for addition to the
+repository. If you do not do this, the new files will be missing from
+the patch file you generate below.</p>
+
+<p>You can learn more about Subversion commands like <tt>svn add</tt>
+from the online book <a class="book" href="http://svnbook.red-bean.com/">
+Version Control with Subversion</a> and by using the <tt>svn help</tt>
+command.</p>
 
 <h3 id="changelogs">ChangeLog files</h3>

trunk/WebKitSite/css/main.css

@@ -184 +184 @@
 }
 
+.book {
+    font-style: italic;
+}
+
 .code, pre, tt, code {
     font-family: Courier, Fixed;