Changeset 53897 in webkit


Ignore:
Timestamp:
Jan 26, 2010, 9:29:08 PM (16 years ago)
Author:
dbates@webkit.org
Message:

2010-01-26 Daniel Bates <​dbates@webkit.org>

Reviewed by Tor Arne Vestbø.

​https://bugs.webkit.org/show_bug.cgi?id=29564

[Qt] Fixes an issue where the height of <button>- and
<input type="button">- elements are fixed to the height of the
button label font plus padding. That is, the CSS height property
is being ignored.

Instead, we should honor the user-specified height, if appropriate
for the platform and context. Notice, the Mac ports do not honor the
height for <input type="button"> elements unless a border and/or
background is also specified.

Test: fast/css/button-height.html

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustButtonStyle):

2010-01-26 Daniel Bates <​dbates@webkit.org>

Reviewed by Tor Arne Vestbø.

​https://bugs.webkit.org/show_bug.cgi?id=29564

Tests that the user-specified height for <button>- and <input type="button">-
elements are honored, if appropriate for the platform and context.

  • fast/css/button-height-expected.txt: Added.
  • fast/css/button-height.html: Added.
  • fast/replaced/table-percent-height-expected.txt: Added notice about failing tests in Windows ports.
  • fast/replaced/table-percent-height.html: Ditto.
  • platform/qt/fast/replaced/table-percent-height-expected.txt: Added.
Location:
trunk
Files:
3 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r53895 r53897  
     12010-01-26  Daniel Bates  <dbates@webkit.org>
     2
     3        Reviewed by Tor Arne Vestbø.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=29564
     6
     7        Tests that the user-specified height for <button>- and <input type="button">-
     8        elements are honored, if appropriate for the platform and context.
     9
     10        * fast/css/button-height-expected.txt: Added.
     11        * fast/css/button-height.html: Added.
     12        * fast/replaced/table-percent-height-expected.txt: Added notice about failing tests
     13        in Windows ports.
     14        * fast/replaced/table-percent-height.html: Ditto.
     15        * platform/qt/fast/replaced/table-percent-height-expected.txt: Added.
     16
    1172010-01-26  Diego Gonzalez  <diego.gonzalez@openbossa.org>
    218

  • trunk/LayoutTests/fast/replaced/table-percent-height-expected.txt

    r51852 r53897  
    2424
    2525This test checks that replaced elements with percentage heights within table cells have the correct height.
     26Note, some of the button height tests fail on the Windows ports. See bug #34071.
    2627
    2728On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

  • trunk/LayoutTests/fast/replaced/table-percent-height.html

    r51852 r53897  
    6060function test()
    6161{
    62     description("This test checks that replaced elements with percentage heights within table cells have the correct height.");
     62    description("This test checks that replaced elements with percentage heights within table cells have the correct height.<br>Note, some of the button height tests fail on the Windows ports. See bug #34071.");
    6363
    6464    shouldBe("getWidth('canvas-75')", "'300px'");

  • trunk/WebCore/ChangeLog

    r53894 r53897  
     12010-01-26  Daniel Bates  <dbates@webkit.org>
     2
     3        Reviewed by Tor Arne Vestbø.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=29564
     6
     7        [Qt] Fixes an issue where the height of <button>- and
     8        <input type="button">- elements are fixed to the height of the
     9        button label font plus padding. That is, the CSS height property
     10        is being ignored.
     11
     12        Instead, we should honor the user-specified height, if appropriate
     13        for the platform and context. Notice, the Mac ports do not honor the
     14        height for <input type="button"> elements unless a border and/or
     15        background is also specified.
     16
     17        Test: fast/css/button-height.html
     18
     19        * platform/qt/RenderThemeQt.cpp:
     20        (WebCore::RenderThemeQt::adjustButtonStyle):
     21
    1222010-01-26  Alexander Pavlov  <apavlov@chromium.org>
    223

  • trunk/WebCore/platform/qt/RenderThemeQt.cpp

    r53803 r53897  
    396396    style->resetBorder();
    397397
    398     // Height is locked to auto.
    399     style->setHeight(Length(Auto));
     398#ifdef Q_WS_MAC
     399    if (style->appearance() == PushButtonPart) {
     400        // The Mac ports ignore the specified height for <input type="button"> elements
     401        // unless a border and/or background CSS property is also specified.
     402        style->setHeight(Length(Auto));
     403    }
     404#endif
    400405
    401406    // White-space is locked to pre
Note: See TracChangeset for help on using the changeset viewer.