Changeset 53995 in webkit

Timestamp:

Jan 28, 2010 3:54:12 AM (14 years ago)

Author:

zecke@webkit.org

Message:

[Qt] Speed up KURL to QUrl conversion

​https://bugs.webkit.org/show_bug.cgi?id=33873

The WebCore::String::utf8 method will use the generic WebCore::TextCodec
and then call the encode method on it. In QtWebKit this class is implemented
around the QTextCodec class. Instead of going the generic codec way we treat
the WebCore::String as a QString (no copying) and then use the built-in
QString::toUtf8 to do the conversion.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/qt/KURLQt.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-01-18  Holger Hans Peter Freyther  <zecke@selfish.org>
+
+        Reviewed by Eric Seidel.
+
+        [Qt] Speed up KURL to QUrl conversion
+        https://bugs.webkit.org/show_bug.cgi?id=33873
+
+        The WebCore::String::utf8 method will use the generic WebCore::TextCodec
+        and then call the encode method on it. In QtWebKit this class is implemented
+        around the QTextCodec class. Instead of going the generic codec way we treat
+        the WebCore::String as a QString (no copying) and then use the built-in
+        QString::toUtf8 to do the conversion.
+
+        * platform/qt/KURLQt.cpp:
+        (WebCore::KURL::operator QUrl):
+
 2010-01-28  Ben Murdoch  <benm@google.com>
 

trunk/WebCore/platform/qt/KURLQt.cpp

@@ -87 +87 @@
     // Qt 4.5 or later
     // No need for special encoding
-    QByteArray ba = m_string.utf8().data();
+    QString str = QString::fromRawData(reinterpret_cast<const QChar*>(m_string.characters()), m_string.length());
+    QByteArray ba = str.toUtf8();
 #endif