Changeset 54179 in webkit
- Timestamp:
- Feb 1, 2010 5:00:20 PM (14 years ago)
- Location:
- trunk/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebCore/ChangeLog
r54175 r54179 1 2010-02-01 Kavita Kanetkar <kkanetkar@chromium.org> 2 3 Reviewed by Nate Chapin. 4 5 [V8] Making V8 generated classes' GetTemplate() function public 6 https://bugs.webkit.org/show_bug.cgi?id=34026 7 8 * bindings/scripts/CodeGeneratorV8.pm: Generated code need not depend on V8CustomBinding.h, made GetTemplate() signature public. 9 1 10 2010-02-01 Steve Block <steveblock@google.com> 2 11 -
trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm
r54150 r54179 963 963 } elsif ($attribute->signature->type eq "EventListener") { 964 964 $implIncludes{"V8AbstractEventListener.h"} = 1; 965 $implIncludes{"V8CustomBinding.h"} = 1;966 965 push(@implContentDecls, " transferHiddenDependency(info.Holder(), imp->$attrName(), value, V8${interfaceName}::cacheIndex);\n"); 967 966 push(@implContentDecls, " imp->set$implSetterFunctionName(V8DOMWrapper::getEventListener(imp, value, true, ListenerFindOrCreate)"); … … 1507 1506 # Generate special code for the constructor attributes. 1508 1507 if ($attrType =~ /Constructor$/) { 1509 if ($attribute->signature->extendedAttributes->{"CustomGetter"} || 1510 $attribute->signature->extendedAttributes->{"V8CustomGetter"}) { 1511 $implIncludes{"V8CustomBinding.h"} = 1; 1512 } else { 1508 if (!($attribute->signature->extendedAttributes->{"CustomGetter"} || 1509 $attribute->signature->extendedAttributes->{"V8CustomGetter"})) { 1513 1510 $hasConstructors = 1; 1514 1511 } … … 1525 1522 if ($attribute->signature->extendedAttributes->{"Custom"} || 1526 1523 $attribute->signature->extendedAttributes->{"V8Custom"}) { 1527 $implIncludes{"V8CustomBinding.h"} = 1;1528 1524 next; 1529 1525 } 1530 1526 1531 1527 # Generate the accessor. 1532 if ($attribute->signature->extendedAttributes->{"CustomGetter"} || 1533 $attribute->signature->extendedAttributes->{"V8CustomGetter"}) { 1534 $implIncludes{"V8CustomBinding.h"} = 1; 1535 } else { 1528 if (!($attribute->signature->extendedAttributes->{"CustomGetter"} || 1529 $attribute->signature->extendedAttributes->{"V8CustomGetter"})) { 1536 1530 GenerateNormalAttrGetter($attribute, $dataNode, $classIndex, $implClassName, $interfaceName); 1537 1531 } 1538 if ( $attribute->signature->extendedAttributes->{"CustomSetter"} ||1539 $attribute->signature->extendedAttributes->{"V8CustomSetter"}) {1540 $implIncludes{"V8CustomBinding.h"} = 1;1541 } elsif ($attribute->signature->extendedAttributes->{"Replaceable"}) {1542 $dataNode->extendedAttributes->{"ExtendsDOMGlobalObject"} || die "Replaceable attribute can only be used in interface that defines ExtendsDOMGlobalObject attribute!";1543 # GenerateReplaceableAttrSetter($implClassName);1544 } elsif ($attribute->type !~ /^readonly/ && !$attribute->signature->extendedAttributes->{"V8ReadOnly"}) {1545 GenerateNormalAttrSetter($attribute, $dataNode, $classIndex, $implClassName, $interfaceName);1532 if (!($attribute->signature->extendedAttributes->{"CustomSetter"} || 1533 $attribute->signature->extendedAttributes->{"V8CustomSetter"})) { 1534 if ($attribute->signature->extendedAttributes->{"Replaceable"}) { 1535 $dataNode->extendedAttributes->{"ExtendsDOMGlobalObject"} || die "Replaceable attribute can only be used in interface that defines ExtendsDOMGlobalObject attribute!"; 1536 # GenerateReplaceableAttrSetter($implClassName); 1537 } elsif ($attribute->type !~ /^readonly/ && !$attribute->signature->extendedAttributes->{"V8ReadOnly"}) { 1538 GenerateNormalAttrSetter($attribute, $dataNode, $classIndex, $implClassName, $interfaceName); 1539 } 1546 1540 } 1547 1541 } … … 1557 1551 # hack for addEventListener/RemoveEventListener 1558 1552 # FIXME: avoid naming conflict 1559 if ($function->signature->extendedAttributes->{"Custom"} || $function->signature->extendedAttributes->{"V8Custom"}) { 1560 $implIncludes{"V8CustomBinding.h"} = 1; 1561 } else { 1553 if (!($function->signature->extendedAttributes->{"Custom"} || $function->signature->extendedAttributes->{"V8Custom"})) { 1562 1554 GenerateFunctionCallback($function, $dataNode, $classIndex, $implClassName); 1563 1555 }
Note: See TracChangeset
for help on using the changeset viewer.