Changeset 54222 in webkit

Timestamp:

Feb 2, 2010 3:38:21 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-02-02 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable a way to measure FPS in QGVLauncher
run QGVLauncher with --show-fps to see ongoing fps measurements
This is not meant as accurate FPS, but rather as a way to find
improvements/regressions
​https://bugs.webkit.org/show_bug.cgi?id=34450

• QGVLauncher/main.cpp: (MainView::MainView): initialize FPS values (MainView::paintEvent): count a painted frame here (MainView::printFps): we print the fps with qDebug every 5 seconds.

Location:

trunk/WebKit/qt

Files:

• ChangeLog (modified) (1 diff)
• QGVLauncher/main.cpp (modified) (5 diffs)

trunk/WebKit/qt/ChangeLog

@@ +1 @@
+2010-02-02  Noam Rosenthal  <noam.rosenthal@nokia.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [Qt] Enable a way to measure FPS in QGVLauncher
+        run QGVLauncher with --show-fps to see ongoing fps measurements
+        This is not meant as accurate FPS, but rather as a way to find
+        improvements/regressions
+        https://bugs.webkit.org/show_bug.cgi?id=34450
+
+        * QGVLauncher/main.cpp:
+        (MainView::MainView): initialize FPS values
+        (MainView::paintEvent): count a painted frame here
+        (MainView::printFps): we print the fps with qDebug every 5 seconds.
+
 2010-01-29  Ben Murdoch  <benm@google.com>
 

trunk/WebKit/qt/QGVLauncher/main.cpp

@@ -126 +126 @@
         : QGraphicsView(parent)
         , m_mainWidget(0)
+        , m_measureFps(QApplication::instance()->arguments().contains("--show-fps"))
+        , m_numTotalPaints(0)
+        , m_numPaintsSinceLastMeasure(0)
     {
         setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
@@ -132 +135 @@
         setFrameShape(QFrame::NoFrame);
         setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Expanding);
+        if (m_measureFps) {
+            QTimer* fpsTimer = new QTimer(this);
+            fpsTimer->setInterval(5000);
+            m_totalStartTime = m_startTime = QTime::currentTime();
+            connect(fpsTimer, SIGNAL(timeout()), this, SLOT(printFps()));
+            fpsTimer->start();
+        }
     }
 
@@ -150 +160 @@
     }
 
+    void paintEvent(QPaintEvent* event)
+    {
+        QGraphicsView::paintEvent(event);
+        if (m_measureFps) {
+            ++m_numPaintsSinceLastMeasure;
+            ++m_numTotalPaints;            
+        }
+    }
+
     void setWaitCursor()
     {
@@ -196 +215 @@
     }
 
+    void printFps()
+    {
+        // note that this might have a bug if you measure right around midnight, but we can live with that
+        QTime now = QTime::currentTime();
+        int msecs = m_startTime.msecsTo(now);
+        int totalMsecs = m_totalStartTime.msecsTo(now);
+        int totalFps = totalMsecs ? m_numTotalPaints * 1000 / totalMsecs : 0;
+        int curFps = msecs ? m_numPaintsSinceLastMeasure * 1000 / msecs : 0;
+        qDebug("[FPS] From start: %d, from last paint: %d", totalFps, curFps);
+        m_startTime = now;
+        m_numPaintsSinceLastMeasure = 0;
+    }
+
 signals:
     void flipRequest();
@@ -201 +233 @@
 private:
     QGraphicsWidget* m_mainWidget;
+    bool m_measureFps;
+    int m_numTotalPaints;
+    int m_numPaintsSinceLastMeasure;
+    QTime m_startTime;
+    QTime m_totalStartTime;
 };