Changeset 54347 in webkit

Timestamp:

Feb 4, 2010 9:43:17 AM (14 years ago)

Author:

ariya@webkit.org

Message:

2010-02-04 Ariya Hidayat <​ariya.hidayat@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Unnecessary QBrush construction for doing a solid fill
​https://bugs.webkit.org/show_bug.cgi?id=34559

Use the similar trick like r37421, i.e. use the special brush for
solid color to avoid creating QBrush again and again.

• platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setPlatformFillColor):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/qt/GraphicsContextQt.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-02-04  Ariya Hidayat  <ariya.hidayat@gmail.com>
+
+        Reviewed by Simon Hausmann.
+
+        [Qt] Unnecessary QBrush construction for doing a solid fill
+        https://bugs.webkit.org/show_bug.cgi?id=34559
+
+        Use the similar trick like r37421, i.e. use the special brush for
+        solid color to avoid creating QBrush again and again.
+
+        * platform/graphics/qt/GraphicsContextQt.cpp:
+        (WebCore::GraphicsContext::setPlatformFillColor):
+
 2010-02-04  Dan Bernstein  <mitz@apple.com>
 

trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

@@ -1271 +1271 @@
     if (paintingDisabled())
         return;
-    m_data->p()->setBrush(QBrush(color));
+    m_data->solidColor.setColor(color);
+    m_data->p()->setBrush(m_data->solidColor);
 }