Changeset 54351 in webkit

Timestamp:

Feb 4, 2010 10:06:08 AM (14 years ago)

Author:

pfeldman@chromium.org

Message:

2010-02-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: group cookies by domains, not frame's domains.

​https://bugs.webkit.org/show_bug.cgi?id=34599

• inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._cookiesForDomain):
• inspector/front-end/inspector.js: (WebInspector.updateResource): (WebInspector._addCookieDomain):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/CookieItemsView.js (modified) (1 diff)
• inspector/front-end/inspector.js (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-02-04  Pavel Feldman  <pfeldman@chromium.org>
+
+        Reviewed by Timothy Hatcher.
+
+        Web Inspector: group cookies by domains, not frame's domains.
+
+        https://bugs.webkit.org/show_bug.cgi?id=34599
+
+        * inspector/front-end/CookieItemsView.js:
+        (WebInspector.CookieItemsView.prototype._cookiesForDomain):
+        * inspector/front-end/inspector.js:
+        (WebInspector.updateResource):
+        (WebInspector._addCookieDomain):
+
 2010-02-04  Nate Chapin  <japhet@chromium.org>
 

trunk/WebCore/inspector/front-end/CookieItemsView.js

@@ -97 +97 @@
         for (var id in WebInspector.resources) {
             var resource = WebInspector.resources[id];
-            var match = resource.documentURL.match(WebInspector.URLRegExp);
+            var match = resource.url.match(WebInspector.URLRegExp);
             if (match && match[2] === this._cookieDomain)
                 resourceURLsForDocumentURL.push(resource.url);

trunk/WebCore/inspector/front-end/inspector.js

@@ -1047 +1047 @@
             this.mainResource = resource;
 
-        var match = payload.documentURL.match(WebInspector.URLRegExp);
-        if (match) {
-            var protocol = match[1].toLowerCase();
-            if (protocol.indexOf("http") === 0 || protocol === "file")
-                this.addCookieDomain(protocol === "file" ? "" : match[2]);
-        }
+        this._addCookieDomain(resource.domain);
     }
 
@@ -1132 +1127 @@
 }
 
-WebInspector.addCookieDomain = function(domain)
+WebInspector._addCookieDomain = function(domain)
 {
     // Eliminate duplicate domains from the list.