Changeset 54543 in webkit

Timestamp:

Feb 9, 2010, 2:40:22 AM (16 years ago)

Author:

eric@webkit.org

Message:

2010-02-09 Chang Shu <​Chang.Shu@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Enable http/tests/appcache but skip the failed cases.
​https://bugs.webkit.org/show_bug.cgi?id=34713

• platform/qt/Skipped:

2010-02-09 Chang Shu <​Chang.Shu@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Enable appcache feature.
​https://bugs.webkit.org/show_bug.cgi?id=34713

• DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage):
• DumpRenderTree/qt/main.cpp: (main):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/qt/Skipped (modified) (2 diffs)
• WebKitTools/ChangeLog (modified) (1 diff)
• WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp (modified) (1 diff)
• WebKitTools/DumpRenderTree/qt/main.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-02-09  Chang Shu  <Chang.Shu@nokia.com>
+
+        Reviewed by Laszlo Gombos.
+
+        [Qt] Enable http/tests/appcache but skip the failed cases.
+        https://bugs.webkit.org/show_bug.cgi?id=34713
+
+        * platform/qt/Skipped:
+
 2010-02-09  Eric Seidel  <eric@webkit.org>
 

trunk/LayoutTests/platform/qt/Skipped

@@ -16 +16 @@
 
 # Disabled HTTP subdirs for now, needs investigation.
-http/tests/appcache
 http/tests/webarchive
 http/tests/globalhistory
@@ -23 +22 @@
 http/tests/webarchive
 http/tests/wml
+
+# Skip failed appcache test cases
+http/tests/appcache/auth.html
+http/tests/appcache/empty-manifest.html
+http/tests/appcache/fallback.html
+http/tests/appcache/foreign-iframe-main.html
+http/tests/appcache/manifest-redirect-2.html
+http/tests/appcache/manifest-with-empty-file.html
+http/tests/appcache/max-size.html
+http/tests/appcache/offline-access.html
+http/tests/appcache/resource-redirect-2.html
+http/tests/appcache/resource-redirect.html
 
 # Failing URL test

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-02-09  Chang Shu  <Chang.Shu@nokia.com>
+
+        Reviewed by Laszlo Gombos.
+
+        [Qt] Enable appcache feature.
+        https://bugs.webkit.org/show_bug.cgi?id=34713
+
+
+        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
+        (WebCore::WebPage::WebPage):
+        * DumpRenderTree/qt/main.cpp:
+        (main):
+
 2010-02-09  Shinichiro Hamaji  <hamaji@chromium.org>
 

trunk/WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp

@@ -136 +136 @@
     globalSettings->setAttribute(QWebSettings::JavascriptEnabled, true);
     globalSettings->setAttribute(QWebSettings::PrivateBrowsingEnabled, false);
-    globalSettings->setAttribute(QWebSettings::OfflineWebApplicationCacheEnabled, false);
+    globalSettings->setAttribute(QWebSettings::OfflineWebApplicationCacheEnabled, true);
 
     connect(this, SIGNAL(geometryChangeRequested(const QRect &)),

trunk/WebKitTools/DumpRenderTree/qt/main.cpp

@@ -164 +164 @@
     QString dbDir = QDesktopServices::storageLocation(QDesktopServices::DataLocation) + QDir::separator() + "qtwebkitdrt";
     QWebSettings::setOfflineStoragePath(dbDir);
+    QWebSettings::setOfflineWebApplicationCachePath(dbDir);
     QWebDatabase::removeAllDatabases();