Changeset 54580 in webkit


Ignore:
Timestamp:
Feb 9, 2010 6:53:05 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-02-09 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

New functions nullValue() and undefinedValue().

[Qt] QScriptEngine should contain nullValue and undefinedValue methods
​https://bugs.webkit.org/show_bug.cgi?id=34749

  • qt/api/qscriptengine.cpp: (QScriptEngine::nullValue): (QScriptEngine::undefinedValue):
  • qt/api/qscriptengine.h:
  • qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::nullValue): (tst_QScriptEngine::undefinedValue):
Location:
trunk/JavaScriptCore
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/JavaScriptCore/ChangeLog

    r54579 r54580  
     12010-02-09  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
     2
     3        Reviewed by Simon Hausmann.
     4
     5        New functions nullValue() and undefinedValue().
     6
     7        [Qt] QScriptEngine should contain nullValue and undefinedValue methods
     8        https://bugs.webkit.org/show_bug.cgi?id=34749
     9
     10        * qt/api/qscriptengine.cpp:
     11        (QScriptEngine::nullValue):
     12        (QScriptEngine::undefinedValue):
     13        * qt/api/qscriptengine.h:
     14        * qt/tests/qscriptengine/tst_qscriptengine.cpp:
     15        (tst_QScriptEngine::nullValue):
     16        (tst_QScriptEngine::undefinedValue):
     17
    1182010-02-09  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
    219

  • trunk/JavaScriptCore/qt/api/qscriptengine.cpp

    r53850 r54580  
    8787    d_ptr->collectGarbage();
    8888}
     89
     90/*!
     91  Returns a QScriptValue of the primitive type Null.
     92
     93  \sa undefinedValue()
     94*/
     95QScriptValue QScriptEngine::nullValue()
     96{
     97    return QScriptValue(this, QScriptValue::NullValue);
     98}
     99
     100/*!
     101  Returns a QScriptValue of the primitive type Undefined.
     102
     103  \sa nullValue()
     104*/
     105QScriptValue QScriptEngine::undefinedValue()
     106{
     107    return QScriptValue(this, QScriptValue::UndefinedValue);
     108}

  • trunk/JavaScriptCore/qt/api/qscriptengine.h

    r53850 r54580  
    3939    void collectGarbage();
    4040
     41    QScriptValue nullValue();
     42    QScriptValue undefinedValue();
    4143private:
    4244    friend class QScriptEnginePrivate;

  • trunk/JavaScriptCore/qt/tests/qscriptengine/tst_qscriptengine.cpp

    r53850 r54580  
    3636    void evaluate();
    3737    void collectGarbage();
     38    void nullValue();
     39    void undefinedValue();
    3840};
    3941
    … …  
    5557    QCOMPARE(foo.call().toString(), QString::fromAscii("pong"));
    5658}
     59
     60void tst_QScriptEngine::nullValue()
     61{
     62    QScriptEngine engine;
     63    QScriptValue value = engine.nullValue();
     64    QVERIFY(value.isValid());
     65    QVERIFY(value.isNull());
     66}
     67
     68void tst_QScriptEngine::undefinedValue()
     69{
     70    QScriptEngine engine;
     71    QScriptValue value = engine.undefinedValue();
     72    QVERIFY(value.isValid());
     73    QVERIFY(value.isUndefined());
     74}
     75
    5776QTEST_MAIN(tst_QScriptEngine)
    5877#include "tst_qscriptengine.moc"
Note: See TracChangeset for help on using the changeset viewer.