Changeset 54644 in webkit

Timestamp:

Feb 10, 2010 11:14:33 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-02-10 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] GraphicsLayer: somtimes the item flickers at the end of an animation
This is because we try to delete the animation when finished: that is
unnecessary. WebCore manages the animation's lifecycle and makes sure
to call the right function when the animation can be deleted.

​https://bugs.webkit.org/show_bug.cgi?id=34761

No new tests.

• platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQt::addAnimation): No need to delete here (WebCore::GraphicsLayerQt::removeAnimationsForProperty): deleteLater

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/qt/GraphicsLayerQt.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-02-10  Noam Rosenthal  <noam.rosenthal@nokia.com>
+
+        Reviewed by Ariya Hidayat.
+
+        [Qt] GraphicsLayer: somtimes the item flickers at the end of an animation
+        This is because we try to delete the animation when finished: that is
+        unnecessary. WebCore manages the animation's lifecycle and makes sure
+        to call the right function when the animation can be deleted.
+
+        https://bugs.webkit.org/show_bug.cgi?id=34761
+
+        No new tests.
+
+        * platform/graphics/qt/GraphicsLayerQt.cpp:
+        (WebCore::GraphicsLayerQt::addAnimation): No need to delete here
+        (WebCore::GraphicsLayerQt::removeAnimationsForProperty): deleteLater
+
 2010-02-10  Kevin Ollivier  <kevino@theolliviers.com>
 

trunk/WebCore/platform/graphics/qt/GraphicsLayerQt.cpp

@@ -1118 +1118 @@
         newAnim->start();
 
-    QObject::connect(newAnim, SIGNAL(finished()), newAnim, SLOT(deleteLater()));
+    // we don't need to manage the animation object's lifecycle:
+    // WebCore would call removeAnimations when it's time to delete.
 
     return true;
@@ -1129 +1130 @@
             AnimationQtBase* anim = static_cast<AnimationQtBase*>(it->data());
             if (anim && anim->m_webkitPropertyID == id) {
-                delete anim;
+                anim->deleteLater();
                 it = m_impl->m_animations.erase(it);
                 --it;