Changeset 54644 in webkit
- Timestamp:
- Feb 10, 2010 11:14:33 PM (14 years ago)
- Location:
- trunk/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebCore/ChangeLog
r54643 r54644 1 2010-02-10 Noam Rosenthal <noam.rosenthal@nokia.com> 2 3 Reviewed by Ariya Hidayat. 4 5 [Qt] GraphicsLayer: somtimes the item flickers at the end of an animation 6 This is because we try to delete the animation when finished: that is 7 unnecessary. WebCore manages the animation's lifecycle and makes sure 8 to call the right function when the animation can be deleted. 9 10 https://bugs.webkit.org/show_bug.cgi?id=34761 11 12 No new tests. 13 14 * platform/graphics/qt/GraphicsLayerQt.cpp: 15 (WebCore::GraphicsLayerQt::addAnimation): No need to delete here 16 (WebCore::GraphicsLayerQt::removeAnimationsForProperty): deleteLater 17 1 18 2010-02-10 Kevin Ollivier <kevino@theolliviers.com> 2 19 -
trunk/WebCore/platform/graphics/qt/GraphicsLayerQt.cpp
r54541 r54644 1118 1118 newAnim->start(); 1119 1119 1120 QObject::connect(newAnim, SIGNAL(finished()), newAnim, SLOT(deleteLater())); 1120 // we don't need to manage the animation object's lifecycle: 1121 // WebCore would call removeAnimations when it's time to delete. 1121 1122 1122 1123 return true; … … 1129 1130 AnimationQtBase* anim = static_cast<AnimationQtBase*>(it->data()); 1130 1131 if (anim && anim->m_webkitPropertyID == id) { 1131 delete anim;1132 anim->deleteLater(); 1132 1133 it = m_impl->m_animations.erase(it); 1133 1134 --it;
Note: See TracChangeset
for help on using the changeset viewer.