Changeset 54683 in webkit
- Timestamp:
- Feb 11, 2010 3:38:05 PM (14 years ago)
- Location:
- trunk/WebKitTools
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKitTools/ChangeLog
r54669 r54683 1 2010-02-11 Eric Seidel <eric@webkit.org> 2 3 Reviewed by Adam Barth. 4 5 run-chromium-webkit-tests fails random pixel tests on Mac 6 https://bugs.webkit.org/show_bug.cgi?id=34862 7 8 This is due to the fact that the Mac port has an 9 invalid path to the image diff tool. Currently it points 10 to image_diff even though ImageDiff would be correct. We 11 can't change it to the right path yet without causing the 12 script to hang. ImageDiff expects to be long-running and 13 be passed image data over stdin. image_diff (chromium's fork) 14 expects to be passed command line arguments. 15 This fix works around the random failures by disabling pixel 16 tests on mac and logging if the user was trying to run with pixel 17 tests enabled. 18 19 * Scripts/webkitpy/layout_tests/port/mac.py: 20 1 21 2010-02-11 Nikolas Zimmermann <nzimmermann@rim.com> 2 22 -
trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/mac.py
r54634 r54683 31 31 32 32 import fcntl 33 import logging 33 34 import os 34 35 import pdb … … 273 274 # FIXME: Using arch here masks any possible file-not-found errors from a non-existant driver executable. 274 275 cmd += ['arch', '-i386', port._path_to_driver(), '-'] 276 277 # FIXME: This is a hack around our lack of ImageDiff support for now. 275 278 if not self._port._options.no_pixel_tests: 276 cmd.append('--pixel-tests') 279 logging.warn("This port does not yet support pixel tests.") 280 self._port._options.no_pixel_tests = True 281 #cmd.append('--pixel-tests') 277 282 278 283 #if driver_options:
Note: See TracChangeset
for help on using the changeset viewer.