Changeset 54855 in webkit


Ignore:
Timestamp:
Feb 16, 2010 6:16:25 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-02-16 Yusuke Sato <​yusukes@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] OpenType font with CFF glyphs is not handled correctly on Windows XP
​https://bugs.webkit.org/show_bug.cgi?id=34735

  • fast/css/font-face-opentype.html: Added.
  • fast/css/resources/Ahem.otf: Added. Ahem font which has CFF glyphs, converted from Ahem.ttf by FontForge (​http://fontforge.sourceforge.net/).
  • platform/mac/fast/css/font-face-opentype-expected.checksum: Added.
  • platform/mac/fast/css/font-face-opentype-expected.png: Added.
  • platform/mac/fast/css/font-face-opentype-expected.txt: Added.

2010-02-16 Yusuke Sato <​yusukes@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] OpenType font with CFF glyphs is not handled correctly on Windows XP
​https://bugs.webkit.org/show_bug.cgi?id=34735

Use 0xFFFF as invalidGlyph when fontData is a OpenType font with CFF glyphs.

Test: fast/css/font-face-opentype.html

  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillBMPGlyphs):
Location:
trunk
Files:
5 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r54853 r54855  
     12010-02-16  Yusuke Sato  <yusukes@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        [Chromium] OpenType font with CFF glyphs is not handled correctly on Windows XP
     6        https://bugs.webkit.org/show_bug.cgi?id=34735
     7
     8        * fast/css/font-face-opentype.html: Added.
     9        * fast/css/resources/Ahem.otf: Added. Ahem font which has CFF glyphs, converted from Ahem.ttf by FontForge (http://fontforge.sourceforge.net/).
     10        * platform/mac/fast/css/font-face-opentype-expected.checksum: Added.
     11        * platform/mac/fast/css/font-face-opentype-expected.png: Added.
     12        * platform/mac/fast/css/font-face-opentype-expected.txt: Added.
     13
    1142010-02-16  Dumitru Daniliuc  <dumi@chromium.org>
    215

  • trunk/WebCore/ChangeLog

    r54851 r54855  
     12010-02-16  Yusuke Sato  <yusukes@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        [Chromium] OpenType font with CFF glyphs is not handled correctly on Windows XP
     6        https://bugs.webkit.org/show_bug.cgi?id=34735
     7
     8        Use 0xFFFF as invalidGlyph when fontData is a OpenType font with CFF glyphs.
     9       
     10        Test: fast/css/font-face-opentype.html
     11
     12        * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
     13        (WebCore::fillBMPGlyphs):
     14
    1152010-02-16  Darin Adler  <darin@apple.com>
    216

  • trunk/WebCore/platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp

    r45325 r54855  
    135135    bool haveGlyphs = false;
    136136    int invalidGlyph = 0xFFFF;
    137     if (!isVistaOrNewer() && !(tm.tmPitchAndFamily & TMPF_TRUETYPE))
     137    const DWORD cffTableTag = 0x20464643; // 4-byte identifier for OpenType CFF table ('CFF ').
     138    if (!isVistaOrNewer() && !(tm.tmPitchAndFamily & TMPF_TRUETYPE) && (GetFontData(dc, cffTableTag, 0, 0, 0) == GDI_ERROR))
    138139        invalidGlyph = 0x1F;
    139140
Note: See TracChangeset for help on using the changeset viewer.