Changeset 55043 in webkit
- Timestamp:
- Feb 19, 2010 7:06:28 PM (14 years ago)
- Location:
- trunk
- Files:
-
- 17 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/ChangeLog
r54960 r55043 1 2010-02-19 Maciej Stachowiak <mjs@apple.com> 2 3 Reviewed by David Levin. 4 5 Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases 6 https://bugs.webkit.org/show_bug.cgi?id=35147 7 8 * configure.ac: 9 1 10 2010-02-18 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 2 11 -
trunk/JavaScriptCore/ChangeLog
r55035 r55043 1 2010-02-19 Maciej Stachowiak <mjs@apple.com> 2 3 Reviewed by David Levin. 4 5 Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases 6 https://bugs.webkit.org/show_bug.cgi?id=35147 7 8 * Configurations/FeatureDefines.xcconfig: 9 1 10 2010-02-19 Gavin Barraclough <barraclough@apple.com> 2 11 -
trunk/JavaScriptCore/Configurations/FeatureDefines.xcconfig
r54649 r55043 58 58 ENABLE_OFFLINE_WEB_APPLICATIONS = ENABLE_OFFLINE_WEB_APPLICATIONS; 59 59 ENABLE_RUBY = ENABLE_RUBY; 60 ENABLE_SANDBOX = ENABLE_SANDBOX; 60 61 ENABLE_SHARED_WORKERS = ENABLE_SHARED_WORKERS; 61 62 ENABLE_SVG = ENABLE_SVG; … … 74 75 ENABLE_XSLT = ENABLE_XSLT; 75 76 76 FEATURE_DEFINES = $(ENABLE_3D_CANVAS) $(ENABLE_3D_RENDERING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATAGRID) $(ENABLE_DATALIST) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_RUBY) $(ENABLE_S HARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_VIDEO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WML) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT);77 FEATURE_DEFINES = $(ENABLE_3D_CANVAS) $(ENABLE_3D_RENDERING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATAGRID) $(ENABLE_DATALIST) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_RUBY) $(ENABLE_SANDBOX) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_VIDEO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WML) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT); -
trunk/WebCore/ChangeLog
r55041 r55043 1 2010-02-19 Maciej Stachowiak <mjs@apple.com> 2 3 Reviewed by David Levin. 4 5 Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases 6 https://bugs.webkit.org/show_bug.cgi?id=35147 7 8 I made ENABLE(SANDBOX) only control the sandbox attribute itself; 9 I did not ifdef the infrastructure to make sandboxing 10 switchable. This is because the likely concerns about sandboxing 11 are not stability of the infrastructure code, but rather the fact 12 that the security model exposed to authors is still evolving. 13 14 * Configurations/FeatureDefines.xcconfig: 15 * GNUmakefile.am: 16 * WebCore.pri: 17 * html/HTMLIFrameElement.cpp: 18 (WebCore::HTMLIFrameElement::parseMappedAttribute): 19 1 20 2010-02-19 Alexey Proskuryakov <ap@apple.com> 2 21 -
trunk/WebCore/Configurations/FeatureDefines.xcconfig
r54649 r55043 58 58 ENABLE_OFFLINE_WEB_APPLICATIONS = ENABLE_OFFLINE_WEB_APPLICATIONS; 59 59 ENABLE_RUBY = ENABLE_RUBY; 60 ENABLE_SANDBOX = ENABLE_SANDBOX; 60 61 ENABLE_SHARED_WORKERS = ENABLE_SHARED_WORKERS; 61 62 ENABLE_SVG = ENABLE_SVG; … … 74 75 ENABLE_XSLT = ENABLE_XSLT; 75 76 76 FEATURE_DEFINES = $(ENABLE_3D_CANVAS) $(ENABLE_3D_RENDERING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATAGRID) $(ENABLE_DATALIST) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_RUBY) $(ENABLE_S HARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_VIDEO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WML) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT);77 FEATURE_DEFINES = $(ENABLE_3D_CANVAS) $(ENABLE_3D_RENDERING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATAGRID) $(ENABLE_DATALIST) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_RUBY) $(ENABLE_SANDBOX) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_VIDEO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WML) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT); -
trunk/WebCore/GNUmakefile.am
r54991 r55043 2441 2441 2442 2442 # ---- 2443 # Sandboxed IFrame Support 2444 # ---- 2445 if ENABLE_SANDBOX 2446 2447 HTML_FEATURES += ENABLE_SANDBOX=1 2448 webcore_cppflags += -DENABLE_SANDBOX=1 2449 2450 endif # END ENABLE_SANDBOX 2451 2452 # ---- 2443 2453 # Ruby Support 2444 2454 # ---- -
trunk/WebCore/WebCore.pri
r54656 r55043 54 54 !contains(DEFINES, ENABLE_VIDEO=.): DEFINES += ENABLE_VIDEO=1 55 55 !contains(DEFINES, ENABLE_RUBY=.): DEFINES += ENABLE_RUBY=1 56 !contains(DEFINES, ENABLE_SANDBOX=.): DEFINES += ENABLE_SANDBOX=1 56 57 57 58 # SVG support -
trunk/WebCore/html/HTMLIFrameElement.cpp
r52946 r55043 68 68 } 69 69 70 #if ENABLE(SANDBOX) 70 71 static SandboxFlags parseSandboxAttribute(MappedAttribute* attribute) 71 72 { … … 101 102 return flags; 102 103 } 104 #endif 103 105 104 106 void HTMLIFrameElement::parseMappedAttribute(MappedAttribute* attr) … … 124 126 // Add a rule that nulls out our border width. 125 127 addCSSLength(attr, CSSPropertyBorderWidth, "0"); 126 } else if (attr->name() == sandboxAttr) 128 } 129 #if ENABLE(SANDBOX) 130 else if (attr->name() == sandboxAttr) 127 131 setSandboxFlags(parseSandboxAttribute(attr)); 132 #endif 128 133 else 129 134 HTMLFrameElementBase::parseMappedAttribute(attr); -
trunk/WebKit/chromium/ChangeLog
r55037 r55043 1 2010-02-19 Maciej Stachowiak <mjs@apple.com> 2 3 Reviewed by David Levin. 4 5 Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases 6 https://bugs.webkit.org/show_bug.cgi?id=35147 7 8 * features.gypi: 9 1 10 2010-02-19 James Hawkins <jhawkins@chromium.org> 2 11 -
trunk/WebKit/chromium/features.gypi
r54904 r55043 56 56 'ENABLE_ORIENTATION_EVENTS=0', 57 57 'ENABLE_RUBY=1', 58 'ENABLE_SANDBOX=1', 58 59 'ENABLE_XHTMLMP=0', 59 60 'ENABLE_XSLT=1', -
trunk/WebKit/mac/ChangeLog
r55041 r55043 1 2010-02-19 Maciej Stachowiak <mjs@apple.com> 2 3 Reviewed by David Levin. 4 5 Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases 6 https://bugs.webkit.org/show_bug.cgi?id=35147 7 8 * Configurations/FeatureDefines.xcconfig: 9 1 10 2010-02-19 Alexey Proskuryakov <ap@apple.com> 2 11 -
trunk/WebKit/mac/Configurations/FeatureDefines.xcconfig
r54649 r55043 58 58 ENABLE_OFFLINE_WEB_APPLICATIONS = ENABLE_OFFLINE_WEB_APPLICATIONS; 59 59 ENABLE_RUBY = ENABLE_RUBY; 60 ENABLE_SANDBOX = ENABLE_SANDBOX; 60 61 ENABLE_SHARED_WORKERS = ENABLE_SHARED_WORKERS; 61 62 ENABLE_SVG = ENABLE_SVG; … … 74 75 ENABLE_XSLT = ENABLE_XSLT; 75 76 76 FEATURE_DEFINES = $(ENABLE_3D_CANVAS) $(ENABLE_3D_RENDERING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATAGRID) $(ENABLE_DATALIST) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_RUBY) $(ENABLE_S HARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_VIDEO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WML) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT);77 FEATURE_DEFINES = $(ENABLE_3D_CANVAS) $(ENABLE_3D_RENDERING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATAGRID) $(ENABLE_DATALIST) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_RUBY) $(ENABLE_SANDBOX) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_VIDEO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WML) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT); -
trunk/WebKitLibraries/ChangeLog
r54943 r55043 1 2010-02-19 Maciej Stachowiak <mjs@apple.com> 2 3 Reviewed by David Levin. 4 5 Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases 6 https://bugs.webkit.org/show_bug.cgi?id=35147 7 8 * win/tools/vsprops/FeatureDefines.vsprops: 9 1 10 2010-02-18 Steve Falkenburg <sfalken@apple.com> 2 11 -
trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops
r54686 r55043 10 10 <Tool 11 11 Name="VCCLCompilerTool" 12 PreprocessorDefinitions="$(ENABLE_3D_CANVAS);$(ENABLE_3D_RENDERING);$(ENABLE_CHANNEL_MESSAGING);$(ENABLE_CLIENT_BASED_GEOLOCATION);$(ENABLE_DATABASE);$(ENABLE_DATAGRID);$(ENABLE_DATALIST);$(ENABLE_DOM_STORAGE);$(ENABLE_EVENTSOURCE);$(ENABLE_FILTERS);$(ENABLE_GEOLOCATION);$(ENABLE_ICONDATABASE);$(ENABLE_INDEXED_DATABASE);$(ENABLE_JAVASCRIPT_DEBUGGER);$(ENABLE_MATHML);$(ENABLE_NOTIFICATIONS);$(ENABLE_OFFLINE_WEB_APPLICATIONS);$(ENABLE_RUBY);$(ENABLE_S HARED_WORKERS);$(ENABLE_SVG);$(ENABLE_SVG_ANIMATION);$(ENABLE_SVG_AS_IMAGE);$(ENABLE_SVG_DOM_OBJC_BINDINGS);$(ENABLE_SVG_FONTS);$(ENABLE_SVG_FOREIGN_OBJECT);$(ENABLE_SVG_USE);$(ENABLE_VIDEO);$(ENABLE_WEB_SOCKETS);$(ENABLE_WML);$(ENABLE_WORKERS);$(ENABLE_XHTMLMP);$(ENABLE_XPATH);$(ENABLE_XSLT)"12 PreprocessorDefinitions="$(ENABLE_3D_CANVAS);$(ENABLE_3D_RENDERING);$(ENABLE_CHANNEL_MESSAGING);$(ENABLE_CLIENT_BASED_GEOLOCATION);$(ENABLE_DATABASE);$(ENABLE_DATAGRID);$(ENABLE_DATALIST);$(ENABLE_DOM_STORAGE);$(ENABLE_EVENTSOURCE);$(ENABLE_FILTERS);$(ENABLE_GEOLOCATION);$(ENABLE_ICONDATABASE);$(ENABLE_INDEXED_DATABASE);$(ENABLE_JAVASCRIPT_DEBUGGER);$(ENABLE_MATHML);$(ENABLE_NOTIFICATIONS);$(ENABLE_OFFLINE_WEB_APPLICATIONS);$(ENABLE_RUBY);$(ENABLE_SANDBOX);$(ENABLE_SHARED_WORKERS);$(ENABLE_SVG);$(ENABLE_SVG_ANIMATION);$(ENABLE_SVG_AS_IMAGE);$(ENABLE_SVG_DOM_OBJC_BINDINGS);$(ENABLE_SVG_FONTS);$(ENABLE_SVG_FOREIGN_OBJECT);$(ENABLE_SVG_USE);$(ENABLE_VIDEO);$(ENABLE_WEB_SOCKETS);$(ENABLE_WML);$(ENABLE_WORKERS);$(ENABLE_XHTMLMP);$(ENABLE_XPATH);$(ENABLE_XSLT)" 13 13 /> 14 14 <UserMacro … … 103 103 /> 104 104 <UserMacro 105 Name="ENABLE_SANDBOX" 106 Value="ENABLE_SANDBOX" 107 PerformEnvironmentSet="true" 108 /> 109 <UserMacro 105 110 Name="ENABLE_SHARED_WORKERS" 106 111 Value="ENABLE_SHARED_WORKERS" -
trunk/WebKitTools/ChangeLog
r55042 r55043 1 2010-02-19 Maciej Stachowiak <mjs@apple.com> 2 3 Reviewed by David Levin. 4 5 Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases 6 https://bugs.webkit.org/show_bug.cgi?id=35147 7 8 * Scripts/build-webkit: Handle new flag. 9 1 10 2010-02-19 Leandro Pereira <leandro@profusion.mobi> 2 11 -
trunk/WebKitTools/Scripts/build-webkit
r54698 r55043 54 54 my ($threeDCanvasSupport, $threeDRenderingSupport, $channelMessagingSupport, $clientBasedGeolocationSupport, $databaseSupport, $datagridSupport, $datalistSupport, 55 55 $domStorageSupport, $eventsourceSupport, $filtersSupport, $geolocationSupport, $iconDatabaseSupport, $indexedDatabaseSupport, 56 $javaScriptDebuggerSupport, $mathmlSupport, $offlineWebApplicationSupport, $rubySupport, $s haredWorkersSupport,56 $javaScriptDebuggerSupport, $mathmlSupport, $offlineWebApplicationSupport, $rubySupport, $sandboxSupport, $sharedWorkersSupport, 57 57 $svgSupport, $svgAnimationSupport, $svgAsImageSupport, $svgDOMObjCBindingsSupport, $svgFontsSupport, 58 58 $svgForeignObjectSupport, $svgUseSupport, $videoSupport, $webSocketsSupport, $wmlSupport, $wcssSupport, $xhtmlmpSupport, $workersSupport, … … 116 116 { option => "ruby", desc => "Toggle HTML5 Ruby support", 117 117 define => "ENABLE_RUBY", default => 1, value => \$rubySupport }, 118 119 { option => "sandbox", desc => "Toggle HTML5 Sandboxed iframe support", 120 define => "ENABLE_SANDBOX", default => 1, value => \$sandboxSupport }, 118 121 119 122 { option => "shared-workers", desc => "Toggle SharedWorkers support", -
trunk/configure.ac
r54878 r55043 388 388 AC_MSG_RESULT([$enable_ruby]) 389 389 390 # check whether to enable HTML5 rubysupport391 AC_MSG_CHECKING([whether to enable HTML5 rubysupport])390 # check whether to enable HTML5 sandbox iframe support 391 AC_MSG_CHECKING([whether to enable HTML5 sandboxed iframe support]) 392 392 AC_ARG_ENABLE(ruby, 393 AC_HELP_STRING([--enable- ruby],394 [enable HTML5 rubysupport [default=yes]]),395 [],[enable_ ruby="yes"])396 AC_MSG_RESULT([$enable_ ruby])393 AC_HELP_STRING([--enable-sandbox], 394 [enable HTML5 sandboxed iframe support [default=yes]]), 395 [],[enable_sandbox="yes"]) 396 AC_MSG_RESULT([$enable_sandbox]) 397 397 398 398 # check whether to enable HTML5 audio/video support … … 793 793 AM_CONDITIONAL([ENABLE_MATHML], [test "$enable_mathml" = "yes"]) 794 794 AM_CONDITIONAL([ENABLE_RUBY],[test "$enable_ruby" = "yes"]) 795 AM_CONDITIONAL([ENABLE_SANDBOX],[test "$enable_sandbox" = "yes"]) 795 796 AM_CONDITIONAL([ENABLE_VIDEO],[test "$enable_video" = "yes"]) 796 797 AM_CONDITIONAL([ENABLE_NOTIFICATIONS],[test "$enable_notifications" = "yes"]) … … 848 849 HTML5 client-side database storage support : $enable_database 849 850 HTML5 ruby support : $enable_ruby 851 HTML5 sandboxed iframe support : $enable_sandbox 850 852 HTML5 server-sent events support : $enable_eventsource 851 853 HTML5 video element support : $enable_video
Note: See TracChangeset
for help on using the changeset viewer.