Changeset 55064 in webkit


Ignore:
Timestamp:
Feb 21, 2010 1:19:02 PM (14 years ago)
Author:
mitz@apple.com
Message:

False warnings about needing layout in
-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]
https://bugs.webkit.org/show_bug.cgi?id=35218

Reviewed by Darin Adler.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
Suppress the warning and the forced layout if the view is not being drawn
in this display operation.

Location:
trunk/WebKit/mac
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit/mac/ChangeLog

    r55063 r55064  
     12010-02-21  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        False warnings about needing layout in
     6        -[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]
     7        https://bugs.webkit.org/show_bug.cgi?id=35218
     8
     9        * WebView/WebHTMLView.mm:
     10        (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
     11        Suppress the warning and the forced layout if the view is not being drawn
     12        in this display operation.
     13
    1142010-02-21  Kevin Decker  <kdecker@apple.com>
    215
    316        Reviewed by Sam Weinig.
    417
     18        plugInViewWithArguments: API sends wrong parameter for WebPlugInBaseURLKey
    519        https://bugs.webkit.org/show_bug.cgi?id=35215
    620        <rdar://problem/7673157>
  • trunk/WebKit/mac/WebView/WebHTMLView.mm

    r55041 r55064  
    12931293    // See <rdar://problem/6964278> for example. Performing layout at this point prevents us from
    12941294    // trying to paint without layout (which WebCore now refuses to do, instead bailing out without
    1295     // drawing at all), but we may still fail to update and regions dirtied by the layout which are
     1295    // drawing at all), but we may still fail to update any regions dirtied by the layout which are
    12961296    // not already dirty.
    12971297    if ([self _needsLayout]) {
    1298         LOG_ERROR("View needs layout. Either -viewWillDraw wasn't called or layout was invalidated during the display operation. Performing layout now.");
    1299         [self _web_layoutIfNeededRecursive];
     1298        NSInteger rectCount;
     1299        [self getRectsBeingDrawn:0 count:&rectCount];
     1300        if (rectCount) {
     1301            LOG_ERROR("View needs layout. Either -viewWillDraw wasn't called or layout was invalidated during the display operation. Performing layout now.");
     1302            [self _web_layoutIfNeededRecursive];
     1303        }
    13001304    }
    13011305#else
Note: See TracChangeset for help on using the changeset viewer.