Changeset 55309 in webkit

Timestamp:

Feb 26, 2010 1:48:19 PM (14 years ago)

Author:

tonikitoo@webkit.org

Message:

[Gtk] Make DRT EventSender::keyDown to consider 'hardware_keycode' field when synthesizing an event.
​https://bugs.webkit.org/show_bug.cgi?id=35432

Patch by Antonio Gomes <​tonikitoo@webkit.org>
Reviewed by Gustavo Noronha.

When a directional key-press event (arrow keys, End, Home, PageUp,
PageDown, etc) is synthesized by DRT's EventSender and it targets
an editor (e.g. <input type=text>, <textare>, etc), event is processed
by WebCore::EventHandler. On the other hand, if event target is not
an editor, event is bubbled up to Gtk+ for processing. In such cases,
if 'hardware_keycode' is not provided at event synthesize time
its processing fails (at some point in gtk_bindings_activate_event),
and no scroll action is performed.

Unskip fast/events/node-event-anchor-lock.html

• DumpRenderTree/win/EventSender.cpp:

(keyDownCallback):

• platform/gtk/Skipped:

Location:

trunk

Files:

• LayoutTests/platform/gtk/Skipped (modified) (1 diff)
• WebKitTools/ChangeLog (modified) (1 diff)
• WebKitTools/DumpRenderTree/gtk/EventSender.cpp (modified) (1 diff)

trunk/LayoutTests/platform/gtk/Skipped

@@ -5481 +5481 @@
 http/tests/security/window-events-pass.html
 
-# https://bugs.webkit.org/show_bug.cgi?id=30587
-fast/events/node-event-anchor-lock.html
-
 # Probably related to https://bugs.webkit.org/show_bug.cgi?id=27637
 http/tests/security/mixedContent/insecure-plugin-in-iframe.html

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-02-26  Antonio Gomes  <tonikitoo@webkit.org>
+
+        Reviewed by Gustavo Noronha.
+        Patch by Antonio Gomes <tonikitoo@webkit.org>
+
+        [Gtk] Make DRT EventSender::keyDown to consider 'hardware_keycode' field when synthesizing an event.
+        https://bugs.webkit.org/show_bug.cgi?id=35432
+
+        When a directional key-press event (arrow keys, End, Home, PageUp,
+        PageDown, etc) is synthesized by DRT's EventSender and it targets
+        an editor (e.g. <input type=text>, <textare>, etc), event is processed
+        by WebCore::EventHandler. On the other hand, if event target is not
+        an editor, event is bubbled up to Gtk+ for processing. In such cases,
+        if 'hardware_keycode' is not provided at event synthesize time
+        its processing fails (at some point in gtk_bindings_activate_event),
+        and no scroll action is performed.
+
+        Unskip fast/events/node-event-anchor-lock.html
+
+        * DumpRenderTree/win/EventSender.cpp:
+        (keyDownCallback):
+        * platform/gtk/Skipped:
+
 2010-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
 

trunk/WebKitTools/DumpRenderTree/gtk/EventSender.cpp

@@ -558 +558 @@
     event.key.window = GTK_WIDGET(view)->window;
 
+    // When synthesizing an event, an invalid hardware_keycode value
+    // can cause it to be badly processed by Gtk+.
+    GdkKeymapKey* keys;
+    gint n_keys;
+    if (gdk_keymap_get_entries_for_keyval(gdk_keymap_get_default(), gdkKeySym, &keys, &n_keys)) {
+        event.key.hardware_keycode = keys[0].keycode;
+        g_free(keys);
+    }
+
     gboolean return_val;
     event.key.type = GDK_KEY_PRESS;
+
     g_signal_emit_by_name(view, "key-press-event", &event.key, &return_val);