Changeset 55553 in webkit
- Timestamp:
- Mar 4, 2010 2:15:28 PM (14 years ago)
- Location:
- trunk/WebKitTools
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKitTools/ChangeLog
r55551 r55553 1 2010-03-04 Simon Fraser <simon.fraser@apple.com> 2 3 Build fix: add exceptions to the check-for-global-initializers script 4 for FocusController and SpatialNavigation, and improve the script 5 to actually print out the globals found. 6 7 * Scripts/check-for-global-initializers: 8 1 9 2010-03-04 Dirk Pranke <dpranke@chromium.org> 2 10 -
trunk/WebKitTools/Scripts/check-for-global-initializers
r54669 r55553 38 38 39 39 sub touch($); 40 sub demangle($); 40 41 41 42 my $arch = $ENV{'CURRENT_ARCH'}; … … 79 80 } 80 81 my $sawGlobal = 0; 82 my @globals; 81 83 while (<NM>) { 82 84 if (/^STDOUT:/) { 83 $sawGlobal = 1 if /__GLOBAL__I/; 85 my $line = $_; 86 if ($line =~ /__GLOBAL__I(.+)$/) { 87 $sawGlobal = 1; 88 push(@globals, demangle($1)); 89 } 84 90 } else { 85 91 print STDERR if $_ ne "nm: no name list\n"; … … 113 119 next if $shortName eq "SVGElementInstance.o"; 114 120 next if $shortName eq "XMLHttpRequest.o"; 121 122 #FIXME: check to see if these are legit. 123 next if $shortName eq "FocusController.o"; 124 next if $shortName eq "SpatialNavigation.o"; 115 125 } 116 126 if ($target eq "WebKit") { … … 121 131 122 132 print "ERROR: $shortName has a global initializer in it! ($file)\n"; 133 print "ERROR: @globals\n"; 123 134 $sawError = 1; 124 135 } … … 139 150 close(TOUCH); 140 151 } 152 153 sub demangle($) 154 { 155 my ($symbol) = @_; 156 if (!open FILT, "c++filt $symbol |") { 157 print "ERROR: Could not open c++filt\n"; 158 return; 159 } 160 my $result = <FILT>; 161 close FILT; 162 chomp $result; 163 return $result; 164 } 165
Note: See TracChangeset
for help on using the changeset viewer.