Changeset 55580 in webkit

Timestamp:

Mar 5, 2010 7:58:58 AM (14 years ago)

Author:

tonikitoo@webkit.org

Message:

[Qt] Add setSpatialNavigationEnabled method DRT
​https://bugs.webkit.org/show_bug.cgi?id=33715

Reviewed by Simon Hausmann.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

Added setSpatialNavigationEnabled support to Qt DRT.

• DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::WebPage):
(WebCore::WebPage::resetSettings):

• DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setSpatialNavigationEnabled):

• DumpRenderTree/qt/LayoutTestControllerQt.h:

Unskipped fast/events/spatial-navigation/

Location:

trunk

Files:

• LayoutTests/platform/qt/Skipped (modified) (1 diff)
• WebKitTools/ChangeLog (modified) (1 diff)
• WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp (modified) (2 diffs)
• WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp (modified) (1 diff)
• WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.h (modified) (1 diff)

trunk/LayoutTests/platform/qt/Skipped

@@ -5096 +5096 @@
 # Core functionality is tested in plugins/private-browsing-mode-2.html
 plugins/private-browsing-mode.html
-
-# Need to add functionality to DumpRenderTree to handle enable/disable Spatial Navigation
-fast/events/spatial-navigation

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-03-02  Antonio Gomes  <tonikitoo@webkit.org>
+
+        Reviewed by Simon Hausmann.
+        Patch by Antonio Gomes <tonikitoo@webkit.org>
+
+        [Qt] Add setSpatialNavigationEnabled method DRT
+        https://bugs.webkit.org/show_bug.cgi?id=33715
+
+        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
+        (WebCore::WebPage::WebPage):
+        (WebCore::WebPage::resetSettings):
+        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
+        (LayoutTestController::setSpatialNavigationEnabled):
+        * DumpRenderTree/qt/LayoutTestControllerQt.h:
+
+        Unskipped fast/events/spatialnavigation/
+
 2010-03-04  Mark Rowe  <mrowe@apple.com>
 

trunk/WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp

@@ -133 +133 @@
     globalSettings->setAttribute(QWebSettings::JavascriptEnabled, true);
     globalSettings->setAttribute(QWebSettings::PrivateBrowsingEnabled, false);
+    globalSettings->setAttribute(QWebSettings::SpatialNavigationEnabled, false);
 
     connect(this, SIGNAL(geometryChangeRequested(const QRect &)),
@@ -163 +164 @@
     settings()->resetAttribute(QWebSettings::JavascriptEnabled);
     settings()->resetAttribute(QWebSettings::PrivateBrowsingEnabled);
+    settings()->resetAttribute(QWebSettings::SpatialNavigationEnabled);
     settings()->resetAttribute(QWebSettings::LinksIncludedInFocusChain);
     settings()->resetAttribute(QWebSettings::OfflineWebApplicationCacheEnabled);

trunk/WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp

@@ -345 +345 @@
 }
 
+void LayoutTestController::setSpatialNavigationEnabled(bool enable)
+{
+    m_drt->webPage()->settings()->setAttribute(QWebSettings::SpatialNavigationEnabled, enable);
+}
+
 void LayoutTestController::setPopupBlockingEnabled(bool enable)
 {

trunk/WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.h

@@ -129 +129 @@
     void setFixedContentsSize(int width, int height);
     void setPrivateBrowsingEnabled(bool enable);
+    void setSpatialNavigationEnabled(bool enabled);
     void setPopupBlockingEnabled(bool enable);
     void setPOSIXLocale(const QString& locale);