Changeset 55611 in webkit


Ignore:
Timestamp:
Mar 5, 2010 10:45:32 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-03-05 Chris Fleizach <Chris Fleizach>

Reviewed by Eric Seidel.

WAI-ARIA live region doesn't appear when <div> only has a <div> child
​https://bugs.webkit.org/show_bug.cgi?id=35751

  • platform/mac/accessibility/div-containing-div-with-aria-expected.txt: Added.
  • platform/mac/accessibility/div-containing-div-with-aria.html: Added.

2010-03-05 Chris Fleizach <Chris Fleizach>

Reviewed by Eric Seidel.

WAI-ARIA live region doesn't appear when <div> only has a <div> child
​https://bugs.webkit.org/show_bug.cgi?id=35751

Elements should not be ignored if they carry ARIA attributes in them.

Test: platform/mac/accessibility/div-containing-div-with-aria.html

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::supportsARIAAttributes):
  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::supportsARIADropping): (WebCore::AccessibilityObject::supportsARIADragging):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::supportsARIADropping): (WebCore::AccessibilityRenderObject::supportsARIADragging): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  • accessibility/AccessibilityRenderObject.h:
Location:
trunk
Files:
2 added
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r55608 r55611  
     12010-03-05  Chris Fleizach  <cfleizach@apple.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        WAI-ARIA live region doesn't appear when <div> only has a <div> child
     6        https://bugs.webkit.org/show_bug.cgi?id=35751
     7
     8        * platform/mac/accessibility/div-containing-div-with-aria-expected.txt: Added.
     9        * platform/mac/accessibility/div-containing-div-with-aria.html: Added.
     10
    1112010-03-05  Dmitry Titov  <dimich@chromium.org>
    212

  • trunk/WebCore/ChangeLog

    r55609 r55611  
     12010-03-05  Chris Fleizach  <cfleizach@apple.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        WAI-ARIA live region doesn't appear when <div> only has a <div> child
     6        https://bugs.webkit.org/show_bug.cgi?id=35751
     7
     8        Elements should not be ignored if they carry ARIA attributes in them.
     9
     10        Test: platform/mac/accessibility/div-containing-div-with-aria.html
     11
     12        * accessibility/AccessibilityObject.cpp:
     13        (WebCore::AccessibilityObject::supportsARIAAttributes):
     14        * accessibility/AccessibilityObject.h:
     15        (WebCore::AccessibilityObject::supportsARIADropping):
     16        (WebCore::AccessibilityObject::supportsARIADragging):
     17        * accessibility/AccessibilityRenderObject.cpp:
     18        (WebCore::AccessibilityRenderObject::supportsARIADropping):
     19        (WebCore::AccessibilityRenderObject::supportsARIADragging):
     20        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
     21        * accessibility/AccessibilityRenderObject.h:
     22
    1232010-03-05  Dmitry Titov  <dimich@chromium.org>
    224

  • trunk/WebCore/accessibility/AccessibilityObject.cpp

    r55425 r55611  
    962962}
    963963
     964bool AccessibilityObject::supportsARIAAttributes() const
     965{
     966    return supportsARIALiveRegion() || supportsARIADragging() || supportsARIADropping() || supportsARIAFlowTo() || supportsARIAOwns();
     967}
     968   
    964969bool AccessibilityObject::supportsARIALiveRegion() const
    965970{

  • trunk/WebCore/accessibility/AccessibilityObject.h

    r55425 r55611  
    348348   
    349349    // ARIA drag and drop
    350     virtual bool supportsARIADropping() { return false; }
    351     virtual bool supportsARIADragging() { return false; }
     350    virtual bool supportsARIADropping() const { return false; }
     351    virtual bool supportsARIADragging() const { return false; }
    352352    virtual bool isARIAGrabbed() { return false; }
    353353    virtual void setARIAGrabbed(bool) { }
    … …  
    520520    virtual bool ariaLiveRegionBusy() const { return false; }
    521521   
     522    bool supportsARIAAttributes() const;
     523   
    522524#if HAVE(ACCESSIBILITY)
    523525#if PLATFORM(GTK)

  • trunk/WebCore/accessibility/AccessibilityRenderObject.cpp

    r55425 r55611  
    13421342}
    13431343   
    1344 bool AccessibilityRenderObject::supportsARIADropping()
     1344bool AccessibilityRenderObject::supportsARIADropping() const
    13451345{
    13461346    const AtomicString& dropEffect = getAttribute(aria_dropeffectAttr).string();
    … …  
    13481348}
    13491349
    1350 bool AccessibilityRenderObject::supportsARIADragging()
     1350bool AccessibilityRenderObject::supportsARIADragging() const
    13511351{
    13521352    const AtomicString& grabbed = getAttribute(aria_grabbedAttr).string();
    … …  
    15491549            return false;
    15501550    }
     1551   
     1552    // if this element has aria attributes on it, it should not be ignored.
     1553    if (supportsARIAAttributes())
     1554        return false;
    15511555   
    15521556    if (m_renderer->isBlockFlow() && m_renderer->childrenInline())

  • trunk/WebCore/accessibility/AccessibilityRenderObject.h

    r55390 r55611  
    228228    virtual void ariaFlowToElements(AccessibilityChildrenVector&) const;
    229229
    230     virtual bool supportsARIADropping();
    231     virtual bool supportsARIADragging();
     230    virtual bool supportsARIADropping() const;
     231    virtual bool supportsARIADragging() const;
    232232    virtual bool isARIAGrabbed();
    233233    virtual void setARIAGrabbed(bool);
Note: See TracChangeset for help on using the changeset viewer.