Changeset 55716 in webkit


Ignore:
Timestamp:
Mar 9, 2010 1:01:36 AM (14 years ago)
Author:
Philippe Normand
Message:

2010-03-09 Philippe Normand <​pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GStreamer] player code cleanups
​https://bugs.webkit.org/show_bug.cgi?id=35868

Splitted GOwnPtrGtk.{cpp,h} to GOwnPtr{Soup,GStreamer}.{cpp,h}.

  • GNUmakefile.am:
  • platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: Added. (WTF::GstElement):
  • platform/graphics/gstreamer/GOwnPtrGStreamer.h: Added.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/gtk/GOwnPtrGtk.cpp: Removed.
  • platform/gtk/GOwnPtrGtk.h: Removed.
  • platform/network/soup/CookieJarSoup.cpp:
  • platform/network/soup/DNSSoup.cpp:
  • platform/network/soup/GOwnPtrSoup.cpp: Added. (WTF::SoupURI):
  • platform/network/soup/GOwnPtrSoup.h: Added.
  • platform/network/soup/ResourceHandleSoup.cpp:
  • platform/network/soup/ResourceRequestSoup.cpp:
Location:
trunk/WebCore
Files:
7 edited
2 copied
2 moved

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r55714 r55716  
     12010-03-09  Philippe Normand  <pnormand@igalia.com>
     2
     3        Reviewed by Gustavo Noronha Silva.
     4
     5        [GStreamer] player code cleanups
     6        https://bugs.webkit.org/show_bug.cgi?id=35868
     7
     8        Splitted GOwnPtrGtk.{cpp,h} to GOwnPtr{Soup,GStreamer}.{cpp,h}.
     9
     10        * GNUmakefile.am:
     11        * platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: Added.
     12        (WTF::GstElement):
     13        * platform/graphics/gstreamer/GOwnPtrGStreamer.h: Added.
     14        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
     15        * platform/gtk/GOwnPtrGtk.cpp: Removed.
     16        * platform/gtk/GOwnPtrGtk.h: Removed.
     17        * platform/network/soup/CookieJarSoup.cpp:
     18        * platform/network/soup/DNSSoup.cpp:
     19        * platform/network/soup/GOwnPtrSoup.cpp: Added.
     20        (WTF::SoupURI):
     21        * platform/network/soup/GOwnPtrSoup.h: Added.
     22        * platform/network/soup/ResourceHandleSoup.cpp:
     23        * platform/network/soup/ResourceRequestSoup.cpp:
     24
    1252010-03-09  Shinichiro Hamaji  <hamaji@chromium.org>
    226

  • trunk/WebCore/GNUmakefile.am

    r55670 r55716  
    20382038        WebCore/platform/gtk/GRefPtrGtk.cpp \
    20392039        WebCore/platform/gtk/GRefPtrGtk.h \
    2040         WebCore/platform/gtk/GOwnPtrGtk.cpp \
    2041         WebCore/platform/gtk/GOwnPtrGtk.h \
    20422040        WebCore/platform/gtk/GtkPluginWidget.cpp \
    20432041        WebCore/platform/gtk/GtkPluginWidget.h \
    … …  
    20962094        WebCore/platform/network/soup/ResourceRequest.h \
    20972095        WebCore/platform/network/soup/ResourceResponse.h \
     2096        WebCore/platform/network/soup/GOwnPtrSoup.h \
     2097        WebCore/platform/network/soup/GOwnPtrSoup.cpp \
    20982098        WebCore/workers/SharedWorkerRepository.h
    20992099
    … …  
    24372437        WebCore/platform/graphics/gstreamer/DataSourceGStreamer.cpp \
    24382438        WebCore/platform/graphics/gstreamer/DataSourceGStreamer.h \
     2439        WebCore/platform/graphics/gstreamer/GOwnPtrGStreamer.cpp \
     2440        WebCore/platform/graphics/gstreamer/GOwnPtrGStreamer.h \
    24392441        WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp \
    24402442        WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.h

  • trunk/WebCore/platform/graphics/gstreamer/GOwnPtrGStreamer.cpp

    r55715 r55716  
    1919
    2020#include "config.h"
    21 #include "GOwnPtrGtk.h"
     21#include "GOwnPtrGStreamer.h"
    2222
    2323#if ENABLE(VIDEO)
    2424#include <gst/gstelement.h>
    25 #endif
    26 #include <libsoup/soup-uri.h>
    2725
    2826namespace WTF {
    2927
    30 template <> void freeOwnedGPtr<SoupURI>(SoupURI* ptr)
    31 {
    32     if (ptr)
    33         soup_uri_free(ptr);
    34 }
    35 
    36 #if ENABLE(VIDEO)
    3728template <> void freeOwnedGPtr<GstElement>(GstElement* ptr)
    3829{

  • trunk/WebCore/platform/graphics/gstreamer/GOwnPtrGStreamer.h

    r55715 r55716  
    1818 */
    1919
    20 #ifndef GOwnPtrGtk_h
    21 #define GOwnPtrGtk_h
     20#ifndef GOwnPtrGStreamer_h
     21#define GOwnPtrGStreamer_h
    2222
    2323#include "GOwnPtr.h"
    2424
    25 typedef struct _SoupURI SoupURI;
    2625typedef struct _GstElement GstElement;
    2726
    2827namespace WTF {
    2928
    30 template<> void freeOwnedGPtr<SoupURI>(SoupURI* ptr);
    3129template<> void freeOwnedGPtr<GstElement>(GstElement* ptr);
    3230

  • trunk/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

    r55657 r55716  
    3434#include "Frame.h"
    3535#include "FrameView.h"
    36 #include "GOwnPtrGtk.h"
     36#include "GOwnPtrGStreamer.h"
    3737#include "GraphicsContext.h"
    3838#include "IntRect.h"

  • trunk/WebCore/platform/network/soup/CookieJarSoup.cpp

    r54707 r55716  
    2525#include "CString.h"
    2626#include "Document.h"
    27 #include "GOwnPtrGtk.h"
     27#include "GOwnPtrSoup.h"
    2828#include "KURL.h"
    2929

  • trunk/WebCore/platform/network/soup/DNSSoup.cpp

    r54375 r55716  
    2929
    3030#include "CString.h"
    31 #include "GOwnPtrGtk.h"
     31#include "GOwnPtrSoup.h"
    3232#include "ResourceHandle.h"
    3333

  • trunk/WebCore/platform/network/soup/GOwnPtrSoup.cpp

    r55715 r55716  
    1919
    2020#include "config.h"
    21 #include "GOwnPtrGtk.h"
     21#include "GOwnPtrSoup.h"
    2222
    23 #if ENABLE(VIDEO)
    24 #include <gst/gstelement.h>
    25 #endif
    2623#include <libsoup/soup-uri.h>
    2724
    … …  
    3431}
    3532
    36 #if ENABLE(VIDEO)
    37 template <> void freeOwnedGPtr<GstElement>(GstElement* ptr)
    38 {
    39     if (ptr)
    40         gst_object_unref(ptr);
    4133}
    42 #endif
    43 
    44 }

  • trunk/WebCore/platform/network/soup/GOwnPtrSoup.h

    r55715 r55716  
    1818 */
    1919
    20 #ifndef GOwnPtrGtk_h
    21 #define GOwnPtrGtk_h
     20#ifndef GOwnPtrSoup_h
     21#define GOwnPtrSoup_h
    2222
    2323#include "GOwnPtr.h"
    2424
    2525typedef struct _SoupURI SoupURI;
    26 typedef struct _GstElement GstElement;
    2726
    2827namespace WTF {
    2928
    3029template<> void freeOwnedGPtr<SoupURI>(SoupURI* ptr);
    31 template<> void freeOwnedGPtr<GstElement>(GstElement* ptr);
    3230
    3331}

  • trunk/WebCore/platform/network/soup/ResourceHandleSoup.cpp

    r55692 r55716  
    3535#include "FileSystem.h"
    3636#include "Frame.h"
    37 #include "GOwnPtrGtk.h"
     37#include "GOwnPtrSoup.h"
    3838#include "HTTPParsers.h"
    3939#include "Logging.h"

  • trunk/WebCore/platform/network/soup/ResourceRequestSoup.cpp

    r55086 r55716  
    2323#include "CString.h"
    2424#include "GOwnPtr.h"
    25 #include "GOwnPtrGtk.h"
     25#include "GOwnPtrSoup.h"
    2626#include "HTTPParsers.h"
    2727#include "MIMETypeRegistry.h"
Note: See TracChangeset for help on using the changeset viewer.