Changeset 55717 in webkit
- Timestamp:
- Mar 9, 2010 1:01:54 AM (14 years ago)
- Location:
- trunk/WebCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebCore/ChangeLog
r55716 r55717 1 2010-03-09 Philippe Normand <pnormand@igalia.com> 2 3 Reviewed by Gustavo Noronha Silva. 4 5 [GStreamer] player code cleanups 6 https://bugs.webkit.org/show_bug.cgi?id=35868 7 8 Cleaned up the private instance variables of the player. 9 10 * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: 11 (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): 12 (WebCore::MediaPlayerPrivate::fillTimerFired): 13 (WebCore::MediaPlayerPrivate::mediaLocationChanged): 14 * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: 15 1 16 2010-03-09 Philippe Normand <pnormand@igalia.com> 2 17 -
trunk/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
r55716 r55717 292 292 , m_fillTimer(this, &MediaPlayerPrivate::fillTimerFired) 293 293 , m_maxTimeLoaded(0) 294 , m_fillStatus(0)295 294 { 296 295 if (doGstInit()) … … 671 670 672 671 gint64 start, stop; 672 gdouble fillStatus = 100.0; 673 673 674 674 gst_query_parse_buffering_range(query, 0, &start, &stop, 0); … … 676 676 677 677 if (stop != -1) 678 m_fillStatus = 100.0 * stop / GST_FORMAT_PERCENT_MAX; 679 else 680 m_fillStatus = 100.0; 681 682 LOG_VERBOSE(Media, "Download buffer filled up to %f%%", m_fillStatus); 678 fillStatus = 100.0 * stop / GST_FORMAT_PERCENT_MAX; 679 680 LOG_VERBOSE(Media, "Download buffer filled up to %f%%", fillStatus); 683 681 684 682 if (!m_mediaDuration) … … 688 686 // available. Otherwise we can't compute it. 689 687 if (m_mediaDuration) { 690 m_maxTimeLoaded = static_cast<float>(( m_fillStatus * m_mediaDuration) / 100.0);688 m_maxTimeLoaded = static_cast<float>((fillStatus * m_mediaDuration) / 100.0); 691 689 LOG_VERBOSE(Media, "Updated maxTimeLoaded: %f", m_maxTimeLoaded); 692 690 } 693 691 694 if ( m_fillStatus != 100.0) {692 if (fillStatus != 100.0) { 695 693 updateStates(); 696 694 return; … … 935 933 936 934 if (locations) 937 m_mediaLocationCurrentIndex = gst_value_list_get_size(locations) -1;935 m_mediaLocationCurrentIndex = static_cast<int>(gst_value_list_get_size(locations)) -1; 938 936 939 937 loadNextLocation(); -
trunk/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h
r55657 r55717 155 155 GstBuffer* m_buffer; 156 156 GstStructure* m_mediaLocations; 157 gint m_mediaLocationCurrentIndex;157 int m_mediaLocationCurrentIndex; 158 158 bool m_resetPipeline; 159 159 bool m_paused; … … 161 161 float m_playbackRate; 162 162 bool m_errorOccured; 163 gfloat m_mediaDuration;163 float m_mediaDuration; 164 164 bool m_startedBuffering; 165 165 Timer<MediaPlayerPrivate> m_fillTimer; 166 166 float m_maxTimeLoaded; 167 gdouble m_fillStatus;168 167 }; 169 168 }
Note: See TracChangeset
for help on using the changeset viewer.