Changeset 55937 in webkit

Timestamp:

Mar 12, 2010 2:42:19 PM (14 years ago)

Author:

dpranke@chromium.org

Message:

2010-03-12 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

Fix new-run-webkit-tests --run-singly

This script option is currently broken - the script attempts to
dereference methods and variables that don't exist, which causes
the Chromium Linux valgrind bot to be quite unhappy. This has been
broken since r54449 when I renamed Port.start_test_driver to
Port.start_driver.

​https://bugs.webkit.org/show_bug.cgi?id=36042

• Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py (modified) (2 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-03-12  Dirk Pranke  <dpranke@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Fix new-run-webkit-tests --run-singly
+
+        This script option is currently broken - the script attempts to
+        dereference methods and variables that don't exist, which causes
+        the Chromium Linux valgrind bot to be quite unhappy. This has been
+        broken since r54449 when I renamed Port.start_test_driver to
+        Port.start_driver.
+
+        https://bugs.webkit.org/show_bug.cgi?id=36042
+
+        * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
+
 2010-03-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 

trunk/WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py

@@ -150 +150 @@
 
     def run(self):
-        driver = self._port.start_test_driver(self._image_path,
-            self._shell_args)
+        test_info = self._test_info
+        driver = self._port.start_driver(self._image_path, self._shell_args)
         start = time.time()
         crash, timeout, actual_checksum, output, error = \
@@ -158 +158 @@
         end = time.time()
         self._test_stats = process_output(self._port,
-            self._test_info, self._test_types, self._test_args,
+            test_info, self._test_types, self._test_args,
             self._target, self._output_dir, crash, timeout, end - start,
             actual_checksum, output, error)