Changeset 55998 in webkit

Timestamp:

Mar 15, 2010 8:54:38 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-03-15 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

option-pageup/down should move cursor on chromium mac
​https://bugs.webkit.org/show_bug.cgi?id=36108

Remove waitUntilDone/notifyDone from the layout test, it's not needed
and causes timeouts on failure.

• editing/input/option-page-up-down.html:

2010-03-15 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

option-pageup/down should move cursor on chromium mac
​https://bugs.webkit.org/show_bug.cgi?id=36108

• src/EditorClientImpl.cpp: (WebKit::):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/input/option-page-up-down.html (modified) (2 diffs)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/src/EditorClientImpl.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-03-15  Tony Chang  <tony@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        option-pageup/down should move cursor on chromium mac
+        https://bugs.webkit.org/show_bug.cgi?id=36108
+
+        Remove waitUntilDone/notifyDone from the layout test, it's not needed
+        and causes timeouts on failure.
+
+        * editing/input/option-page-up-down.html:
+
 2010-03-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 

trunk/LayoutTests/editing/input/option-page-up-down.html

@@ -1 +1 @@
 <script>
-if (window.layoutTestController) {
+if (window.layoutTestController)
     layoutTestController.dumpAsText();
-    layoutTestController.waitUntilDone();
-}
 
 function runTest()
@@ -37 +35 @@
 
     document.getElementById("results").innerText = "PASS";
-
-    if (window.layoutTestController)
-        window.layoutTestController.notifyDone();
 }
 </script>

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-03-15  Tony Chang  <tony@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        option-pageup/down should move cursor on chromium mac
+        https://bugs.webkit.org/show_bug.cgi?id=36108
+
+        * src/EditorClientImpl.cpp:
+        (WebKit::):
+
 2010-03-13  Eric Roman  <eroman@chromium.org>
 

trunk/WebKit/chromium/src/EditorClientImpl.cpp

@@ -414 +414 @@
     { VKEY_DOWN,   ShiftKey,           "MoveDownAndModifySelection"           },
     { VKEY_NEXT,   ShiftKey,           "MovePageDownAndModifySelection"       },
+#if !OS(DARWIN)
     { VKEY_PRIOR,  0,                  "MovePageUp"                           },
     { VKEY_NEXT,   0,                  "MovePageDown"                         },
+#endif
     { VKEY_HOME,   0,                  "MoveToBeginningOfLine"                },
     { VKEY_HOME,   ShiftKey,
@@ -423 +425 @@
     { VKEY_LEFT,   CommandKey | ShiftKey,
       "MoveToBeginningOfLineAndModifySelection"                               },
+    { VKEY_PRIOR,  OptionKey,          "MovePageUp"                           },
+    { VKEY_NEXT,   OptionKey,          "MovePageDown"                         },
 #endif
 #if OS(DARWIN)