Changeset 56064 in webkit

Timestamp:

Mar 16, 2010 9:09:31 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-03-16 Adam Barth <​abarth@webkit.org>

Unreviewed.

noscript tag should render when @sandbox disables JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=36092

Add missing "!" in plugin code. Should fix plugins/embed-inside-object
on Gtk and Qt.

• plugins/PluginView.cpp: (WebCore::PluginView::load):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• plugins/PluginView.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-03-16  Adam Barth  <abarth@webkit.org>
+
+        Unreviewed.
+
+        noscript tag should render when @sandbox disables JavaScript
+        https://bugs.webkit.org/show_bug.cgi?id=36092
+
+        Add missing "!" in plugin code.  Should fix plugins/embed-inside-object
+        on Gtk and Qt.
+
+        * plugins/PluginView.cpp:
+        (WebCore::PluginView::load):
+
 2010-03-16  Nate Chapin  <japhet@chromium.org>
 

trunk/WebCore/plugins/PluginView.cpp

@@ -535 +535 @@
     if (!jsString.isNull()) {
         // Return NPERR_GENERIC_ERROR if JS is disabled. This is what Mozilla does.
-        if (m_parentFrame->script()->canExecuteScripts(NotAboutToExecuteScript))
+        if (!m_parentFrame->script()->canExecuteScripts(NotAboutToExecuteScript))
             return NPERR_GENERIC_ERROR;