Changeset 56165 in webkit

Timestamp:

Mar 18, 2010, 9:20:57 AM (15 years ago)

Author:

yurys@chromium.org

Message:

2010-03-18 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Preserve console history between debugging sessions.

​https://bugs.webkit.org/show_bug.cgi?id=36223

• inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._settingsLoaded): (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult): (WebInspector.ConsoleView.prototype._enterKeyPressed):
• inspector/front-end/Settings.js: (WebInspector.Settings.prototype._load):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ConsoleView.js (modified) (3 diffs)
• inspector/front-end/Settings.js (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-03-18  Yury Semikhatsky  <yurys@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Preserve console history between debugging sessions.
+
+        https://bugs.webkit.org/show_bug.cgi?id=36223
+
+        * inspector/front-end/ConsoleView.js:
+        (WebInspector.ConsoleView.prototype._settingsLoaded):
+        (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult):
+        (WebInspector.ConsoleView.prototype._enterKeyPressed):
+        * inspector/front-end/Settings.js:
+        (WebInspector.Settings.prototype._load):
+
 2010-03-18  Kim Grönholm  <kim.gronholm@nomovok.com>
 

trunk/WebCore/inspector/front-end/ConsoleView.js

@@ -49 +49 @@
     this.promptElement.addEventListener("keydown", this._promptKeyDown.bind(this), true);
     this.prompt = new WebInspector.TextPrompt(this.promptElement, this.completions.bind(this), ExpressionStopCharacters + ".");
+    WebInspector.settings.addEventListener("loaded", this._settingsLoaded, this);
 
     this.topGroup = new WebInspector.ConsoleGroup(null, 0);
@@ -116 +117 @@
 
 WebInspector.ConsoleView.prototype = {
+    _settingsLoaded: function()
+    {
+        this.prompt.history = WebInspector.settings.consoleHistory;
+    },
     
     _updateFilter: function(e)
@@ -505 +510 @@
             self.prompt.historyOffset = 0;
             self.prompt.text = "";
+
+            WebInspector.settings.consoleHistory = self.prompt.history.slice(-30);
+
             self.addMessage(new WebInspector.ConsoleCommandResult(result, exception, commandMessage));
         }

trunk/WebCore/inspector/front-end/Settings.js

@@ -72 +72 @@
         this._installSetting("showUserAgentStyles", "show-user-agent-styles", true);
         this._installSetting("resourceViewTab", "resource-view-tab", "content");
+        this._installSetting("consoleHistory", "console-history", []);
         this.dispatchEventToListeners("loaded");
     },