Changeset 56171 in webkit

Timestamp:

Mar 18, 2010 11:03:44 AM (14 years ago)

Author:

hyatt@apple.com

Message:

​https://bugs.webkit.org/show_bug.cgi?id=36283

Reviewed by Simon Fraser.

The wrong constants were being used for the code that attempted to compact the background-repeat shorthand to
a single value.

Added fast/backgrounds/background-repeat-computed-style.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::fillRepeatToCSSValue):

Location:

trunk

Files:

• LayoutTests/fast/backgrounds/background-repeat-computed-style-expected.txt (added)
• LayoutTests/fast/backgrounds/background-repeat-computed-style.html (added)
• LayoutTests/fast/backgrounds/resources/map.jpg (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/css/CSSComputedStyleDeclaration.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-03-18  David Hyatt  <hyatt@apple.com>
+
+        Reviewed by Simon Fraser.
+
+        https://bugs.webkit.org/show_bug.cgi?id=36283
+        
+        The wrong constants were being used for the code that attempted to compact the background-repeat shorthand to
+        a single value.
+
+        Added fast/backgrounds/background-repeat-computed-style.html
+
+        * css/CSSComputedStyleDeclaration.cpp:
+        (WebCore::fillRepeatToCSSValue):
+
 2010-03-18  Simon Fraser  <simon.fraser@apple.com>
 

trunk/WebCore/css/CSSComputedStyleDeclaration.cpp

@@ -631 +631 @@
     if (xRepeat == yRepeat)
         return CSSPrimitiveValue::create(xRepeat);
-    if (xRepeat == CSSValueRepeat && yRepeat == CSSValueNoRepeat)
+    if (xRepeat == RepeatFill && yRepeat == NoRepeatFill)
         return CSSPrimitiveValue::createIdentifier(CSSValueRepeatX);
-    if (xRepeat == CSSValueNoRepeat && yRepeat == CSSValueRepeat)
+    if (xRepeat == NoRepeatFill && yRepeat == RepeatFill)
         return CSSPrimitiveValue::createIdentifier(CSSValueRepeatY);