Changeset 56300 in webkit


Ignore:
Timestamp:
Mar 20, 2010 1:12:18 AM (14 years ago)
Author:
mjs@apple.com
Message:

2010-03-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

Fix a bunch of HTML5 validation errors on various pages.
https://bugs.webkit.org/show_bug.cgi?id=36409

  • building/build.html:
  • building/checkout.html:
  • building/debug.html:
  • building/run.html:
  • building/tools.html:
  • coding/coding-style.html:
  • coding/contributing.html:
  • coding/major-objects.html:
  • css/main.css: (.asciiart):
  • demos/index.html:
  • header.inc:
  • projects/compat/index.html:
  • projects/css/index.html:
  • projects/documentation/index.html:
  • projects/goals.html:
  • projects/index.html:
  • projects/mathml/index.html:
  • quality/bugpriorities.html:
  • quality/bugwriting.html:
  • quality/crashlogs.html:
  • quality/lifecycle.html:
  • quality/testing.html:
  • quality/testwriting.html:
Location:
trunk/WebKitSite
Files:
24 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitSite/ChangeLog

    r56299 r56300  
     12010-03-20  Maciej Stachowiak  <mjs@apple.com>
     2
     3        Reviewed by Mark Rowe.
     4
     5        Fix a bunch of HTML5 validation errors on various pages.
     6        https://bugs.webkit.org/show_bug.cgi?id=36409
     7
     8        * building/build.html:
     9        * building/checkout.html:
     10        * building/debug.html:
     11        * building/run.html:
     12        * building/tools.html:
     13        * coding/coding-style.html:
     14        * coding/contributing.html:
     15        * coding/major-objects.html:
     16        * css/main.css:
     17        (.asciiart):
     18        * demos/index.html:
     19        * header.inc:
     20        * projects/compat/index.html:
     21        * projects/css/index.html:
     22        * projects/documentation/index.html:
     23        * projects/goals.html:
     24        * projects/index.html:
     25        * projects/mathml/index.html:
     26        * quality/bugpriorities.html:
     27        * quality/bugwriting.html:
     28        * quality/crashlogs.html:
     29        * quality/lifecycle.html:
     30        * quality/testing.html:
     31        * quality/testwriting.html:
     32
    1332010-03-19  Maciej Stachowiak  <mjs@apple.com>
    234
  • trunk/WebKitSite/building/build.html

    r51932 r56300  
    1818
    1919<ol>
    20 <li><p>Run the <tt>build-webkit</tt> <a href="/coding/scripts.html">script</a>
     20<li><p>Run the <code>build-webkit</code> <a href="/coding/scripts.html">script</a>
    2121to build WebKit.</p>
    22 <p>Use the <tt>--debug</tt> option for a debug build, which includes
     22<p>Use the <code>--debug</code> option for a debug build, which includes
    2323debugging symbols and assertions:</p>
    2424<p class="code">build-webkit --debug</p>
     
    2626</ol>
    2727
    28 <p>By default, <tt>build-webkit</tt> places build products in <tt>WebKit/WebKitBuild</tt>.  You can specify a different build
    29 location on Mac in your Xcode preferences.  On Windows, the <tt>WEBKITOUTPUTDIR</tt> environment variable can be used to
    30 set a different build products location. If you have set up a custom build location, then <tt>build-webkit</tt> will
     28<p>By default, <code>build-webkit</code> places build products in <code>WebKit/WebKitBuild</code>.  You can specify a different build
     29location on Mac in your Xcode preferences.  On Windows, the <code>WEBKITOUTPUTDIR</code> environment variable can be used to
     30set a different build products location. If you have set up a custom build location, then <code>build-webkit</code> will
    3131place the build products there.</p>
    3232
     
    4444<h2>Setting a Default Configuration</h2>
    4545<ol>
    46 <li><p>To set a default build configuration for <tt>build-webkit</tt> and
     46<li><p>To set a default build configuration for <code>build-webkit</code> and
    4747other <a href="/coding/scripts.html">scripts</a>, use the
    48 <tt>set-webkit-configuration</tt> script:</p>
     48<code>set-webkit-configuration</code> script:</p>
    4949<p class="code">set-webkit-configuration --debug</p>
    5050<p class="code">set-webkit-configuration --release</p>
  • trunk/WebKitSite/building/checkout.html

    r51733 r56300  
    4343<ol>
    4444<li><p>Install the WebKit Support Libraries</p>
    45 <p>Download the <a href="http://developer.apple.com/opensource/internet/webkit_sptlib_agree.html">WebKit Support Libraries</a> to the root of your source tree (<tt>C:\cygwin\home\&lt;username&gt;\WebKit</tt>).</p>
    46 <p>If the file is incorrectly named, rename it to <tt>WebKitSupportLibrary.zip</tt>. Do not extract its contents.</p>
     45<p>Download the <a href="http://developer.apple.com/opensource/internet/webkit_sptlib_agree.html">WebKit Support Libraries</a> to the root of your source tree (<code>C:\cygwin\home\&lt;username&gt;\WebKit</code>).</p>
     46<p>If the file is incorrectly named, rename it to <code>WebKitSupportLibrary.zip</code>. Do not extract its contents.</p>
    4747</ol>
    4848</div>
    4949
    5050<ol>
    51 <li><p>Run the <tt>update-webkit</tt> <a href="/coding/scripts.html">script</a>
     51<li><p>Run the <code>update-webkit</code> <a href="/coding/scripts.html">script</a>
    5252to update your source tree.</p>
    5353<p>If you downloaded the tarball, this will bring it up to date.  Windows users
     
    6060
    6161<h2>Keeping up to Date</h2>
    62 <p>At any time, you can rerun the <tt>update-webkit</tt> script to update
     62<p>At any time, you can rerun the <code>update-webkit</code> script to update
    6363your source tree.</p>
    6464
  • trunk/WebKitSite/building/debug.html

    r55170 r56300  
    1111</li>
    1212<li><p>Set the project's build products location</p>
    13 <p>To find the WebKit you built, Xcode needs to know the build products location that <tt>build-webkit</tt> used. You can set the build products location from the project's Info window.</p>
     13<p>To find the WebKit you built, Xcode needs to know the build products location that <code>build-webkit</code> used. You can set the build products location from the project's Info window.</p>
    1414<img src="info-tab.png">
    1515</li>
     
    4040<p>To launch Safari in the Visual Studio or Visual C++ Express debugger, simply run:</p>
    4141<p class="code">debug-safari</p>
    42 <p>This command will launch the Visual Studio debugging environment, and attach to Safari connected to the debug build of WebKit.dll.  There are a few things to keep in mind:
     42<p>This command will launch the Visual Studio debugging environment, and attach to Safari connected to the debug build of WebKit.dll.  There are a few things to keep in mind:</p>
    4343<ul>
    4444<li>The instance of Safari is not running yet.  You must press the F5 key (or the 'Run' button) to see anything happen.</li>
     
    4848<p>You should consider including the command-line switch '<span class="code">/console</span>'.  This causes Safari to run with an open DOS shell in which output messages, created with the <span class="code">LOG</span> macro, appear.</p>
    4949<img src="console_vs2005.jpg"></li>
    50 </ul></p>
    51 <p>Alternatively, you can build, run, and debug WebKit from inside Visual Studio by opening the solution file:
     50</ul>
     51<p>Alternatively, you can build, run, and debug WebKit from inside Visual Studio by opening the solution file:</p>
    5252<ol>
    5353<li>Launch Visual Studio.</li>
     
    5757<li>To build, select the 'Build' menu, then 'Build Solution'. To run, select the 'Debug' menu, then 'Start Debugging'.</li>
    5858</ol>
    59 </p>
    6059<p>It is also recommended that you follow <a href="http://developer.apple.com/internet/safari/windows_symbols_agree.html">the instructions to configure Visual Studio to use Apple's Safari for Windows symbol server</a>. This will give Visual Studio the information it needs to provide reliable backtraces when pausing in the debugger or when a crash occurs.</p>
    6160</div>
  • trunk/WebKitSite/building/run.html

    r51733 r56300  
    66<h2>Running WebKit</h2>
    77<ol>
    8 <li><p>Execute the <tt>run-safari</tt> <a href="/coding/scripts.html">script</a>
     8<li><p>Execute the <code>run-safari</code> <a href="/coding/scripts.html">script</a>
    99to run Safari with the WebKit version you <a href="build.html">built</a>.</p>
    10 <p>Use the <tt>--debug</tt> option for a debug build:</p>
     10<p>Use the <code>--debug</code> option for a debug build:</p>
    1111<p class="code">run-safari --debug</p>
    1212</li>
     
    1515<div class="mac-instructions">
    1616<h4>Mac OS X</h4>
    17 <p>The <tt>run-safari</tt> script sets the <tt>DYLD_FRAMEWORK_PATH</tt> environment variable to point to your build products,
    18 and then launches /Applications/Safari.app. <tt>DYLD_FRAMEWORK_PATH</tt> tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks.</p>
     17<p>The <code>run-safari</code> script sets the <code>DYLD_FRAMEWORK_PATH</code> environment variable to point to your build products,
     18and then launches /Applications/Safari.app. <code>DYLD_FRAMEWORK_PATH</code> tells the system loader to prefer your build products over the frameworks installed in /System/Library/Frameworks.</p>
    1919</div>
    2020
    2121<div class="windows-instructions">
    2222<h4>Windows</h4>
    23 <p>The <tt>run-safari</tt> script launches the Safari executable with the <tt>/frameworkPath</tt> command line switch set to point to your build products.  The <tt>/debug</tt> command line switch will be set if you pass --debug to <tt>run-safari.</tt></p>
     23<p>The <code>run-safari</code> script launches the Safari executable with the <code>/frameworkPath</code> command line switch set to point to your build products.  The <code>/debug</code> command line switch will be set if you pass --debug to <code>run-safari.</code></p>
    2424</div>
    2525
  • trunk/WebKitSite/building/tools.html

    r51723 r56300  
    1818<ol>
    1919<li><p>If you own Visual Studio 2005 (newer versions of Visual Studio are currently unsupported):</p>
    20 <p>Install <a target="installtools" href="http://www.microsoft.com/downloads/details.aspx?familyid=BB4A75AB-E2D4-4C96-B39D-37BAF6B5B1DC&displaylang=en">Microsoft Visual Studio 2005 Team Suite Service Pack 1</a>.</p>
    21 <p>If you are building from Vista, install <a target="installtools" href="http://www.microsoft.com/downloads/details.aspx?FamilyID=90e2942d-3ad1-4873-a2ee-4acc0aace5b6&displaylang=en">Service Pack 1 Update for Windows Vista</a>.</p>
    22 <p>Install <a target="installtools" href="http://www.microsoft.com/downloads/details.aspx?FamilyID=7c8729dc-06a2-4538-a90d-ff9464dc0197&displaylang=en">Visual Studio 2005 Service Pack 1 ATL Security Update</a>.</p>
    23 <p>Install the following hotfixes to improve Visual Studio's performance and responsiveness:
     20<p>Install <a target="installtools" href="http://www.microsoft.com/downloads/details.aspx?familyid=BB4A75AB-E2D4-4C96-B39D-37BAF6B5B1DC&amp;displaylang=en">Microsoft Visual Studio 2005 Team Suite Service Pack 1</a>.</p>
     21<p>If you are building from Vista, install <a target="installtools" href="http://www.microsoft.com/downloads/details.aspx?FamilyID=90e2942d-3ad1-4873-a2ee-4acc0aace5b6&amp;displaylang=en">Service Pack 1 Update for Windows Vista</a>.</p>
     22<p>Install <a target="installtools" href="http://www.microsoft.com/downloads/details.aspx?FamilyID=7c8729dc-06a2-4538-a90d-ff9464dc0197&amp;displaylang=en">Visual Studio 2005 Service Pack 1 ATL Security Update</a>.</p>
     23<p>Install the following hotfixes to improve Visual Studio's performance and responsiveness:</p>
    2424<ol>
    2525<li><a target="installtools" href="http://code.msdn.microsoft.com/KB918559">KB918559</a></li>
     
    2828<li><a target="installtools" href="http://code.msdn.microsoft.com/KB947315">KB947315</a></li>
    2929</ol>
    30 </p>
    3130<p>Use the default options for these installations.</p>
    3231<li><p>If not, you can use Visual C++ Express 2005 (newer versions of Visual C++ Express Edition are currently unsupported):</p>
    3332<p>Install <a target="installtools" href="http://go.microsoft.com/fwlink/?LinkId=51410">Visual C++ 2005 Express</a>.</p>
    3433<p>Install <a target="installtools" href="http://download.microsoft.com/download/7/7/3/7737290f-98e8-45bf-9075-85cc6ae34bf1/VS80sp1-KB926748-X86-INTL.exe">Microsoft Visual C++ Express 2005 Service Pack 1</a>.</p>
    35 <p>If you are building from Vista, install <a target="installtools" href="http://www.microsoft.com/downloads/details.aspx?FamilyID=90e2942d-3ad1-4873-a2ee-4acc0aace5b6&displaylang=en">Service Pack 1 Update for Windows Vista</a>.</p>
    36 <p>Install <a target="installtools" href="http://www.microsoft.com/downloads/details.aspx?FamilyID=7c8729dc-06a2-4538-a90d-ff9464dc0197&displaylang=en">Visual Studio 2005 Service Pack 1 ATL Security Update</a>.</p>
    37 <p>Install the <a target="installtools" href="http://www.microsoft.com/downloads/details.aspx?familyid=0baf2b35-c656-4969-ace8-e4c0c0716adb&displaylang=en">Windows Server 2003 R2 Platform SDK</a>, then follow steps 2 and 3 of &ldquo;<a target="installtools" href="http://msdn.microsoft.com/en-us/library/ms235626(VS.80).aspx">How to: Use Visual C++ Express Edition with the Microsoft Platform SDK</a>.&rdquo;</p>
     34<p>If you are building from Vista, install <a target="installtools" href="http://www.microsoft.com/downloads/details.aspx?FamilyID=90e2942d-3ad1-4873-a2ee-4acc0aace5b6&amp;displaylang=en">Service Pack 1 Update for Windows Vista</a>.</p>
     35<p>Install <a target="installtools" href="http://www.microsoft.com/downloads/details.aspx?FamilyID=7c8729dc-06a2-4538-a90d-ff9464dc0197&amp;displaylang=en">Visual Studio 2005 Service Pack 1 ATL Security Update</a>.</p>
     36<p>Install the <a target="installtools" href="http://www.microsoft.com/downloads/details.aspx?familyid=0baf2b35-c656-4969-ace8-e4c0c0716adb&amp;displaylang=en">Windows Server 2003 R2 Platform SDK</a>, then follow steps 2 and 3 of &ldquo;<a target="installtools" href="http://msdn.microsoft.com/en-us/library/ms235626(VS.80).aspx">How to: Use Visual C++ Express Edition with the Microsoft Platform SDK</a>.&rdquo;</p>
    3837<p>Use the default options for all installations.</p>
    3938<p>In addition to the paths specified in step 3 of the Platform SDK installation instructions, you must also add the following include path. Update the Visual C++ directories in the Projects and Solutions section in the Options dialog box:</p>
     
    4746<p>Download <a
    4847href="http://svn.webkit.org/repository/webkit/trunk/WebKitTools/CygwinDownloader/cygwin-downloader.zip">cygwin-downloader.zip</a>.</p>
    49 <p>Right-click <tt>cygwin-downloader.zip</tt> and choose <b>Extract All...</b>.
     48<p>Right-click <code>cygwin-downloader.zip</code> and choose <b>Extract All...</b>.
    5049Keep all the default options and click <b>Next</b> until the file is extracted and the cygwin-downloader folder opens.</p>
    51 <p>Double-click <tt>cygwin-downloader.exe</tt>. This will download all the Cygwin packages you need.</p>
     50<p>Double-click <code>cygwin-downloader.exe</code>. This will download all the Cygwin packages you need.</p>
    5251<p>When all the packages have finished downloading, the Cygwin installer will launch. Choose <b>Install from Local Directory</b>, then click <b>Next</b> until the install is complete. If you are running Vista, the installer won't be able to launch automatically, so you will have to manually launch Cygwin's Setup.exe.</p>
    5352<P>Vista may warn you that Cygwin did not install correctly. Ignore this warning and tell Vista that the install was successful.</p>
  • trunk/WebKitSite/coding/coding-style.html

    r54258 r56300  
    186186<h4 class="right">Right:</h4>
    187187<pre class="code">
    188 for (int i = 0; i < 10; i++)
     188for (int i = 0; i &lt; 10; i++)
    189189    doSomething();
    190190
     
    194194<h4 class="wrong">Wrong:</h4>
    195195<pre class="code">
    196 for (int i = 0 ; i < 10 ; i++)
     196for (int i = 0 ; i &lt; 10 ; i++)
    197197    doSomething();
    198198
  • trunk/WebKitSite/coding/contributing.html

    r53782 r56300  
    3030    <li><a href="#writecode">Develop</a> your changes.</li>
    3131    <li>Make sure your changes meet the <a href="/coding/coding-style.html">code
    32         style guidelines</a>. The <tt>check-webkit-style</tt> script may be of
     32        style guidelines</a>. The <code>check-webkit-style</code> script may be of
    3333        help.</li>
    34     <li>Run the layout tests using the <tt>run-webkit-tests</tt> script and make sure they all pass.
     34    <li>Run the layout tests using the <code>run-webkit-tests</code> script and make sure they all pass.
    3535        See the <a href="/quality/testwriting.html">testing page</a> for more information, as well as what you need to do if you've modified JavaScriptCore.</li>
    3636    <li>Add any <a href="#newfiles">new files</a> to your working directory.</li>
    37     <li>Prepare a change log entry. You may have to add entries to multiple ChangeLogs. The <tt>prepare-ChangeLog</tt> script will create stub entries for you.  See the <a href="#changelogs">paragraph about ChangeLogs</a> below.</li>
    38     <li>Create the patch using the <tt>svn-create-patch</tt> script.</li>
     37    <li>Prepare a change log entry. You may have to add entries to multiple ChangeLogs. The <code>prepare-ChangeLog</code> script will create stub entries for you.  See the <a href="#changelogs">paragraph about ChangeLogs</a> below.</li>
     38    <li>Create the patch using the <code>svn-create-patch</code> script.</li>
    3939    <li><a href="#submit">Submit</a> your patch for review to
    4040        <a href="https://bugs.webkit.org/">bugs.webkit.org</a>.</li>
     
    7373and a company:
    7474
    75 <p><tt>Copyright (C) 2010 John Smith (jsmith@example.com)</tt></p>
    76 <p><tt>Copyright (C) 2010 Company Inc. All rights reserved.</tt></p>
     75<p><code>Copyright (C) 2010 John Smith (jsmith@example.com)</code></p>
     76<p><code>Copyright (C) 2010 Company Inc. All rights reserved.</code></p>
    7777
    7878<p>In addition, make sure that any new source code and script files
     
    9393
    9494<h3>Regression tests</h3>
    95 <p>Once you have made your changes, you need to run the regression tests, which is done via the <tt>run-webkit-tests</tt> script.
     95<p>Once you have made your changes, you need to run the regression tests, which is done via the <code>run-webkit-tests</code> script.
    9696All tests must pass.  Patches will not be landed in the tree if they break existing layout tests.</p>
    9797
     
    107107<h3 id="newfiles">Add new files to your working directory</h3>
    108108<p>If your changes include adding new files (like new layout tests),
    109 use the <tt>svn add</tt> command to mark these files for addition to the
     109use the <code>svn add</code> command to mark these files for addition to the
    110110repository. If you do not do this, the new files will be missing from
    111111the patch file you generate below.</p>
    112112
    113 <p>You can learn more about Subversion commands like <tt>svn add</tt>
     113<p>You can learn more about Subversion commands like <code>svn add</code>
    114114from the online book <a class="book" href="http://svnbook.red-bean.com/">
    115 Version Control with Subversion</a> and by using the <tt>svn help</tt>
     115Version Control with Subversion</a> and by using the <code>svn help</code>
    116116command.</p>
    117117
    118118<h3 id="changelogs">ChangeLog files</h3>
    119 <p>ChangeLogs are simple text files which provide historical documentation for all changes to the WebKit project.  All patches require an entry to the ChangeLog. The <tt>prepare-ChangeLog</tt> script will create a basic entry containing a list of all files that have been changed.  The first line contains the date, your full name, and your email address.  Use this to write up a brief summary of the changes you've made.  Don't worry about the "Reviewed by NOBODY (OOPS!)" line, the person landing your patch will fill this in.</p>
     119<p>ChangeLogs are simple text files which provide historical documentation for all changes to the WebKit project.  All patches require an entry to the ChangeLog. The <code>prepare-ChangeLog</code> script will create a basic entry containing a list of all files that have been changed.  The first line contains the date, your full name, and your email address.  Use this to write up a brief summary of the changes you've made.  Don't worry about the "Reviewed by NOBODY (OOPS!)" line, the person landing your patch will fill this in.</p>
    120120
    121 <p>There is one ChangeLog per top-level directory, if you changed code and tests you will need to edit at least two ChangeLogs. The <tt>prepare-ChangeLog</tt> script will create a stub entries for you.  You should edit these stubs to describe your change, including the full url to the bug (<a href="http://trac.webkit.org/changeset/43259">example entry</a>, note that you can use <tt>--bug</tt> flag).  (You should set EMAIL_ADDRESS and CHANGE_LOG_NAME in your environment if you will be running this script frequently.)</p>
     121<p>There is one ChangeLog per top-level directory, if you changed code and tests you will need to edit at least two ChangeLogs. The <code>prepare-ChangeLog</code> script will create a stub entries for you.  You should edit these stubs to describe your change, including the full url to the bug (<a href="http://trac.webkit.org/changeset/43259">example entry</a>, note that you can use <code>--bug</code> flag).  (You should set EMAIL_ADDRESS and CHANGE_LOG_NAME in your environment if you will be running this script frequently.)</p>
    122122
    123123<p>The line WARNING: NO TEST CASES ADDED OR CHANGED appears if prepare-ChangeLog did not detect the addition of test cases.  If your patch does not require test cases (or test cases are not possible), you should include a line stating such.  Otherwise all changes require test cases which should be mentioned in the ChangeLog.</p>
    124124
    125125<h3>Create the patch</h3>
    126 <p>WebKit uses <tt>svn-create-patch</tt> to create patches. The
    127 <tt>svn-create-patch</tt> script is a small wrapper around Subversion's
    128 <tt>diff</tt> command that better handles moved, added, and deleted files.
     126<p>WebKit uses <code>svn-create-patch</code> to create patches. The
     127<code>svn-create-patch</code> script is a small wrapper around Subversion's
     128<code>diff</code> command that better handles moved, added, and deleted files.
    129129This command is best run from the top level of your checkout
    130130to make sure no changes are left out of your patch. It is not necessary to
    131131break a patch into multiple files.</p>
    132132
    133 <p>The <tt>svn-create-patch</tt> script does not create a file automatically.
     133<p>The <code>svn-create-patch</code> script does not create a file automatically.
    134134You need to redirect the output yourself using something like--</p>
    135135<p class="code">svn-create-patch > MyExcellentPatch.txt</p>
     
    157157alt="Bugzilla patch-submission options"></p>
    158158
    159 <p>The patch checkbox and the <tt>review:?</tt> flag signal to
     159<p>The patch checkbox and the <code>review:?</code> flag signal to
    160160WebKit reviewers that your patch is ready for review.
    161161Setting the review flag also sends an automatic e-mail to the
     
    168168it into the source control repository.
    169169A reviewer will typically either approve your patch
    170 (by responding with an <tt>r=me</tt> in the bug report and marking the patch <tt>review:+</tt>) or request revisions
    171 to your patch (and mark the patch <tt>review:-</tt>). In rare cases a patch may be permanently rejected, meaning that the reviewer
     170(by responding with an <code>r=me</code> in the bug report and marking the patch <code>review:+</code>) or request revisions
     171to your patch (and mark the patch <code>review:-</code>). In rare cases a patch may be permanently rejected, meaning that the reviewer
    172172believes the feature should never be committed to the tree. The review process can consist of multiple iterations between you and
    173173the reviewer as you submit revised patches.</p>
     
    182182
    183183<h4 id="commitqueue">Optional: Use of the WebKit Commit Bot</h4>
    184 <p>WebKit provides an automated system (commit-queue) for landing patches for any who would like to use it.  To use the commit-queue, set the <tt>commit-queue:?</tt> flag on your patch.  A committer will set <tt>commit-queue:+</tt> and an automated process will download, build, run the layout tests, and submit your patch on your behalf.  If the <a href="http://build.webkit.org/">WebKit buildbots</a> are passing, your patch should be landed within 15 minutes after <tt>commit-queue:+</tt> is set. See the <a href="https://trac.webkit.org/wiki/CommitQueue">commit-queue documentation</a> for more information.</p>
     184<p>WebKit provides an automated system (commit-queue) for landing patches for any who would like to use it.  To use the commit-queue, set the <code>commit-queue:?</code> flag on your patch.  A committer will set <code>commit-queue:+</code> and an automated process will download, build, run the layout tests, and submit your patch on your behalf.  If the <a href="http://build.webkit.org/">WebKit buildbots</a> are passing, your patch should be landed within 15 minutes after <code>commit-queue:+</code> is set. See the <a href="https://trac.webkit.org/wiki/CommitQueue">commit-queue documentation</a> for more information.</p>
    185185
    186186<h2>Obtaining Commit and Review Privileges</h2>
  • trunk/WebKitSite/coding/major-objects.html

    r47584 r56300  
    33    include("../header.inc");
    44?>
    5 
    6 <style type="text/css">
    7     .asciiart {
    8         background-color: #eee;
    9         padding: 1em;
    10         margin-left: 2em;
    11         margin-right: 2em;
    12         overflow-x: auto;
    13     }
    14 </style>
    155
    166<h1>Major Objects in WebCore</h1>
     
    4333  /     |      \/  Replaced after navigation  \/        |
    4434 /      |                                               |
    45 /<------|<-- Ptrs to Frame are null after navigation[1] |
     35/&lt;------|&lt;-- Ptrs to Frame are null after navigation[1] |
    4636|       |                                               |
    4737| +-----+-----+         +-------------+                 |
    48 | | DOMWindow |<--impl--+ JSDOMWindow |<------window----+
     38| | DOMWindow |&lt;--impl--+ JSDOMWindow |&lt;------window----+
    4939| +-----+-----+         +-------------+
    5040|       |
    51 |       |<-- Can be null for Documents created by XMLHttpRequest
     41|       |&lt;-- Can be null for Documents created by XMLHttpRequest
    5242|       |
    5343| +-----+-----+         +-------------+
    54 +-+ Document  |<--impl--+ JSDocument  |
     44+-+ Document  |&lt;--impl--+ JSDocument  |
    5545  +-----+-----+         +-------------+
    5646        |
    57         |<-- Can be null for DocumentType objects
     47        |&lt;-- Can be null for DocumentType objects
    5848        |
    5949    +---+---+           +--------+
    60     | Node  |<---impl---| JSNode |
     50    | Node  |&lt;---impl---| JSNode |
    6151    +-------+           +--------+
    6252</pre>
  • trunk/WebKitSite/css/main.css

    r53782 r56300  
    206206    margin: 1em 0;
    207207}
     208
     209.asciiart {
     210    background-color: #eee;
     211    padding: 1em;
     212    margin-left: 2em;
     213    margin-right: 2em;
     214    overflow-x: auto;
     215}
  • trunk/WebKitSite/demos/index.html

    r45221 r56300  
    1818<a href="editingToolbar"><h2>Editing Toolbar</h2></a>
    1919<span class="datestamp">Added November 4th, 2007</span>
    20 <p>The editing toolbar shows off a rich HTML editing toolbar in WebKit.  It uses JavaScript and CSS to fade in and out and to implement the buttons that apply text formating and alignment. Click in the text area to see the toolbar appear.
     20<p>The editing toolbar shows off a rich HTML editing toolbar in WebKit.  It uses JavaScript and CSS to fade in and out and to implement the buttons that apply text formating and alignment. Click in the text area to see the toolbar appear.</p>
    2121
    2222<a href="sticky-notes"><h2>Sticky Notes</h2></a>
  • trunk/WebKitSite/header.inc

    r56299 r56300  
    22<html>
    33<head>
    4     <meta http-equiv="Content-Type" content="text/html;charset=utf-8">
     4    <meta charset="utf-8">
    55    <meta name="robots" content="noodp">
    66
     
    2020<![endif]-->
    2121
    22     <script type="text/javascript">
     22    <script>
    2323        pic1 = new Image(8,9);
    2424        pic1.src="/images/green-bullet.png";
  • trunk/WebKitSite/projects/compat/index.html

    r30968 r56300  
    3939can track the issue and screen the bug.</dd>
    4040<dt>Reduce Bugs</dt>
    41 <dd>Scan the bugs in the <tt>New Bugs</tt> component and help attach reductions and minimal failing test cases.  Only when bugs are
     41<dd>Scan the bugs in the <code>New Bugs</code> component and help attach reductions and minimal failing test cases.  Only when bugs are
    4242screened properly will a developer be able to determine the root cause of the problem and move it into the appropriate component.
    4343<i>This is one of the most important ways you can help improve WebKit.</i>
  • trunk/WebKitSite/projects/css/index.html

    r39756 r56300  
    2424
    2525<dt>Finish CSS2.1 Support</dt>
    26 <dd>Most of CSS2.1 has been implemented in WebKit, but a few holes remain.  The new white-space values <tt>pre-wrap</tt> and <tt>pre-line</tt> are not yet
     26<dd>Most of CSS2.1 has been implemented in WebKit, but a few holes remain.  The new white-space values <code>pre-wrap</code> and <code>pre-line</code> are not yet
    2727supported.  Some of these features have been implemented in the current KHTML tree, and a merge may be possible for
    2828some of these features.
  • trunk/WebKitSite/projects/documentation/index.html

    r38753 r56300  
    2727
    2828<dt>Existing Documentation</dt>
    29 <dd><a href="http://developer.apple.com/documentation/Cocoa/Conceptual/DisplayWebContent/DisplayWebContent.html" />Introduction to WebKit Objective-C Programming Guide</a></dd>
     29<dd><a href="http://developer.apple.com/documentation/Cocoa/Conceptual/DisplayWebContent/DisplayWebContent.html">Introduction to WebKit Objective-C Programming Guide</a></dd>
    3030<dd>[TODO: Add links to other existing Apple docs]</dd>
    3131
  • trunk/WebKitSite/projects/goals.html

    r24639 r56300  
    4242<dt>Hackability</dt>
    4343<dd>To make rapid progress possible, we try to keep the code relatively easy to understand, even though web technologies are often complex. We try to use straightforward algorithms and data structures when possible, we try to write clear, maintainable code, and we continue to improve names and code structure to aid understanding. When tricky "rocket science" code is truly needed to solve some problem, we try to keep it bottled up behind clean interfaces. In addition, we make heavy use of automated regression tests as a safety net, to allow aggressive changes with less risk of regressions.</dd>
    44 
     44</dl>
    4545
    4646<h3>Non-Goals</h3>
  • trunk/WebKitSite/projects/index.html

    r16495 r56300  
    5050
    5151<dt><a href="editing/index.html">HTML Editing</a>
    52 <dd>The HTML editing project provides rich text editing capabilities both as WebKit API for applications and through support of <tt>contentEditable</tt>
    53 and <tt>designMode</tt> for use in Web pages.
     52<dd>The HTML editing project provides rich text editing capabilities both as WebKit API for applications and through support of <code>contentEditable</code>
     53and <code>designMode</code> for use in Web pages.
    5454
    5555<dt><a href="forms/index.html">HTML Forms</a>
  • trunk/WebKitSite/projects/mathml/index.html

    r48843 r56300  
    1818
    1919<h3>Get Involved!</h3>
    20 <p><a href="../../contact.html">Come find us</a> on <tt>#webkit</tt> to get involved.</p>
     20<p><a href="../../contact.html">Come find us</a> on <code>#webkit</code> to get involved.</p>
    2121
    2222<?php
  • trunk/WebKitSite/quality/bugpriorities.html

    r39756 r56300  
    88The relevant bugs are all of those whose product is "WebKit".</p>
    99
    10     <a name="standardrules"></a><h3>Standard priority rules</h3>
     10    <a id="standardrules"></a><h3>Standard priority rules</h3>
    1111    <p>Each bug is assigned the first appropriate priority listed below
    1212        from top to bottom.</p>
     
    4747    </ul>
    4848
    49     <a name="commonadjustments"></a><h3>Common adjustments to priority</h3>
     49    <a id="commonadjustments"></a><h3>Common adjustments to priority</h3>
    5050    <ul>
    5151        <li>If there is a workaround, the priority may be moved down.</li>
  • trunk/WebKitSite/quality/bugwriting.html

    r48226 r56300  
    1515    </p>
    1616    <p>
    17     Versions of WebKit that are not part of a Safari release have a <tt>+</tt> after the version number, and their version number
    18     is generally higher then the latest released version of WebKit. So, for example, <tt>528+</tt> is an unofficial build of WebKit
    19     that is newer than the <tt>525.x</tt> version that shipped as part of Safari 3.1.2.
     17    Versions of WebKit that are not part of a Safari release have a <code>+</code> after the version number, and their version number
     18    is generally higher then the latest released version of WebKit. So, for example, <code>528+</code> is an unofficial build of WebKit
     19    that is newer than the <code>525.x</code> version that shipped as part of Safari 3.1.2.
    2020    </p>
    2121    <div style="display: none; text-align: center; font-weight: bold;" id="webkit_version"></div>
     
    3636    <li><b>Component</b>
    3737        <p>If you know the precise cause of a bug (i.e., you've reduced it to a failing test case and know the reason), then you can
    38         assign a bug to a specific component such as <tt>CSS</tt> or <tt>HTML Editing</tt>.
    39         <p>If, however, there is any doubt in your mind as to the cause of the bug, then file it under <tt>New Bugs</tt>.  This component
     38        assign a bug to a specific component such as <code>CSS</code> or <code>HTML Editing</code>.
     39        <p>If, however, there is any doubt in your mind as to the cause of the bug, then file it under <code>New Bugs</code>.  This component
    4040        is the place for any bugs whose cause has not yet been determined.  Once someone has reduced the bug and knows the cause, then it
    41         will be moved from the <tt>New Bugs</tt> component to the appropriate place.</p>
     41        will be moved from the <code>New Bugs</code> component to the appropriate place.</p>
    4242    </li>
    4343
     
    4545        <b>Platform and OS</b>
    4646        <p>Please select the platform and the OS version that your bug occurred on.  If you're running on Mac OS X this would often be platform
    47         <tt>Macintosh</tt> and OS <tt>Mac OS X 10.5</tt> (Leopard).  If you're running on Windows or Linux, please select <tt>PC</tt> for platform
     47        <code>Macintosh</code> and OS <code>Mac OS X 10.5</code> (Leopard).  If you're running on Windows or Linux, please select <code>PC</code> for platform
    4848        and the appropriate entry from the OS field.  If your exact system is not listed, please select the closest entry and provide further
    4949        details in the description of the bug report.
     
    5959    <li>
    6060        <b>Severity</b>
    61         <p>In most cases you should leave this at <tt>normal</tt>, but if you are confident that your bug is <tt>trivial</tt> or an
    62         <tt>enhancement</tt>, it's helpful to specify that value. A QA person or developer will set this to some other value if
     61        <p>In most cases you should leave this at <code>normal</code>, but if you are confident that your bug is <code>trivial</code> or an
     62        <code>enhancement</code>, it's helpful to specify that value. A QA person or developer will set this to some other value if
    6363        appropriate.</p>
    6464    </li>
     
    8080        <li>If you have tested and verified that this is a regression from a previous version of WebKit, prepend "REGRESSION: " to the summary
    8181        <li>If you know the range of revisions in which the regression occurred, add this to the summary after REGRESSION (i.e., "REGRESSION(r31201-r31211):")
    82     </ul>
    83     </li><br>
     82    </ul><br>
     83    </li>
    8484
    8585    <li><b>Description</b>
     
    9898        <li>Be as specific as possible. For instance, if you're describing a problem that occurs while scrolling, note in the bug whether you're scrolling with arrow
    9999            keys, arrow buttons, scroll thumb, clicking above or below the thumb, scroll-wheel mouse, etc.</li>
    100     </ul></li><br>
     100    </ul><br></li>
    101101
    102102    <li><b>Keywords</b>
  • trunk/WebKitSite/quality/crashlogs.html

    r31078 r56300  
    2121        </li>
    2222        <li>
    23             <p>If the crash report dialog does not appear or the crash is hard to reproduce, crash logs can be retrieved from the <tt>~/Library/Logs/CrashReporter</tt> folder.</p>
     23            <p>If the crash report dialog does not appear or the crash is hard to reproduce, crash logs can be retrieved from the <code>~/Library/Logs/CrashReporter</code>> folder.</p>
    2424            <p>On Leopard (Mac OS X 10.5), crash logs are stored as individually dated and time stamped files. Despite having a &ldquo;.crash&rdquo;
    2525                extension, they are plain text files and can be attached directly to a bug report.</p>
    26             <p>On Tiger (Mac OS X 10.4), all crashes are logged to <tt>Safari.crash.log</tt>. This is a plain text file and can
     26            <p>On Tiger (Mac OS X 10.4), all crashes are logged to <code>Safari.crash.log</code>>. This is a plain text file and can
    2727                be viewed in the default Console.app or your favorite text editor. <strong>All</strong> of Safari's crashes are logged
    2828                to this file so please only attach the last crash in it. Crashes are separated by a series of asterisks
     
    3838    <ol>
    3939        <li>
    40             <p>In the Start menu's Run box or from a DOS or Cygwin prompt, enter the command <tt>drwtsn32 -i</tt>.</p>
     40            <p>In the Start menu's Run box or from a DOS or Cygwin prompt, enter the command <code>drwtsn32 -i</code>>.</p>
    4141            <img src="win_installwatson.jpg" alt="Dr Watson install command">
    4242        </li>
     
    4646        </li>
    4747        <li>
    48             <p>Crash information will now be logged to the <tt>user.dmp</tt> file in
    49             <tt>C:\Documents and Settings\All Users\Application Data\Microsoft\Dr Watson\</tt>.</p>
     48            <p>Crash information will now be logged to the <code>user.dmp</code>> file in
     49            <code>C:\Documents and Settings\All Users\Application Data\Microsoft\Dr Watson\</code>>.</p>
    5050
    51             <p>Dr. Watson will create a <tt>user.dmp</tt> file that records what WebKit was doing when it crashed.
     51            <p>Dr. Watson will create a <code>user.dmp</code>> file that records what WebKit was doing when it crashed.
    5252                Be careful as it is overwritten with every crash.</p>
    5353
    54             <p>When reporting a WebKit bug, please upload the <tt>user.dmp</tt> file if possible.</p>
     54            <p>When reporting a WebKit bug, please upload the <code>user.dmp</code>> file if possible.</p>
    5555        </li>
    5656        <li>
    57             <p>Running <tt>drwtsn32</tt> without any options or switches will bring up a window that allows you to change various
     57            <p>Running <code>drwtsn32</code>> without any options or switches will bring up a window that allows you to change various
    5858                setting such as moving the log folder to a more easily accessible location or throwing a visual alert letting
    5959                you know it caught the crash.</p>
     
    6666    <ol>
    6767        <li>
    68             <p>Save the following text to a file named <tt>wer.reg</tt>:</p><tt style="white-space:pre">Windows Registry Editor Version 5.00
     68            <p>Save the following text to a file named <code>wer.reg</code>>:</p><tt style="white-space:pre">Windows Registry Editor Version 5.00
    6969
    7070[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\Windows Error Reporting]
    7171"ForceQueue"=dword:00000001
    72 </tt>
     72</code>>
    7373        </li>
    7474        <li><p>Double-click the file from Windows Explorer and respond affirmatively to any prompts.</p></li>
     
    7676    </ol>
    7777    <p>
    78         The next time Safari (or any other application) crashes, the crash information will be written into a folder located inside <tt>%LOCALAPPDATA%\Microsoft\Windows\WER\ReportQueue</tt>.
     78        The next time Safari (or any other application) crashes, the crash information will be written into a folder located inside <code>%LOCALAPPDATA%\Microsoft\Windows\WER\ReportQueue</code>>.
    7979        Check the modification date to make sure you are using the correct file.
    8080    </p>
    8181    <p>Be sure to include the following files in your bug report:</p>
    8282    <dl style="margin-left:2em">
    83         <dt><tt>WER<em>xxxx</em>.tmp.mdmp</tt></dt>
     83        <dt><code>WER<em>xxxx</em>.tmp.mdmp</code>></dt>
    8484        <dd>This is the most important file. It contains the crash dump that can be opened inside Visual Studio or other Windows debuggers.</dd>
    85         <dt><tt>WER<em>xxxx</em>.tmp.version.txt</tt></dt>
     85        <dt><code>WER<em>xxxx</em>.tmp.version.txt</code>></dt>
    8686        <dd>Contains the operating system version and other hardware information.</dd>
    87         <dt><tt>WER<em>xxxx</em>.tmp.appcompat.txt</tt></dt>
     87        <dt><code>WER<em>xxxx</em>.tmp.appcompat.txt</code>></dt>
    8888        <dd>Lists all of the DLLs loaded at the time of the crash with their version information.</dd>
    8989    </dl>
  • trunk/WebKitSite/quality/lifecycle.html

    r52433 r56300  
    1414<h3>Fresh, Unconfirmed Bugs</h3>
    1515
    16 <p>A freshly-created bug starts out in state <tt>UNCONFIRMED</tt>. Often it is in component <tt>New Bugs</tt>, but
     16<p>A freshly-created bug starts out in state <code>UNCONFIRMED</code>. Often it is in component <code>New Bugs</code>, but
    1717some bugs will be given an initial component in the initial <a href="reporting.html">bug-reporting step</a>.</p>
    1818
    1919
    20 <h3><a name="confirming"></a>Confirming Bugs</h3>
     20<h3><a id="confirming"></a>Confirming Bugs</h3>
    2121
    22 <p>The next step is for someone with Bugzilla <tt>canConfirm</tt> privileges to review the unconfirmed bug and
     22<p>The next step is for someone with Bugzilla <code>canConfirm</code> privileges to review the unconfirmed bug and
    2323decide whether it has enough useful information to move forward. The possible changes to the bug at this step include the following:</p>
    2424
    2525<ul>
    26 <li>Resolution changed to <tt>DUPLICATE</tt> if the bug is determined to have the same cause as a bug reported earlier.</li>
    27 <li>Resolution changed to <tt>WORKSFORME</tt> if the bug seems to not be present in the latest sources.</li>
    28 <li>Resolution changed to <tt>INVALID</tt> if the bug does not describe a problem with WebKit.</li>
    29 <li>Resolution changed to <tt>WONTFIX</tt> in the rare case that the bug seems valid but there's a specific reason why it
     26<li>Resolution changed to <code>DUPLICATE</code> if the bug is determined to have the same cause as a bug reported earlier.</li>
     27<li>Resolution changed to <code>WORKSFORME</code> if the bug seems to not be present in the latest sources.</li>
     28<li>Resolution changed to <code>INVALID</code> if the bug does not describe a problem with WebKit.</li>
     29<li>Resolution changed to <code>WONTFIX</code> in the rare case that the bug seems valid but there's a specific reason why it
    3030should not be fixed in WebKit (usually this would be a cross-browser compatibility issue).</li>
    3131<li>Comments/questions added if the bug does not have enough information to move forward.</li>
    32 <li>Status changed to <tt>NEW</tt> if the bug is reproducible with the latest sources on Mac OS X or otherwise has enough information to move forward.
     32<li>Status changed to <code>NEW</code> if the bug is reproducible with the latest sources on Mac OS X or otherwise has enough information to move forward.
    3333If the bug is not reproducible with the latest sources, but appears to occur only on the platform stated in the platform field,
    34 the <tt>PlatformOnly</tt> keyword is added as well as setting the status to <tt>NEW</tt>.
    35 Along with changing the status, the component should also be set to an appropriate one more specific than <tt>New Bugs</tt> if necessary.</li>
     34the <code>PlatformOnly</code> keyword is added as well as setting the status to <code>NEW</code>.
     35Along with changing the status, the component should also be set to an appropriate one more specific than <code>New Bugs</code> if necessary.</li>
    3636</ul>
    3737
     
    3939
    4040<p>Each bug is initially assigned to the person designated as owner of the component. The assignee should move the bug from status
    41 <tt>NEW</tt> to status <tt>ASSIGNED</tt> after they have read the bug and are satisfied that it represents a real problem in WebKit.
     41<code>NEW</code> to status <code>ASSIGNED</code> after they have read the bug and are satisfied that it represents a real problem in WebKit.
    4242If they are not satisfied about this, they should perform one of the actions mentioned in the <a href="#confirming">Confirming Bugs</a> section above.
    43 The same procedure is followed for bugs with status <tt>REOPENED</tt> (see <a href="#verifying">Verifying Fixes</a> below).</p>
     43The same procedure is followed for bugs with status <code>REOPENED</code> (see <a href="#verifying">Verifying Fixes</a> below).</p>
    4444
    4545<p>The assignee represents the person who is expected to take the next step in investigating or fixing a bug. If someone other than the assignee is
     
    4949<h3>Proposing Fixes</h3>
    5050
    51 <p>A proposed patch should be added as a new attachment. The attachment should have the <tt>patch</tt> checkbox checked, and the <tt>review</tt> flag set to <tt>?</tt>. This
     51<p>A proposed patch should be added as a new attachment. The attachment should have the <code>patch</code> checkbox checked, and the <code>review</code> flag set to <code>?</code>. This
    5252marks the patch as awaiting review. If the patch requires the specialized knowledge of a particular reviewer, the submitter or another reviewer should put
    53 the requested reviewer's email address in the <tt>Requestee</tt> field. Otherwise this field should be left empty. The state is left at <tt>ASSIGNED</tt> at
    54 this point; it isn't changed to <tt>FIXED</tt> until a fix has been checked into the source tree.</p>
     53the requested reviewer's email address in the <code>Requestee</code> field. Otherwise this field should be left empty. The state is left at <code>ASSIGNED</code> at
     54this point; it isn't changed to <code>FIXED</code> until a fix has been checked into the source tree.</p>
    5555
    5656<p>When the review flag's state is changed, or when a comment is made in the Edit form for an attachment, email is automatically sent to
     
    5858this list, and anyone else is free to do so as well.</p>
    5959
    60 <p>If the submitter of a patch changes their mind about wanting a review, they should clear the <tt>review</tt> flag by choosing the
     60<p>If the submitter of a patch changes their mind about wanting a review, they should clear the <code>review</code> flag by choosing the
    6161blank choice in the review pop-menu.</p>
    6262
     
    6565<h3>Reviewing Proposed Fixes</h3>
    6666
    67 <p>A reviewer will read through each proposed patch. If the patch is ready to commit, the reviewer will change the <tt>review</tt> flag to <tt>+</tt>.
     67<p>A reviewer will read through each proposed patch. If the patch is ready to commit, the reviewer will change the <code>review</code> flag to <code>+</code>.
    6868For clarity, it's helpful for the reviewer to add a comment when approving a patch. Often this comment is just "r=me", which is simply shorthand for
    6969"I have reviewed this patch and it's ready to commit".</p>
     
    7373explain in detail why a patch is not ready to commit, so the submitter or someone else can revise the patch.</p>
    7474
    75 <p>When a submitter proposes an updated patch, they should check the <tt>obsolete</tt> checkbox on the previous version of the patch. This causes it
    76 to appear crossed-out in the list of attachments on the bug's main page. At the same time as marking the old patch <tt>obsolete</tt>, the
    77 submitter should also clear the <tt>review</tt> flag. This would happen automatically in a perfect world, but doesn't currently in this one.</p>
     75<p>When a submitter proposes an updated patch, they should check the <code>obsolete</code> checkbox on the previous version of the patch. This causes it
     76to appear crossed-out in the list of attachments on the bug's main page. At the same time as marking the old patch <code>obsolete</code>, the
     77submitter should also clear the <code>review</code> flag. This would happen automatically in a perfect world, but doesn't currently in this one.</p>
    7878
    7979<h3>Committing Patches</h3>
    8080
    8181<p>After a patch has been approved, someone with commit privileges in the WebKit source repository will commit the patch into the source code repository. The committer
    82 should change the state of the bug to <tt>FIXED</tt>; generally the assignee is left unchanged at this point.</p>
     82should change the state of the bug to <code>FIXED</code>; generally the assignee is left unchanged at this point.</p>
    8383
    8484<p>All of the
     
    9292Software Changed/Integrate.</p>
    9393
    94 <h3><a name="verifying"></a>Verifying Fixes</h3>
     94<h3><a id="verifying"></a>Verifying Fixes</h3>
    9595
    9696<p>After the patch for a bug has been committed, the fix still needs to be verified. Typically this step is done by the person who originally submitted the
    9797bug report. If the submitter is not available or does not feel that they can verify the fix, the verification step can be done by anyone with bug editing
    9898privileges who is familiar enough with the originally reported problem to be confident about
    99 testing it. Note that once a bug is in the <tt>FIXED</tt> state, the assignee can no longer be changed. This means that a bug that needs
     99testing it. Note that once a bug is in the <code>FIXED</code> state, the assignee can no longer be changed. This means that a bug that needs
    100100to be verified will not usually be assigned to the person expected to verify the bug.</p>
    101101
    102102<p>To verify a bug fix, build and run the sources that include the fix, and check whether
    103 the originally reported problem still occurs. If the problem no longer occurs, change the resolution to <tt>VERIFIED</tt>. If the problem does still occur,
    104 change the resolution to <tt>REOPENED</tt> and assign it to the person who submitted the patch.</p>
     103the originally reported problem still occurs. If the problem no longer occurs, change the resolution to <code>VERIFIED</code>. If the problem does still occur,
     104change the resolution to <code>REOPENED</code> and assign it to the person who submitted the patch.</p>
    105105
    106106
    107107<h3>Closing Bugs</h3>
    108108
    109 <p>Fixed bugs have the <tt>VERIFIED</tt> resolution until a version of WebKit that includes the fix has been publicly released. At this point,
    110 the resolution is changed to <tt>CLOSED</tt>.
     109<p>Fixed bugs have the <code>VERIFIED</code> resolution until a version of WebKit that includes the fix has been publicly released. At this point,
     110the resolution is changed to <code>CLOSED</code>.
    111111
    112112<?php
  • trunk/WebKitSite/quality/testing.html

    r51733 r56300  
    99<p>Before patches can land in any of the frameworks in the repository, the
    1010layout regression tests must pass. To run these tests, execute the
    11 <tt>run-webkit-tests</tt> <a href="/coding/scripts.html">script</a>.</p>
     11<code>run-webkit-tests</code> <a href="/coding/scripts.html">script</a>.</p>
    1212
    1313<p>The script will dump the render trees for all of the pages and diff the results against the expected correct results.  If no
     
    3030      <table>
    3131        <tr>
    32           <td valign="top">
     32          <td style="vertical-align: top">
    3333            <ul>
    3434              <li>Arrays</li>
     
    3838            </ul>
    3939          </td>
    40           <td valign="top">
     40          <td style="vertical-align: top">
    4141            <ul>
    4242              <li>Global Object</li>
     
    4646            </ul>
    4747          </td>
    48           <td valign="top">
     48          <td style="vertical-align: top">
    4949            <ul>
    5050              <li>Regular Expressions</li>
     
    6161<h3>How to run the tests</h3>
    6262
    63 <p>Execute the <tt>run-javascriptcore-tests</tt> <a href="/coding/scripts.html">script</a>.
     63<p>Execute the <code>run-javascriptcore-tests</code> <a href="/coding/scripts.html">script</a>.
    6464The script will run all the tests and summarize how the results differ
    6565from what is currently expected.</p>
     
    6767<h3>What just happened</h3>
    6868<p>
    69 After all the test runs have finished the results of tests are saved to <tt>actual.html</tt>.
     69After all the test runs have finished the results of tests are saved to <code>actual.html</code>.
    7070The script the compares these results from your local tree against what is expected to pass/fail from the tip of tree.
    7171If there are any regressions caused by your changes you'll be made aware of them.
     
    8282
    8383<p>It's not the end of the world.  Go back and fix your bug and rerun
    84 <tt>run-javascriptcore-tests</tt> as many times as necessary.</p>
     84<code>run-javascriptcore-tests</code> as many times as necessary.</p>
    8585
    8686<?php
  • trunk/WebKitSite/quality/testwriting.html

    r44604 r56300  
    2121</ol>
    2222
    23 <p>An example of a layout test that follows these guidelines is <tt>fast/events/event-creation.html</tt>.</p>
     23<p>An example of a layout test that follows these guidelines is <code>fast/events/event-creation.html</code>.</p>
    2424
    2525
    2626<p>A layout test should work both in the browser itself, and in the layout test tool. The layout test tool provides an
    2727additional object on the window object called the layout test controller with some methods that control test output.
    28 One you should know about is the <tt>layoutTestController.dumpAsText</tt> method. Calling this from JavaScript within a test arranges
     28One you should know about is the <code>layoutTestController.dumpAsText</code> method. Calling this from JavaScript within a test arranges
    2929for the output to be written out as plain text rather than as a render tree dump.
    3030This is useful for tests that are testing something other than layout. The event creation test mentioned above is a good example of
     
    3333<p>Some tests require pixel-level comparisons.  For these tests, you must generate expected output for a specific
    3434machine type, operating system, and color profile.  When you add such a test, you can generate new expected output
    35 automatically using the <tt>run-webkit-tests --pixel</tt> command.  This will automatically
     35automatically using the <code>run-webkit-tests --pixel</code> command.  This will automatically
    3636configure the color profile, and place the resulting rendered image (and checksum) in the appropriate platform
    3737directory for checkin.</p>
Note: See TracChangeset for help on using the changeset viewer.