Changeset 56374 in webkit

Timestamp:

Mar 22, 2010 7:11:03 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-03-22 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Support creation of fake workers before document is loaded by deferring
attaching of fake workers iframe until document is loaded and buffering all
messages addressed to worker.
​https://bugs.webkit.org/show_bug.cgi?id=36445

• inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.FakeWorker.prototype.postMessage): (InjectedFakeWorker.FakeWorker.prototype._buildWorker): (InjectedFakeWorker.FakeWorker.prototype._attachWorkerFrameToDocument): (InjectedFakeWorker.FakeWorker.prototype._onWorkerFrameLoaded):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/InjectedFakeWorker.js (modified) (3 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-03-22  Andrey Kosyakov  <caseq@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+
+        Support creation of fake workers before document is loaded by deferring
+        attaching of fake workers iframe until document is loaded and buffering all
+        messages addressed to worker.
+        https://bugs.webkit.org/show_bug.cgi?id=36445
+
+        * inspector/front-end/InjectedFakeWorker.js:
+        (InjectedFakeWorker.FakeWorker.prototype.postMessage):
+        (InjectedFakeWorker.FakeWorker.prototype._buildWorker):
+        (InjectedFakeWorker.FakeWorker.prototype._attachWorkerFrameToDocument):
+        (InjectedFakeWorker.FakeWorker.prototype._onWorkerFrameLoaded):
+
 2010-03-22  Darin Fisher  <darin@chromium.org>
 

trunk/WebCore/inspector/front-end/InjectedFakeWorker.js

@@ -60 +60 @@
         if (this._frame != null)
             this._dispatchMessage(this._frame, bind(this._onmessageWrapper, this), msg);
+        else if (this._pendingMessages)
+            this._pendingMessages.push(msg)
+        else
+            this._pendingMessages = [ msg ];
     },
 
@@ -117 +121 @@
         var iframeElement = document.createElement("iframe");
         iframeElement.style.display = "none";
+
+        this._document = document;
+        iframeElement.onload = bind(this._onWorkerFrameLoaded, this, iframeElement, url, code);
+
+        if (document.body)
+            this._attachWorkerFrameToDocument(iframeElement, url, code);
+        else
+            window.addEventListener("load", bind(this._attachWorkerFrameToDocument, this, iframeElement), false);
+    },
+
+    _attachWorkerFrameToDocument: function(iframeElement)
+    {
         document.body.appendChild(iframeElement);
-
-        var frame = window.frames[window.frames.length - 1];
-
-        this._document = document;
+    },
+
+    _onWorkerFrameLoaded: function(iframeElement, url, code)
+    {
+        var frame = iframeElement.contentWindow;
         this._frame = frame;
-
         this._setupWorkerContext(frame, url);
 
@@ -129 +145 @@
 
         frame.eval(frameContents);
+        if (this._pendingMessages) {
+            for (var msg in this._pendingMessages)
+                this.postMessage(this._pendingMessages[msg]);
+            delete this._pendingMessages;
+        }
     },