Changeset 56446 in webkit


Ignore:
Timestamp:
Mar 24, 2010 10:21:58 AM (14 years ago)
Author:
apavlov@chromium.org
Message:

2010-03-24 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Inspector: XML Tags should not be converted to lowercase
​https://bugs.webkit.org/show_bug.cgi?id=28600

LayoutTests:

  • inspector/elements-panel-xhtml-structure-expected.txt:
  • inspector/elements-panel-xhtml-structure.xhtml:

WebCore:

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateBreadcrumb): (WebInspector.ElementsPanel.prototype.decorateNodeLabel):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.nodeNameToCorrectCase): (WebInspector.ElementsTreeElement.prototype._updateChildren): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r56445 r56446  
     12010-03-24  Alexander Pavlov  <apavlov@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Inspector: XML Tags should not be converted to lowercase
     6        https://bugs.webkit.org/show_bug.cgi?id=28600
     7
     8        * inspector/elements-panel-xhtml-structure-expected.txt:
     9        * inspector/elements-panel-xhtml-structure.xhtml:
     10
    1112010-03-03  Kenneth Rohde Christiansen  <kenneth@webkit.org>
    212

  • trunk/LayoutTests/inspector/elements-panel-xhtml-structure-expected.txt

    r55016 r56446  
    66
    77application/xhtml+xml
    8 <html xmlns="http://www.w3.org/1999/xhtml">
    9 <head>…
    10 </head>
     8<HTML xmlns="http://www.w3.org/1999/xhtml">
     9<Head>…
     10</Head>
    1111<body onload="onload()">
    1212<p>"Tests that elements panel shows XML dom tree structure with closing tags for all elements."
    … …  
    2525</div>
    2626</body>
    27 </html>
     27</HTML>
    2828

  • trunk/LayoutTests/inspector/elements-panel-xhtml-structure.xhtml

    r55016 r56446  
    1 <html xmlns="http://www.w3.org/1999/xhtml">
    2 <head>
     1<HTML xmlns="http://www.w3.org/1999/xhtml">
     2<Head>
    33<script src="../http/tests/inspector/inspector-test.js"></script>
    44<script src="elements-tests.js"></script>
    … …  
    103103]]>
    104104</script>
    105 </head>
     105</Head>
    106106
    107107<body onload="onload()">
    … …  
    120120
    121121</body>
    122 </html>
     122</HTML>

  • trunk/WebCore/ChangeLog

    r56445 r56446  
     12010-03-24  Alexander Pavlov  <apavlov@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Inspector: XML Tags should not be converted to lowercase
     6        https://bugs.webkit.org/show_bug.cgi?id=28600
     7
     8        * inspector/front-end/ElementsPanel.js:
     9        (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
     10        (WebInspector.ElementsPanel.prototype.decorateNodeLabel):
     11        * inspector/front-end/ElementsTreeOutline.js:
     12        (WebInspector.ElementsTreeOutline.prototype.nodeNameToCorrectCase):
     13        (WebInspector.ElementsTreeElement.prototype._updateChildren):
     14        (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
     15
    1162010-03-03  Kenneth Rohde Christiansen  <kenneth@webkit.org>
    217

  • trunk/WebCore/inspector/front-end/ElementsPanel.js

    r56395 r56446  
    693693
    694694                default:
    695                     crumbTitle = current.nodeName.toLowerCase();
     695                    crumbTitle = this.treeOutline.nodeNameToCorrectCase(current.nodeName);
    696696            }
    697697
    … …  
    721721    decorateNodeLabel: function(node, parentElement)
    722722    {
    723         var title = node.nodeName.toLowerCase();
     723        var title = this.treeOutline.nodeNameToCorrectCase(node.nodeName);
    724724
    725725        var nameElement = document.createElement("span");

  • trunk/WebCore/inspector/front-end/ElementsTreeOutline.js

    r56049 r56446  
    7070    },
    7171
     72    nodeNameToCorrectCase: function(nodeName)
     73    {
     74        return this.isXMLMimeType ? nodeName : nodeName.toLowerCase();
     75    },
     76
    7277    get focusedDOMNode()
    7378    {
    … …  
    577582        var lastChild = this.children[this.children.length - 1];
    578583        if (this.representedObject.nodeType == Node.ELEMENT_NODE && (!lastChild || !lastChild.elementCloseTag)) {
    579             var title = "<span class=\"webkit-html-tag close\">&lt;/" + this.representedObject.nodeName.toLowerCase().escapeHTML() + "&gt;</span>";
     584            var title = "<span class=\"webkit-html-tag close\">&lt;/" + this.treeOutline.nodeNameToCorrectCase(this.representedObject.nodeName).escapeHTML() + "&gt;</span>";
    580585            var item = new TreeElement(title, null, false);
    581586            item.selectable = false;
    … …  
    10671072
    10681073            case Node.ELEMENT_NODE:
    1069                 var tagName = node.nodeName.toLowerCase().escapeHTML();
     1074                var tagName = this.treeOutline.nodeNameToCorrectCase(node.nodeName).escapeHTML();
    10701075                info.title = "<span class=\"webkit-html-tag\">&lt;" + tagName;
    10711076               
    … …  
    11121117                    info.title = "(whitespace)";
    11131118                else {
    1114                     if (node.parentNode && node.parentNode.nodeName.toLowerCase() == "script") {
     1119                    if (node.parentNode && node.parentNode.nodeName.toLowerCase() === "script") {
    11151120                        var newNode = document.createElement("span");
    11161121                        newNode.textContent = node.textContent;
    … …  
    11181123                        var javascriptSyntaxHighlighter = new WebInspector.DOMSyntaxHighlighter("text/javascript");
    11191124                        javascriptSyntaxHighlighter.syntaxHighlightNode(newNode);
    1120                        
     1125
    11211126                        info.title = "<span class=\"webkit-html-text-node webkit-html-js-node\">" + newNode.innerHTML.replace(/^[\n\r]*/, "").replace(/\s*$/, "") + "</span>";
    1122                     } else if (node.parentNode && node.parentNode.nodeName.toLowerCase() == "style") {
     1127                    } else if (node.parentNode && node.parentNode.nodeName.toLowerCase() === "style") {
    11231128                        var newNode = document.createElement("span");
    11241129                        newNode.textContent = node.textContent;
    1125                        
     1130
    11261131                        var cssSyntaxHighlighter = new WebInspector.DOMSyntaxHighlighter("text/css");
    11271132                        cssSyntaxHighlighter.syntaxHighlightNode(newNode);
    … …  
    11331138                }
    11341139                break;
    1135                
     1140
    11361141            case Node.COMMENT_NODE:
    11371142                info.title = "<span class=\"webkit-html-comment\">&lt;!--" + node.nodeValue.escapeHTML() + "--&gt;</span>";
    11381143                break;
    1139                
     1144
    11401145            case Node.DOCUMENT_TYPE_NODE:
    11411146                info.title = "<span class=\"webkit-html-doctype\">&lt;!DOCTYPE " + node.nodeName;
    … …  
    11511156                break;
    11521157            default:
    1153                 info.title = node.nodeName.toLowerCase().collapseWhitespace().escapeHTML();
    1154         }
    1155        
     1158                info.title = this.treeOutline.nodeNameToCorrectCase(node.nodeName).collapseWhitespace().escapeHTML();
     1159        }
     1160
    11561161        return info;
    11571162    },
    … …  
    11661171        return false;
    11671172    },
    1168    
     1173
    11691174    remove: function()
    11701175    {
Note: See TracChangeset for help on using the changeset viewer.