Changeset 56462 in webkit

Timestamp:

Mar 24, 2010 3:22:41 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-03-24 Eric Uhrhane <​ericu@chromium.org>

DOMCoreException needs NoStaticTables modifier
​https://bugs.webkit.org/show_bug.cgi?id=36458

No new tests, but this shows up in tests of Database accesses from the
Worker thread that I'll be checking in soon. The symptom is that
DOMCoreException.toString() returns [object DOMException] instead of
something more helpful.

• fast/workers/worker-context-multi-port-expected.txt: Adjusted expectation that was depending on the broken behavior.

2010-03-24 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Alexey Proskuryakov.

DOMCoreException needs NoStaticTables modifier
​https://bugs.webkit.org/show_bug.cgi?id=36458

No new tests, but this shows up in tests of Database accesses from the
Worker thread that I'll be checking in soon. The symptom is that
DOMCoreException.toString() returns [object DOMException] instead of
something more helpful.

• dom/DOMCoreException.idl: Added NoStaticTables.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/workers/worker-context-multi-port-expected.txt (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/DOMCoreException.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-03-24  Eric Uhrhane <ericu@chromium.org>
+
+        DOMCoreException needs NoStaticTables modifier
+        https://bugs.webkit.org/show_bug.cgi?id=36458
+
+        No new tests, but this shows up in tests of Database accesses from the
+        Worker thread that I'll be checking in soon.  The symptom is that
+        DOMCoreException.toString() returns [object DOMException] instead of
+        something more helpful.
+
+        * fast/workers/worker-context-multi-port-expected.txt:  Adjusted expectation that was depending on the broken behavior.
+
 2010-03-23  Evan Martin  <evan@chromium.org>
 

trunk/LayoutTests/fast/workers/worker-context-multi-port-expected.txt

@@ -7 +7 @@
 PASS event.ports is null when empty array sent
 PASS event.ports contains two ports when two ports sent
-PASS posting a null port did throw: [object DOMException]
+PASS posting a null port did throw: Error: INVALID_STATE_ERR: DOM Exception 11
 PASS posting a non-port did throw: TypeError: Type error
 PASS event.ports contains two ports when two ports re-sent after error

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-03-24  Eric Uhrhane  <ericu@chromium.org>
+
+        Reviewed by Alexey Proskuryakov.
+
+        DOMCoreException needs NoStaticTables modifier
+        https://bugs.webkit.org/show_bug.cgi?id=36458
+
+        No new tests, but this shows up in tests of Database accesses from the
+        Worker thread that I'll be checking in soon.  The symptom is that
+        DOMCoreException.toString() returns [object DOMException] instead of
+        something more helpful.
+
+        * dom/DOMCoreException.idl:  Added NoStaticTables.
+
 2010-03-24  Drew Wilson  <atwilson@chromium.org>
 

trunk/WebCore/dom/DOMCoreException.idl

@@ -29 +29 @@
 module core {
 
-    interface DOMCoreException {
+    interface [
+        NoStaticTables
+    ] DOMCoreException {
 
         readonly attribute unsigned short   code;