Changeset 56524 in webkit
- Timestamp:
- Mar 25, 2010 2:46:49 AM (14 years ago)
- Location:
- trunk/WebKitTools
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKitTools/ChangeLog
r56522 r56524 1 2010-03-25 Zoltan Horvath <zoltan@webkit.org> 2 3 Reviewed by Eric Seidel. 4 5 svn-create-patch prints a warning for large patches 6 https://bugs.webkit.org/show_bug.cgi?id=32582 7 8 svn-create-patch prints a warning message for larger patches than 20k. 9 10 * Scripts/svn-create-patch: 11 1 12 2010-03-25 Adam Barth <abarth@webkit.org> 2 13 -
trunk/WebKitTools/Scripts/svn-create-patch
r55898 r56524 102 102 my $prefix = chdirReturningRelativePath($svnRoot); 103 103 104 my $patchSize = 0; 105 104 106 # Generate the diffs, in a order chosen for easy reviewing. 105 107 for my $path (sort patchpathcmp values %diffFiles) { 106 generateDiff($path, $prefix); 108 $patchSize += generateDiff($path, $prefix); 109 } 110 111 if ($patchSize > 20480) { 112 print STDERR "WARNING: Patch's size is " . int($patchSize/1024) . " kbytes.\n"; 113 print STDERR "Patches 20k or smaller are more likely to be reviewed. Larger patches may sit unreviewed for a long time.\n"; 107 114 } 108 115 … … 232 239 outputBinaryContent($file); 233 240 } 241 return length($patch); 234 242 } 235 243
Note: See TracChangeset
for help on using the changeset viewer.