Changeset 56524 in webkit


Ignore:
Timestamp:
Mar 25, 2010 2:46:49 AM (14 years ago)
Author:
zoltan@webkit.org
Message:

2010-03-25 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Eric Seidel.

svn-create-patch prints a warning for large patches
https://bugs.webkit.org/show_bug.cgi?id=32582

svn-create-patch prints a warning message for larger patches than 20k.

  • Scripts/svn-create-patch:
Location:
trunk/WebKitTools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r56522 r56524  
     12010-03-25  Zoltan Horvath  <zoltan@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        svn-create-patch prints a warning for large patches
     6        https://bugs.webkit.org/show_bug.cgi?id=32582
     7
     8        svn-create-patch prints a warning message for larger patches than 20k.
     9
     10        * Scripts/svn-create-patch:
     11
    1122010-03-25  Adam Barth  <abarth@webkit.org>
    213
  • trunk/WebKitTools/Scripts/svn-create-patch

    r55898 r56524  
    102102my $prefix = chdirReturningRelativePath($svnRoot);
    103103
     104my $patchSize = 0;
     105
    104106# Generate the diffs, in a order chosen for easy reviewing.
    105107for my $path (sort patchpathcmp values %diffFiles) {
    106     generateDiff($path, $prefix);
     108    $patchSize += generateDiff($path, $prefix);
     109}
     110
     111if ($patchSize > 20480) {
     112    print STDERR "WARNING: Patch's size is " . int($patchSize/1024) . " kbytes.\n";
     113    print STDERR "Patches 20k or smaller are more likely to be reviewed. Larger patches may sit unreviewed for a long time.\n";
    107114}
    108115
     
    232239        outputBinaryContent($file);
    233240    }
     241    return length($patch);
    234242}
    235243
Note: See TracChangeset for help on using the changeset viewer.