Changeset 56614 in webkit

Timestamp:

Mar 26, 2010 1:45:28 AM (14 years ago)

Author:

ukai@chromium.org

Message:

2010-03-26 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Shinichiro Hamaji.

[Chromium-Win] websocket_server.py failed to start
​https://bugs.webkit.org/show_bug.cgi?id=36586

subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
We don't need stdin, so use devnull as stdin.

• Scripts/webkitpy/layout_tests/port/websocket_server.py: open os.devnull for stdin

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/websocket_server.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-03-26  Fumitoshi Ukai  <ukai@chromium.org>
+
+        Reviewed by Shinichiro Hamaji.
+
+        [Chromium-Win] websocket_server.py failed to start
+        https://bugs.webkit.org/show_bug.cgi?id=36586
+        
+        subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
+        We don't need stdin, so use devnull as stdin.
+
+        * Scripts/webkitpy/layout_tests/port/websocket_server.py: open os.devnull for stdin
+
 2010-03-26  Kent Tamura  <tkent@chromium.org>
 

trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/websocket_server.py

@@ -201 +201 @@
                    self._server_name, self._port))
         _log.debug('cmdline: %s' % ' '.join(start_cmd))
-        self._process = subprocess.Popen(start_cmd, stdout=self._wsout,
+        self._process = subprocess.Popen(start_cmd,
+                                         stdin=open(os.devnull, 'r'),
+                                         stdout=self._wsout,
                                          stderr=subprocess.STDOUT,
                                          env=env)