Changeset 56711 in webkit


Ignore:
Timestamp:
Mar 29, 2010 1:52:19 AM (14 years ago)
Author:
mnaganov@chromium.org
Message:

2010-03-29 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Remove a possibility of confusion from Profiles panel Welcome screen
by turning buttons into non-clickable glyphs. Also, span instructions
alongside panel width.

https://bugs.webkit.org/show_bug.cgi?id=34319

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileType.prototype.get welcomeMessage):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._addWelcomeMessage):
  • inspector/front-end/inspector.css: (.panel-enabler-view.welcome .instructions): (.panel-enabler-view.welcome button.status-bar-item):
  • src/js/HeapProfilerPanel.js: (WebInspector.HeapSnapshotProfileType.prototype.get welcomeMessage):
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r56710 r56711  
     12010-03-29  Mikhail Naganov  <mnaganov@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Remove a possibility of confusion from Profiles panel Welcome screen
     6        by turning buttons into non-clickable glyphs. Also, span instructions
     7        alongside panel width.
     8
     9        https://bugs.webkit.org/show_bug.cgi?id=34319
     10
     11        * English.lproj/localizedStrings.js:
     12        * inspector/front-end/ProfileView.js:
     13        (WebInspector.CPUProfileType.prototype.get welcomeMessage):
     14        * inspector/front-end/ProfilesPanel.js:
     15        (WebInspector.ProfilesPanel.prototype._addWelcomeMessage):
     16        * inspector/front-end/inspector.css:
     17        (.panel-enabler-view.welcome .instructions):
     18        (.panel-enabler-view.welcome button.status-bar-item):
     19
    1202010-03-26  Philippe Normand  <pnormand@igalia.com>
    221
  • trunk/WebCore/inspector/front-end/ProfileView.js

    r53366 r56711  
    602602    get welcomeMessage()
    603603    {
    604         return WebInspector.UIString("Start CPU profiling by pressing<br>the %s button on the status bar.");
     604        return WebInspector.UIString("Control CPU profiling by pressing the %s button on the status bar.");
    605605    },
    606606
  • trunk/WebCore/inspector/front-end/ProfilesPanel.js

    r55464 r56711  
    240240     
    241241            var button = new WebInspector.StatusBarButton(profileType.buttonTooltip, profileType.buttonStyle, profileType.buttonCaption);
    242             button.element.addEventListener("click", profileType.buttonClicked.bind(profileType), false);
    243242            container.appendChild(button.element);
    244243       
  • trunk/WebCore/inspector/front-end/inspector.css

    r56684 r56711  
    23072307    display: inline-block;
    23082308    vertical-align: middle;
    2309     width: 330px;
    23102309    margin: 0;
    23112310    white-space: normal;
     
    23182317
    23192318.panel-enabler-view.welcome button.status-bar-item {
    2320     vertical-align: middle;
     2319    background-image: none;
     2320    vertical-align: top;
    23212321}
    23222322
  • trunk/WebKit/chromium/ChangeLog

    r56706 r56711  
     12010-03-29  Mikhail Naganov  <mnaganov@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Remove a possibility of confusion from Profiles panel Welcome screen
     6        by turning buttons into non-clickable glyphs. Also, span instructions
     7        alongside panel width.
     8
     9        https://bugs.webkit.org/show_bug.cgi?id=34319
     10
     11        * src/js/HeapProfilerPanel.js:
     12        (WebInspector.HeapSnapshotProfileType.prototype.get welcomeMessage):
     13
    1142010-03-28  Alexey Proskuryakov  <ap@apple.com>
    215
  • trunk/WebKit/chromium/src/js/HeapProfilerPanel.js

    r54547 r56711  
    938938    get welcomeMessage()
    939939    {
    940         return WebInspector.UIString("Get a heap snapshot by pressing<br>the %s button on the status bar.");
     940        return WebInspector.UIString("Get a heap snapshot by pressing the %s button on the status bar.");
    941941    },
    942942
Note: See TracChangeset for help on using the changeset viewer.