Changeset 56743 in webkit

Timestamp:

Mar 29, 2010 3:20:25 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-03-29 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests fails java/lc3 on a clean checkout
​https://bugs.webkit.org/show_bug.cgi?id=36078

• Scripts/webkitpy/layout_tests/port/mac.py:
  • Build the java support files in check_build
  • Unwrap a line which would still fit under 80col

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/mac.py (modified) (2 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-03-29  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Adam Barth.
+
+        new-run-webkit-tests fails java/lc3 on a clean checkout
+        https://bugs.webkit.org/show_bug.cgi?id=36078
+
+        * Scripts/webkitpy/layout_tests/port/mac.py:
+         - Build the java support files in check_build
+         - Unwrap a line which would still fit under 80col
+
 2010-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/mac.py

@@ -78 +78 @@
         if self._options.target == "Debug":
             build_drt_command.append('--debug')
-        if executive.run_command(build_drt_command,
-                                 return_exit_code=True):
+        if executive.run_command(build_drt_command, return_exit_code=True):
             return False
 
@@ -90 +89 @@
         if not os.path.exists(image_diff_path):
             _log.error("ImageDiff was not found at %s" % image_diff_path)
+            return False
+
+        java_tests_path = os.path.join(self.layout_tests_dir(), "java")
+        build_java = ["/usr/bin/make", "-C", java_tests_path]
+        if executive.run_command(build_java, return_exit_code=True):
+            _log.error("Failed to build Java support files: %s" % build_java)
             return False