Changeset 56789 in webkit

Timestamp:

Mar 30, 2010 7:50:29 AM (14 years ago)

Author:

pfeldman@chromium.org

Message:

2010-03-30 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Title for show/hide short records button was adjusted.
Some unused code was removed.
​https://bugs.webkit.org/show_bug.cgi?id=36823

• inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• English.lproj/localizedStrings.js (modified) (previous)
• inspector/front-end/TimelinePanel.js (modified) (4 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-03-30  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: Title for show/hide short records button was adjusted.
+        Some unused code was removed.
+        https://bugs.webkit.org/show_bug.cgi?id=36823
+
+        * inspector/front-end/TimelinePanel.js:
+        (WebInspector.TimelinePanel.prototype._createStatusbarButtons):
+        (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked):
+        (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
+
 2010-03-30  Adam Roben  <aroben@apple.com>
 

trunk/WebCore/inspector/front-end/TimelinePanel.js

@@ -160 +160 @@
         this.clearButton.addEventListener("click", this._clearPanel.bind(this), false);
 
-        this.toggleFilterButton = new WebInspector.StatusBarButton(WebInspector.UIString("Show short records"), "timeline-filter-status-bar-item");
+        this.toggleFilterButton = new WebInspector.StatusBarButton(WebInspector.UIString("Hide short records"), "timeline-filter-status-bar-item");
         this.toggleFilterButton.addEventListener("click", this._toggleFilterButtonClicked.bind(this), false);
 
@@ -186 +186 @@
         this.toggleFilterButton.toggled = !this.toggleFilterButton.toggled;
         this._calculator._showShortEvents = this.toggleFilterButton.toggled;
+        this.toggleFilterButton.element.title = this._calculator._showShortEvents ? WebInspector.UIString("Hide short records") : WebInspector.UIString("Show short records");
         this._scheduleRefresh(true);
     },
@@ -244 +245 @@
             formattedRecord.collapsed = true;
 
-        var hasLongChildrenEvents = false;
         for (var i = 0; record.children && i < record.children.length; ++i)
-            hasLongChildrenEvents |= this._innerAddRecordToTimeline(record.children[i], formattedRecord);
-        formattedRecord._hasLongChildrenEvents = hasLongChildrenEvents;
+            this._innerAddRecordToTimeline(record.children[i], formattedRecord);
 
         if (connectedToOldRecord) {
@@ -253 +252 @@
             while (record.parent && record.parent._lastChildEndTime < record._lastChildEndTime) {
                 record.parent._lastChildEndTime = record._lastChildEndTime;
-                if (!record.parent._hasLongChildrenEvents)
-                    record.parent._hasLongChildrenEvents = record._isLongEvent();
                 record = record.parent;
             }
         }
-        return hasLongChildrenEvents || formattedRecord._isLongEvent();
     },