Changeset 56884 in webkit
- Timestamp:
- Mar 31, 2010 6:43:46 PM (14 years ago)
- Location:
- trunk/WebKitTools
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKitTools/ChangeLog
r56883 r56884 1 2010-03-31 Adam Barth <abarth@webkit.org> 2 3 Reviewed by Eric Seidel. 4 5 Make the EWS go faster by being optimistic 6 https://bugs.webkit.org/show_bug.cgi?id=36916 7 8 Have the EWS be optimistic that a patch will correctly build. This 9 should speed up the common case by not requiring two builds for every 10 patch. 11 12 * Scripts/webkitpy/tool/commands/earlywarningsystem.py: 13 * Scripts/webkitpy/tool/commands/queues.py: 14 1 15 2010-03-31 Adam Barth <abarth@webkit.org> 2 16 -
trunk/WebKitTools/Scripts/webkitpy/tool/commands/earlywarningsystem.py
r56802 r56884 44 44 45 45 def should_proceed_with_work_item(self, patch): 46 return True 47 48 def _can_build(self): 46 49 try: 47 50 self.run_webkit_patch([ … … 50 53 "--build-style=%s" % self._build_style, 51 54 "--force-clean", 55 "--no-update", 52 56 "--quiet"]) 53 self._update_status("Building", patch)57 return True 54 58 except ScriptError, e: 55 59 self._update_status("Unable to perform a build") 56 60 return False 61 62 def _build(self, patch, first_run=False): 63 try: 64 args = [ 65 "build-attachment", 66 self.port.flag(), 67 "--build-style=%s" % self._build_style, 68 "--force-clean", 69 "--quiet", 70 "--non-interactive", 71 patch.id()] 72 if not first_run: 73 # See commit-queue for an explanation of what we're doing here. 74 args.append("--no-update") 75 args.append("--parent-command=%s" % self.name) 76 self.run_webkit_patch(args) 77 return True 78 except ScriptError, e: 79 if first_run: 80 return False 81 raise 82 83 def review_patch(self, patch): 84 if not self._build(patch, first_run=True): 85 if not self._can_build(): 86 return False 87 self._build() 57 88 return True 58 59 def _review_patch(self, patch):60 self.run_webkit_patch([61 "build-attachment",62 self.port.flag(),63 "--build-style=%s" % self._build_style,64 "--force-clean",65 "--quiet",66 "--non-interactive",67 "--parent-command=%s" % self.name,68 "--no-update",69 patch.id()])70 89 71 90 @classmethod -
trunk/WebKitTools/Scripts/webkitpy/tool/commands/queues.py
r56857 r56884 236 236 return False 237 237 self._did_fail(patch) 238 raise e238 raise 239 239 240 240 def process_work_item(self, patch): … … 275 275 AbstractPatchQueue.__init__(self, options) 276 276 277 def _review_patch(self, patch):277 def review_patch(self, patch): 278 278 raise NotImplementedError, "subclasses must implement" 279 279 … … 309 309 def process_work_item(self, patch): 310 310 try: 311 self._review_patch(patch)312 self._did_pass(patch)311 if self.review_patch(patch): 312 self._did_pass(patch) 313 313 except ScriptError, e: 314 314 if e.exit_code != QueueEngine.handled_error_code: … … 335 335 return True 336 336 337 def _review_patch(self, patch):337 def review_patch(self, patch): 338 338 self.run_webkit_patch(["check-style", "--force-clean", "--non-interactive", "--parent-command=style-queue", patch.id()]) 339 return True 339 340 340 341 @classmethod
Note: See TracChangeset
for help on using the changeset viewer.